[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3647

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

 CC||ejouelle...@gmail.com

--- Comment #16 from Julien Nabet  ---
*** Bug 105946 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #15 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4bde081f7ebaf3d6e489a50b287f82ccb14de224=libreoffice-5-3

tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBar

It will be available in 5.3.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Xisco Faulí  ---
Verified in

Version: 5.4.0.0.alpha0+
Build ID: 36afb355ac37122d32d624db079def123ef548a2
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

@Noel: Thank you for fixing this

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #13 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cd9d8315141c3070f43e145ed4ee390e837eb73f

tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBar

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

 Status|REOPENED|NEW
 Whiteboard|target:5.4.0 target:5.3.0.2 |

--- Comment #12 from Julien Nabet  ---
Xisco/Baffclan: you're right indeed, sorry for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #11 from Xisco Faulí  ---
(In reply to baffclan from comment #10)
> It is not Fixed.
> 
> 
> Steps to Reproduce:
> 1. Start LibreOffice
> 2. Create New Writer Document
> 3. Detach Side Bar
> 4. Click a "Gallery"
> 5. Click a "New Theme..."
> 6. Nothing happened
> 7. Close detached Side Bar
> 8. Click [X] on Title bar, Nothing happened
> 
> Cannot exit LibO
> hangup a LibO
> 
> Version: 5.4.0.0.alpha0+
> Build ID: 99eed8293d9a9689788a4134dd05d5c20c5a
> CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
> TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-01-14_23:37:30
> Locale: ja-JP (ja_JP); Calc: group

Confirmed.
In fact, if you go to Help - About LibreOffice after closing the detached
Sidebar, LibreOffice crashes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

baffclan  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #10 from baffclan  ---
It is not Fixed.


Steps to Reproduce:
1. Start LibreOffice
2. Create New Writer Document
3. Detach Side Bar
4. Click a "Gallery"
5. Click a "New Theme..."
6. Nothing happened
7. Close detached Side Bar
8. Click [X] on Title bar, Nothing happened

Cannot exit LibO
hangup a LibO

Version: 5.4.0.0.alpha0+
Build ID: 99eed8293d9a9689788a4134dd05d5c20c5a
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2017-01-14_23:37:30
Locale: ja-JP (ja_JP); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Julien Nabet  ---
Let's put this one to FIXED now after Noel's fix on master and 5.3 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #8 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c1cd678f71e519f5a4e623d93442e046485005a=libreoffice-5-3

tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBar

It will be available in 5.3.0.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

--- Comment #7 from Adolfo Jayme  ---
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a076a062ceb02bd34a460819db61dcbfbca5c8d7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #6 from Xisco Faulí  ---
*** Bug 105196 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

--- Comment #5 from Xisco Faulí  ---
*** Bug 105196 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||5196

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected
   Priority|high|highest
 CC||noelgran...@gmail.com,
   ||xiscofa...@libreoffice.org
Version|5.4.0.0.alpha0+ Master  |5.3.0.0.alpha1+
   Severity|major   |critical

--- Comment #4 from Xisco Faulí  ---
First it started crashing after:

author  Noel Grandin  2016-09-21 12:48:15 (GMT)
committer   Noel Grandin  2016-10-27
06:08:30 (GMT)
commit  eca5ea9f79181d45cd7fbabe2313617d3025818a (patch)
tree10b5837fe04212349825742b38f5a37be9ce7009
parent  bbd44f8f89839b5abb4ec6c7ea195431de5b2f48 (diff)
make the AbstractDialog stuff extend from VclReferenceBase
Because some stuff wants to multiple-inherit from VclAbstractDialog and
OutputDevice-subclasses, and we'd prefer to keep all the lifetime
management through a single smart pointer class (VclPtr)

The change in msgbox.cxx and window.cxx is to workaround a bug in
VS2013 to do with virtual inheritance and delegating constructors.

and then it changed to two clicks after:

author  Noel Grandin  2016-11-10 10:53:02
(GMT)
committer   Noel Grandin  2016-11-11
06:55:41 (GMT)
commit  78b4a1fb01af9ad3b3395a22f6e396be914b553e (patch)
tree846fdaea907a70fdc274a1e76642ed5e06622c0d
parent  071e23fee07b92b8f07800cda3ca7e66afe818ae (diff)
update vclwidget loplugin to find ref-dropping assigment
Look for places where we are accidentally assigning a returned-by-value
VclPtr to a T*, which generally ends up in a use-after-free.

Adding Cc: to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

   Keywords||regression
   Priority|medium  |high
 OS|Windows (All)   |All

--- Comment #3 from Julien Nabet  ---
If I don't detach side bar, LO hangs when clicking first time on "New theme..."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

baffclan  changed:

   What|Removed |Added

Crash report or|["vcl::Window::EnableInput( |["vcl::Window::EnableInput(
crash signature|bool,bool)"]|bool,bool)",
   |["mergedlo.dll"]|"mergedlo.dll"]

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |major

--- Comment #2 from Julien Nabet  ---
The weird thing too is the fact that the first click doesn't create new
gallery.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105017] Crash when click a "New Theme..." in Gallery on detached SideBar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105017

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Created attachment 130053
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130053=edit
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs