[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

László Németh  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |nem...@numbertext.org
   |desktop.org |
 CC||nem...@numbertext.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #21 from Kevin Suo  ---
Steps to Observe the Problem:

1. Download the docx file in attachment 130600, make a copy and unzip it.

2. Open comments.xml with xml editor. 
--> You will see that there are six (6)  tags, while the 1st one has the
value "A", all others are blank.

3. Open the docx file with MSO, count the total lines (paragraphs) in the
comments.
--> There are six (6), including "A". This is correct, same as the xml file
shows,

4. Open the docx file with Writer, count the total lines (paragraphs) in the
comments.
--> There are seven (7), including "A". This is wrong! The xml file shows 6
 only.

So I guess there is sth wrong with a for-loop in the fileopen code,e.g.:
for (i=0;i

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

Kevin Suo  changed:

   What|Removed |Added

   Keywords|bibisectRequest |preBibisect
 OS|All |Windows (All)

--- Comment #20 from Kevin Suo  ---
(In reply to Telesto from comment #12)
Are you sure this is reproducible on linux? I tried hard but do not reproduce
in anyway.

I also reviewed the comments, no one says it was reproducible on linux.

I am setting platform back to Win, keyword preBibisect.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #19 from Gabor Kelemen  ---
Created attachment 139816
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139816=edit
Word reads the files correctly too

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #17 from Gabor Kelemen  ---
Created attachment 139814
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139814=edit
The two example files opened on Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #18 from Gabor Kelemen  ---
Created attachment 139815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139815=edit
The two example files opened on Windows - New lines added to the comments

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #14 from Gabor Kelemen  ---
Created attachment 139811
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139811=edit
Example file made on Ubuntu with 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #16 from Gabor Kelemen  ---
Created attachment 139813
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139813=edit
Diff of the contents.xml files - no difference in saved new lines

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #15 from Gabor Kelemen  ---
Created attachment 139812
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139812=edit
Example file made on Windows with 5.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

--- Comment #13 from Gabor Kelemen  ---
I investigated this a bit. Made two similar files under Linux in 5.4.4 and
Windows 5.4.2 (shall check on 6.0 yet)

I created two simple example docx files, one on Linux and one on Windows, with
a comment in them, but without ending newline.

What happened: 
- The generated comments.xml files inside do not differ content wise. There is
no new line stored in either of them.
- When opening the files on Linux, neither gets an extra new line ending.
- When opening the files on Windows, both gets an extra new line ending. Then
this can be correctly written out on save - so this is a Windows-specific file
open bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105444] Extra blank lines inserted at end of Comments in DOCX on save when text added in document before comment (steps in Comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105444

Timur  changed:

   What|Removed |Added

   Priority|medium  |low
Summary|Extra lines inserted at end |Extra blank lines inserted
   |of Comments in DOCX (steps  |at end of Comments in DOCX
   |in Comment 8)   |on save when text added in
   ||document before comment
   ||(steps in Comment 8)
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs