[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Whiteboard||target:7.0.0
 Status|NEW |RESOLVED

--- Comment #22 from Aron Budea  ---
I agree. Reverse bibisected the fix with repo bibisect-linux-64-7.0 to the
following commit. Let's close as FIXED.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b77d17c4f1ca734babf962b45c1aa07bdca14e9
author  Michael Meeks  2020-01-04
18:09:20 +
committer   Michael Meeks  2020-01-06
19:16:28 +0100

sidebar: allow panels to lurk around instead of being disposed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 CC||sdc.bla...@youmail.dk

--- Comment #21 from sdc.bla...@youmail.dk ---
WFM, how about you?

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 3c6177be2705303044e3de262689d593f3d0f282
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: da-DK (en_DK); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #20 from Telesto  ---
Repro with
Version: 6.3.0.0.alpha0+
Build ID: 20ea90a557b5bc744fd234e3a20ab1db484cf88b
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-03-22_03:21:58
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||4892

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #19 from Pierre-Alain Dorange  ---
With last 5.x revision it was even worst.
Draw module was not usable, all the interface was so slow and so
unresponsiness...

Even with the sidebar hidden rgere was noticable lags.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||0627

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

 Whiteboard|target:6.0.0|

--- Comment #18 from Telesto  ---
Removing "target:6.0.0". The commit in question has been reverted.

The issue seems to be the most problematic on MacOS. The reports are still
coming in, but end up in general MacOS performance bug reports:
https://bugs.documentfoundation.org/show_bug.cgi?id=106154#c28
https://bugs.documentfoundation.org/show_bug.cgi?id=106703#c2

I priority bump would be nice (in my opinion). The source of the problem is
known (comment 16).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6962

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=11 |
   |2730|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

 CC||pdora...@mac.com

--- Comment #17 from Telesto  ---
*** Bug 109257 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #16 from Telesto  ---
It seems to work without any issue - on MacOS - when I remove the following: 

// TODO: this call is redundant but mandatory for unit test to update context
on document loading
UpdateConfigurations(); 

https://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/SidebarController.cxx#281

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||2730

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||1894

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #15 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bc8a46534e03d9dc81c92756957cbae84d72b953

Revert "Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl"

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #13 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c0cc5cd7befffc6e8e6361ba67807a799cc997f

Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #12 from Julien Nabet  ---
(In reply to Alex Thurgood from comment #10)
> In addition, there is also:
> 
> tbcontrl.cxx, lines 3235-3236:
> 
> void SvxColorListBox::EnsurePaletteManager()
> {
> if (!m_xPaletteManager)
> {
> m_xPaletteManager.reset(new PaletteManager);
> m_xPaletteManager->SetColorSelectFunction(m_aColorWrapper);
> m_xPaletteManager->SetLastColor(m_aSelectedColor.first);
> }
> }

I think we should add m_xPaletteManager.reset(nullptr);
in SvxColorToolBoxControl::~SvxColorToolBoxControl (see
https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/tbcontrl.cxx#2800)

BTW, perhaps m_xPaletteManager from colorbox.hxx could be deleted since it
seems unused.

Here too, I'll be able to submit a patch about it tonight if nobody does it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #11 from Julien Nabet  ---
(In reply to Alex Thurgood from comment #9)
> In PaletteManager.cxx :
> 
> line 109:
> 
>  pPalette.reset(new PaletteSOC(aFileStat.getFileURL(), aFNameWithoutExt));
>...
I think this one needs

"m_Palettes.clear();" in PaletteManager::~PaletteManager()

(see
https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls/PaletteManager.cxx#63)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #9 from Alex Thurgood  ---
In PaletteManager.cxx :

line 109:

 pPalette.reset(new PaletteSOC(aFileStat.getFileURL(), aFNameWithoutExt));

in the following block:

{
std::unique_ptr pPalette;
if( aFName.endsWithIgnoreAsciiCase(".gpl") )
pPalette.reset(new
PaletteGPL(aFileStat.getFileURL(), aFNameWithoutExt));
else if( aFName.endsWithIgnoreAsciiCase(".soc") )
pPalette.reset(new
PaletteSOC(aFileStat.getFileURL(), aFNameWithoutExt));
else if ( aFName.endsWithIgnoreAsciiCase(".ase") )
pPalette.reset(new
PaletteASE(aFileStat.getFileURL(), aFNameWithoutExt));

if( pPalette && pPalette->IsValid() )
m_Palettes.push_back( std::move(pPalette) );
aNames.insert(aFNameWithoutExt);
}


seems to be invoked numerous times and not released.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #10 from Alex Thurgood  ---
In addition, there is also:

tbcontrl.cxx, lines 3235-3236:

void SvxColorListBox::EnsurePaletteManager()
{
if (!m_xPaletteManager)
{
m_xPaletteManager.reset(new PaletteManager);
m_xPaletteManager->SetColorSelectFunction(m_aColorWrapper);
m_xPaletteManager->SetLastColor(m_aSelectedColor.first);
}
}

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #8 from Alex Thurgood  ---
Created attachment 135607
  --> https://bugs.documentfoundation.org/attachment.cgi?id=135607=edit
Memory leak profile

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

--- Comment #7 from Alex Thurgood  ---
Am enclosing a memory profile trace produced on macOS with Apple's Instruments
memory leak checker/profiler application.

1) Load test file
2) Select first square with mouse.
3) Select second square with mouse.
4) Repeat steps 2 and 3 for a total of 3 times (3 cycles)
5) Close the document.
6) Shut down the office process.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||9257

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105500] Small but noticeable lag when selecting shapes with sidebar enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105500

Telesto  changed:

   What|Removed |Added

 Blocks||108636
Summary|Small but noticeable lag|Small but noticeable lag
   |when selecting shapes   |when selecting shapes with
   ||sidebar enabled

--- Comment #6 from Telesto  ---
The lag is most likely caused by the fact that the sidebar is refreshing when a
new shape is selected, which causes the reload of all palette related files
(for example standard.soc) 

It's working fine without sidebar.

Version: 6.0.0.0.alpha0+
Build ID: 9f3814af7264ce90685a82cbf4eb015a38f22bf7
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-28_00:47:42
Locale: nl-NL (nl_NL); Calc: CL


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108636
[Bug 108636] [META] Extensive file accesses
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs