[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #18 from Volga  ---
OK, this is fixed.

Version: 6.0.0.1 (x64)
Build ID：d2bec56d7865f05a1003dc88449f2b0fdd85309a
CPU 线程：4; 操作系统：Windows 10.0; UI 渲染：默认; 
区域语言：zh-CN (zh_CN); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #17 from Xisco Faulí  ---
A polite ping to Takeshi Abe: is this bug fixed? if so, could you please close
it as RESOLVED FIXED ? Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #16 from Xisco Faulí  ---
Polite ping: is this bug fixed? if so, please close it as RESOLVED FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #15 from Commit Notification 
 ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb0bf56948d7f968717f4a3f53ce56e320cd5f36

tdf#105538 Download update to Downloads folder on Windows

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #14 from Volga  ---
(In reply to Markus Mohrhard from comment #13)
> (In reply to V Stuart Foote from comment #12)
> > (In reply to Takeshi Abe from comment #11)
> > > By the way, is it better or not to apply a similar change to other OS than
> > > Windows too?
> > 
> > @moggi, this covers Windows but is controling a suitable download location
> > for updates going to need attention cross platform moving forward with your
> > MAR based incrementals?
> 
> First this bug report is about the old update checker and not the new
> automatic updater. Most likely this bug will go away at some point just by
> removing the old update checker.
> 
> The new updater is going to store the update files in the LibreOffice user
> profile for now.

Oh yeah, that’s a good choice.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #13 from Markus Mohrhard  ---
(In reply to V Stuart Foote from comment #12)
> (In reply to Takeshi Abe from comment #11)
> > By the way, is it better or not to apply a similar change to other OS than
> > Windows too?
> 
> @moggi, this covers Windows but is controling a suitable download location
> for updates going to need attention cross platform moving forward with your
> MAR based incrementals?

First this bug report is about the old update checker and not the new automatic
updater. Most likely this bug will go away at some point just by removing the
old update checker.

The new updater is going to store the update files in the LibreOffice user
profile for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

V Stuart Foote  changed:

   What|Removed |Added

 CC||markus.mohrhard@googlemail.
   ||com

--- Comment #12 from V Stuart Foote  ---
(In reply to Takeshi Abe from comment #11)
> By the way, is it better or not to apply a similar change to other OS than
> Windows too?

@moggi, this covers Windows but is controling a suitable download location for
updates going to need attention cross platform moving forward with your MAR
based incrementals?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #11 from Takeshi Abe  ---
By the way, is it better or not to apply a similar change to other OS than
Windows too?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #10 from Volga  ---
(In reply to V Stuart Foote from comment #7)
> Another facet, the change from CLSID to KNOWNFOLDERID based method is only
> supported from MS Windows Vista onward. We will need to consider provision
> for update of Windows XP while that remains a "supported" OS.
LibreOffice removed support for Windows XP and Vista, so we may not necessary
to consider them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #9 from Volga  ---
I suggest we integrate a mecanism to check OS version first, then we try to get
the solutions separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Volga  changed:

   What|Removed |Added

 Blocks||60251


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=60251
[Bug 60251] [META] ACCESSIBILITY: Tracking Windows OS accessibility and AT
issues
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

jan iversen  changed:

   What|Removed |Added

   Keywords|easyHack|

--- Comment #8 from jan iversen  ---
removing easyhack, it does not look like something a new contrbutor can "just"
do.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

V Stuart Foote  changed:

   What|Removed |Added

   Keywords|needsDevEval|needsDevAdvice

--- Comment #7 from V Stuart Foote  ---
Another facet, the change from CLSID to KNOWNFOLDERID based method is only
supported from MS Windows Vista onward. We will need to consider provision for
update of Windows XP while that remains a "supported" OS.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

jan iversen  changed:

   What|Removed |Added

   Keywords||easyHack

--- Comment #6 from jan iversen  ---
(In reply to Samuel Mehrbrodt (CIB) from comment #5)
> easyHack and needsDevEval are mutually exclusive. Removed easyHack for now.

 we use that combination for more than 1 year.

If an easyhack missed e.g. code pointers needsDevEval is set. Please do a
search, to see how often that combination is used.

Did you think of needsDevAdvice, which is used for developer advice (whether or
not a think is doable at all).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

   Keywords|easyHack|
 CC||s.mehrbr...@gmail.com

--- Comment #5 from Samuel Mehrbrodt (CIB)  ---
easyHack and needsDevEval are mutually exclusive. Removed easyHack for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |easyHack, needsDevEval

--- Comment #4 from Heiko Tietze  ---
(In reply to V Stuart Foote from comment #2)
> ... %USERPROFILE%/Downloads... Easy hack?

Agreed (-needsUX) and likely (+easyhack).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #3 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #2)
> Probably reasonable to make use of the now Windows OS default provision of a
> writable %USERPROFILE%/Downloads directory.
> 

Was no CLSID (constant special item ID list) defined for Downloads with old
system, why Desktop is now the default for our downloads. 

For the new its KNOWNFOLDERID handle is "FOLDERID_Downloads" accessed with the
SHGetKnownFolderPath() function. Still looks pretty straight forward
substitution.

=-refs-=

https://msdn.microsoft.com/en-us/library/windows/desktop/dd378457%28v=vs.85%29.aspx

https://msdn.microsoft.com/en-us/library/windows/desktop/bb762188%28v=vs.85%29.aspx

http://stackoverflow.com/questions/28963848/shgetfolderpath-download-folder

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Somewhat a legacy setting pre Vista, intent being to direct the download to a
directory user has write permission to and will find. Or, failing that to a
common location with write permissions for all users [1][2].

Probably reasonable to make use of the now Windows OS default provision of a
writable %USERPROFILE%/Downloads directory.

The getDesktopDirectory() seems to only be used for the online update, so
should be able to adjust it perhaps to getDownloadsDirectory()

Easy hack?

=-ref-=

[1]
http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.hxx#140

[2]
http://opengrok.libreoffice.org/xref/core/extensions/source/update/check/updatecheckconfig.cxx#163

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105538] Download destination folder should be default to Download folder on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105538

--- Comment #1 from Volga  ---
Created attachment 130688
  --> https://bugs.documentfoundation.org/attachment.cgi?id=130688=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs