[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #15 from OfficeUser  ---
@Xisco: Thank you very much for the successful bibisect!

This patch makes so much trouble and must be revoked asap with effect for the
next  bugfix release. Is it already revoked from the branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #14 from OfficeUser  ---
*** Bug 106111 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #13 from Xisco Faulí  ---
(In reply to Khaled Hosny from comment #7)
> We were already using different spacing on Linux and Mac, so at least we are
> now consistent across platforms.
> 
> I don’t consider this a regression, it is by design to fix how line spacing
> is calculated once and for all, which fixes issues like bug 55469.
> 
> This is not a bug AFAIC, however if we think strongly about preserving
> backward compatibility here (including the bugs, of course) then I think a
> flag needs to be set somewhere for old documents and propagated to VCL that
> signals calculating line spacing the old way.

After bug 106111, which is introduced by
34d7602954d4483b3bc9db700e7df2c15348947a, this can be considered a regression
in my humble opinion...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Xisco Faulí  changed:

   What|Removed |Added

 CC||norbert.n...@gmx.de

--- Comment #12 from Xisco Faulí  ---
*** Bug 106111 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Heiko Tietze  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu

--- Comment #11 from Heiko Tietze  ---
(In reply to Thomas Lendo from comment #9)
> The line spacing is too small now (it seems that this was true in the past
> on Linux/Mac). 
> ..
> Created attachment 131075 [details]

Looks not bad to me. But there must not be such a difference to Excel,
depending on how you create the examples. @Stuart What's your opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #9 from Thomas Lendo  ---
Created attachment 131075
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131075=edit
Second test: file made with LibO 5.3.0.3

--- Comment #10 from Thomas Lendo  ---
Created attachment 131076
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131076=edit
Second test: file made with Excel 2010

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #8 from Thomas Lendo  ---
Khaled, thanks for your work on making spacing consistent across platforms.
Overall, that's good and makes things easier in the future.

Based on your statement I would rephrase my bug report:
The line spacing is too small now (it seems that this was true in the past on
Linux/Mac). Multi-line content looks crowded together and not so good readable.
Other programs use line spacing that facilitates readability in a better way.

--- Comment #9 from Thomas Lendo  ---
Created attachment 131075
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131075=edit
Second test: file made with LibO 5.3.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #8 from Thomas Lendo  ---
Khaled, thanks for your work on making spacing consistent across platforms.
Overall, that's good and makes things easier in the future.

Based on your statement I would rephrase my bug report:
The line spacing is too small now (it seems that this was true in the past on
Linux/Mac). Multi-line content looks crowded together and not so good readable.
Other programs use line spacing that facilitates readability in a better way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #7 from Khaled Hosny  ---
We were already using different spacing on Linux and Mac, so at least we are
now consistent across platforms.

I don’t consider this a regression, it is by design to fix how line spacing is
calculated once and for all, which fixes issues like bug 55469.

This is not a bug AFAIC, however if we think strongly about preserving backward
compatibility here (including the bugs, of course) then I think a flag needs to
be set somewhere for old documents and propagated to VCL that signals
calculating line spacing the old way.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #6 from Xisco Faulí  ---
Regression introduced by:

author  Khaled Hosny 2016-11-09 13:22:43 (GMT)
committer   Khaled Hosny 2016-11-22 15:32:11
(GMT)
commit  34d7602954d4483b3bc9db700e7df2c15348947a (patch)
tree8dcfb93fc29815fd89481a7840d64d6c187534db
parent  c855aec445628f96d3d32cfde6efd4e51e4489c9 (diff)
tdf#55469 Consistent line spacing across platforms

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

Thomas Lendo  changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #5 from Thomas Lendo  ---
Bug 55469 is mentioned at the 5.3 release notes wiki page. But I don't see why
changes in Math visualization should have effected spreadsheet visualization.
Is this possible? I will add Khaled Hosny to CC list, maybe he knows more about
this.

Timur:
I think this is a bug because the new behavior disturb the continuity of
OpenDocument file presentation. Users are rightly assuming that their files
looks the same in different LibO versions (especially when NO file format
changes were made as in ODF 1.0 > ODF 1.2 or DOC > ODF). Apart from that the
new line spacing looks ugly (too small/crowded).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #4 from Timur  ---
Nicely prepared bug report.
I don't see why this would be a bug, maybe some change from
https://wiki.documentfoundation.org/ReleaseNotes/5.3. 
I'm not an expert, and I won't change the status.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #2 from Thomas Lendo  ---
Created attachment 131017
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131017=edit
Test file made with 5.3.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #3 from Thomas Lendo  ---
Created attachment 131018
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131018=edit
Test file made with 5.1.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 105860] CALC: line spacing different between program versions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105860

--- Comment #1 from Thomas Lendo  ---
Created attachment 131016
  --> https://bugs.documentfoundation.org/attachment.cgi?id=131016=edit
Line spacing in 5.1.4.2 and 5.3.0.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs