[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.4.0|target:5.4.0 target:5.3.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

--- Comment #8 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4820c9b981e060a55b3511272824dca7c2eb67d5=libreoffice-5-3

tdf#107512 sw: fix rollback of text attributes in SwUndoDelete

It will be available in 5.3.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

Michael Stahl  changed:

   What|Removed |Added

   Keywords|regression  |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Michael Stahl  ---
yeah arguably this bug isn't a regression, it just got much more important due
to new usage of hidden text triggering this start-of-paragraph corner case

fixed on master

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

--- Comment #6 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=771d85baf18e5b503eb6248e1f41928b00265d8d

tdf#107512 sw: fix rollback of text attributes in SwUndoDelete

It will be available in 5.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

--- Comment #5 from Caolán McNamara  ---
Created attachment 133070
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133070=edit
standalone example

I think the underlying problem precedes this, e.g. in this example, ctrl+a, del
and undo and the hidden property after the image seems to be set across the
image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||caol...@redhat.com,
   ||r...@post.cz

--- Comment #4 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one?
Thanks

adfd5d29476d56c658d7780c6f7e5c952a4d7e8e is the first bad commit
commit adfd5d29476d56c658d7780c6f7e5c952a4d7e8e
Author: Jenkins Build User 
Date:   Thu Oct 27 23:09:56 2016 +0200

source sha:feedd45ba2dd308af2d3a1b2f64681b9467535b6

author  Caolán McNamara 2016-10-27 13:37:03 (GMT)
committer   Caolán McNamara 2016-10-27 13:37:03
(GMT)
commit  feedd45ba2dd308af2d3a1b2f64681b9467535b6 (patch)
treee513616af72c8b0effd4b57eb1b1744828153d78
parent  f6ff0c237bde50d1fab6b19d8738b6f3f042 (diff)
in msword the hard-break between image and caption has a width

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

raal  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

--- Comment #3 from Eld0r  ---
(In reply to Eld0r from comment #2)
> Additional info:
> 
> My document shows more than 25 MiB, but my big pictures are missing under
> point Images in the Navigator.
> Looks like the bits are somewhere in the document as dead code...
> 

I just realized, that my images are PNGs with sizes below 10 KiB.
Resulting in a overall filesize of 102 KiB for this new document with copied
text. INCLUDING the images. This info may help or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

--- Comment #2 from til...@gmx.de ---
Additional info:

My document shows more than 25 MiB, but my big pictures are missing under point
Images in the Navigator.
Looks like the bits are somewhere in the document as dead code...


About LibreOffice:

Version: 5.3.2.2
Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; Layout Engine:
new; 
Locale: de-DE (de_DE); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

Telesto  changed:

   What|Removed |Added

 Blocks||105948


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Telesto  ---
Confirming with:
Version: 5.4.0.0.alpha0+
Build ID: 597a2f5d5bd37443262b0775b8439bc3502aef1b
CPU threads: 4; OS: Windows 6.2; UI render: GL; 
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2017-04-26_22:29:37
Locale: nl-NL (nl_NL); Calc: CL

but not with
Versie: 5.2.4.2 
Build ID: 3d5603e1122f0f102b62521720ab13a38a4e0eb0
CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: GL; 
Locale: nl-NL (nl_NL); Calc: CL

Another one:
1. Paste a picture
2. Insert caption
3. Undo insert caption (CRTL+Z)
4. Redo Insert caption (CTRL+Y)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107512] Undo cut/ delete of image with caption frame does not restore image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107512

til...@gmx.de changed:

   What|Removed |Added

Summary|Undo cut/delete of image|Undo cut/delete of image
   |with caption frame does not |with caption frame does not
   |restore images  |restore image

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs