[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-06-19 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Marco Cecchetti  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Marco Cecchetti  ---
No issue has been reported about my patch in 2 weeks. So I think that's fine to
close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #15 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=23ee2d252e4e026657e9b52e5c9132ca201ac43e=libreoffice-5-4

tdf#107682 - Repeated images replace correct ones in exported PDF

It will be available in 5.4.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #14 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "libreoffice-5-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=83bd801268203a28a47bafd17307c13fbc41e983=libreoffice-5-3

tdf#107682 - Repeated images replace correct ones in exported PDF

It will be available in 5.3.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.5.0|target:5.5.0 target:5.3.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.5.0 target:5.3.4   |target:5.5.0 target:5.3.4
   ||target:5.4.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-30 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #13 from Commit Notification 
 ---
Marco Cecchetti committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a01c2d4cab8c3f1a4ba61e7c4e049771612127e

tdf#107682 - Repeated images replace correct ones in exported PDF

It will be available in 5.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-29 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Marco Cecchetti  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk

--- Comment #12 from Marco Cecchetti  ---
A patch is available on gerrit:

master:
https://gerrit.libreoffice.org/#/c/38165/


Some notes for who is interested in the whole story:

The debbugging session performed didn't point out anything interesting,
moreover the debug log performed in BitmapEx.GetChecksum showed different
checksums for each one of the 4 bitmaps, and since in the checksum computation
is included the alpha channel too, it masked the fact that
ImpBitmap::GetChecksum returned 0. Fortunately Aron noticed that by copying the
removed code (old implementation) in Bitmap::GetChecksum when nRet == 0, the
exported PDF was correct and that the checksum was 0 with the new
implementation and != 0 with the old one. After a bit of investigation I found
out that the difference was due to the buffer acquire methods: in
Bitmap::Checksum (old implementation) Bitmap::AcquireReadAccess is used to get
the bitmap buffer: indeed this method relies on SalBitmap::AcquireBuffer (which
is used in the new implementation) but in case the buffer acquisition fails,
instead of giving up, it tries to update the imp bitmap instance embedded in
the bitmap (see BitmapInfoAccess::ImplCreate). 
The solution is to perform this further attemp in Bitmap::Checksum when the
value returned by ImpBitmap::GetChecksum is 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF ( with default rendering only)

2017-05-25 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Aron Budea  changed:

   What|Removed |Added

Summary|Repeated images replace |Repeated images replace
   |correct ones in exported|correct ones in exported
   |PDF |PDF (with default rendering
   ||only)

--- Comment #11 from Aron Budea  ---
Note that the bug only occurs with default rendering, and not if OpenGL is
enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-13 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||michael.me...@collabora.com
   ||, mrcek...@gmail.com,
   ||r...@post.cz

--- Comment #10 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Marco Cecchetti; Could you possibly take a look at this one?
Thanks

15dea7253f57cac001cf1a730b8ed748dda1107a is the first bad commit
commit 15dea7253f57cac001cf1a730b8ed748dda1107a
Author: Norbert Thiebaud 
Date:   Tue Sep 1 22:21:05 2015 -0700

source sha:ebb0dc14547e698d7b53005178063da72d48f075
author  Marco Cecchetti  2015-08-26 11:50:57
(GMT)
committer   Michael Meeks  2015-09-01
15:28:45 (GMT)
commit  ebb0dc14547e698d7b53005178063da72d48f075 (patch)
tree8cf95d717f32672dc8e6ecf9f6b743227ada889f
parent  7cc4cdc5ef6dff279e072af725c2d7fc1e5da0e8 (diff)
Added support for computing 64-bit checksum of bitmap in OpenGL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-08 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Jacques Guilleron  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
   Hardware|x86-64 (AMD64)  |All
Version|5.3.2.2 release |5.0.2.2 release
 Ever confirmed|0   |1

--- Comment #9 from Jacques Guilleron  ---
I reproduce only when I use "Lossless compression" with

LO 5.3.2.2 Build ID: 6cd4f1ef626f15116896b1d8e1398b56da0d0ee1
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Moteur
de mise en page : nouveau; 
Locale : fr-FR (fr_FR); Calc: CL
and 
LO 5.4.0.0.alpha1+ Build ID: 0025fc13d805751f8eeb14febbdd0033e0a6d91e
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-05-04_05:21:32
Locale: fr-FR (fr_FR); Calc: CL

This feature has changed between 
LO  5.0.2.1 Build ID: 9a18d52abbdfbdc2ac9acebec2b92e7859eb73b7
Locale : fr-FR (fr_FR)
and 
LO 5.0.1.2 Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale : fr-FR (fr_FR), which export 4 images.
under Windows 7 Home.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #8 from Adam  ---
More checks:

Linux (Debian) LibreOffice 5.2.6 works correctly
Linux (Debian) LibreOffice 5.0.1 works correctly
a second computer with Windows, LibreOffice 5.3.2, the problem appears

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org

--- Comment #7 from Jean-Baptiste Faure  ---
Not reproducible for me with LibreOffice 5.3.4.0.0+ built at home under Ubuntu
16.04 x86-64.

Version: 5.3.4.0.0+
Build ID: 2e20df6eb9fe206b89d5eecbf88eea54d0719268
Threads CPU : 4; Version de l'OS :Linux 4.4; UI Render : par défaut; VCL :
gtk3; Moteur de mise en page : nouveau; 
Ubuntu_16.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); Calc: single

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #6 from Adam  ---
Created attachment 133131
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133131=edit
shot4: LO version

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #5 from Adam  ---
Created attachment 133130
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133130=edit
shot3: the exported PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #4 from Adam  ---
Created attachment 133129
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133129=edit
shot2: options selected for export to PDF (basically none)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #3 from Adam  ---
Created attachment 133128
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133128=edit
shot1: ODT document open in Writer

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #2 from Adam  ---
Created attachment 133127
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133127=edit
exported PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 107682] Repeated images replace correct ones in exported PDF

2017-05-07 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=107682

--- Comment #1 from Adam  ---
Created attachment 133126
  --> https://bugs.documentfoundation.org/attachment.cgi?id=133126=edit
ODT file with 4 images

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs