[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #5 from Justin L  ---
proposed fix at https://gerrit.libreoffice.org/62430

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

--- Comment #4 from Justin L  ---
*** Bug 105154 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

--- Comment #3 from Justin L  ---
The unit test from bug 107618 also grows by one section each RT!!!

Interestingly, old Word 2003 also has trouble saving tdf107618.doc as .docx
format, loosing one section and one header.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com

--- Comment #2 from Justin L  ---
Created attachment 137617
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137617=edit
tdf108954_RTaddsSection.docx: homemade, minimal unit test

The problem comes because bEmit is now true after
+  bEmit = rMaster.GetHeader().IsActive() || rMaster.GetFooter().IsActive();

The fix for bug 107618 was backported to 5.4.

My first impression is that this is mostly an unfixable problem, related more
to the difference between continuous sections/page styles in LO vs MSO, than to
section endings. I need to look at the earlier bug 106492 for a better
understanding, but my gut feeling is that this just needs to be reverted.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7618,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||6492,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3931

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Pénzes Dávid  changed:

   What|Removed |Added

 Blocks||104520


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=104520
[Bug 104520] [META] DOCX (OOXML) bug tracker
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108954] FILESAVE: DOCX: new line added every roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108954

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||filter:docx, regression
 Status|UNCONFIRMED |NEW
 CC||vmik...@collabora.co.uk,
   ||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna   2017-06-13 07:05:06 (GMT)
committer   Miklos Vajna   2017-06-13 09:30:43
(GMT)
commit  2a73e7d88c19cab69733a4f6433d8576856285ac (patch)
treed448994c4d8877a8cddccc7d4302bb3797b97264
parent  16265a1f84f0ac7c16beee6a3591653eaaa90323 (diff)
tdf#107618 DOCX export: fix missing header when doc ends with section
See commit b6e62dc0dc2b284c825f1182a67bb2f9259a30ce (tdf#106492 DOCX
export: fix duplicated section break at doc end, 2017-03-21) for the
context, this is one more case where it's not OK to suppress the two
section breaks at the end of a document, since the suppressed section
break is the one that provides the headers / footers.

Bisected with bibisect-linux64-6.0

Adding Cc: to Miklos Vajna

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs