[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #16 from Justin L  ---
(In reply to Heiko Tietze from comment #10)
> Off-topic: try to select text from with different spacing (don't think it's
> true kerning). Shows me ~850 in the spin edit.

I was expecting this to be in SfxItemState
/** specifies that the property is currently in a don't care state.
This is normally used if a selection provides more than one state
for a property at the same time.
*/
const short DONT_CARE  = 16;

However, eState returns DEFAULT (32) instead, which also indicates valid
results. When there are multiple kerning settings, it seems to be returning a
random memory value because it differs every time, even on successive views.
This has been true since at least LO 5.3.

I tried to bibisect it, but it is almost impossible, because you can't trust
any negative number. It looks consistent at -2 but that is deceptive since that
is the lowest acceptable number - and so pretty much half of the random numbers
will show up as -2.  (See comment 14)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #15 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c0f914ad912796ef521ea151abf8ea7e9bc2f771

tdf#111733 TextCharacterSpacingControl::GrabFocus kerning spinbutton

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #14 from Justin L  ---
(In reply to Justin L from comment #9)
> The spinbutton only allows values up to -2 
> which isn't enough to even show "very tight (-3 pt)"

This fix (min -1638 / max 1638) just landed in master.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2334561bf15ec9b061636919efbd0e2a7b89e29b

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #13 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bb183ef3734cc3ccad81bd1ca1309f726c279870

related tdf#111733 TextCharacterSpacingControl sw draw: goto position tab

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #12 from Justin L  ---
Oops - forgot to fix the comment. Pushed to master just now...

author  Justin Luth on 2022-01-28 05:58:09 +0100
commit  e1f82fec6262db708f7911d20b62b74a4b4feab2
related tdf#11173 TextCharacterSpacingControl sw annot: goto position tab

The kerning button on the sidebar very unhelpfully
did nothing at all in comments.
It should have brought the user directly to the "position" tab
where the kerning property can be found.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e1f82fec6262db708f7911d20b62b74a4b4feab2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #11 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c73670326ce5b571c31d43721729a05a11563b01

related tdf#111733 TextCharacterSpacingControl sw: goto position tab

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #10 from Heiko Tietze  ---
Off-topic: try to select text from with different spacing (don't think it's
true kerning). Shows me ~850 in the spin edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #9 from Justin L  ---
(In reply to Heiko Tietze from comment #8)
> Well, a minor since it's not wrong any more.
Negative kerning smaller than -2 pt is still "wrong" since the spinbutton only
allows values up to -2 which isn't enough to even show "very tight (-3 pt)"

fix for that aspect is at http://gerrit.libreoffice.org/c/core/+/128984 svx
textcharacterspacingcontrol: allow smaller kerning

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #8 from Heiko Tietze  ---
(In reply to Justin L from comment #7)
> Likely the best way to handle this is to make the spin-button the default...

This wouldn't be a big improvement since the feedback is still missing which
one of the defaults has been chosen. Well, a minor since it's not wrong
anymore.

But the same applies to other controls as well. For example Underline, above in
the sidebar. The first item is always selected/focused.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #7 from Justin L  ---
While the control still doesn't pre-select "normal", since LO 7.0 it doesn't
pre-select ANYTHING in gtk3, and the actual kerning value is shown in the
custom value spin button. If that was true everywhere, that would be fine IMHO.

author Caolán McNamara on 2020-01-13 18:28:59 +0100
7.0 commit c9ba69cdfaaf19695fc8e40ba7af1d06490a123f
rework TextCharacterSpacingPopup to be a PopupWindowController

Strange thing is that in my Ubuntu 7.1.7, I still see "very tight"
pre-selected, but that is also true with
SAL_USE_VCLPLUGIN=gen instdir/program/soffice
and so likely Windows still faces this minor issue.


Likely the best way to handle this is to make the spin-button the default
focus. Right now Very Tight is made the focus by the function
TextCharacterSpacingControl::GrabFocus, introduced in commit
 weld TextCharacterSpacingControl |
https://gerrit.libreoffice.org/c/core/+/86694

Proposed fix at http://gerrit.libreoffice.org/c/core/+/128909

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #6 from Justin L  ---
repro 7.4+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 OS|Windows (All)   |All
 CC||ba...@caesar.elte.hu,
   ||szymon.k...@collabora.com
Version|6.0.0.0.alpha0+ |5.2.0.4 release

--- Comment #5 from Aron Budea  ---
This is actually a regression, and could be bibisected to the following commit,
using repo bibisect-linux-64-5.2. Adding CC: to Szymon Kłos.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ccaf108651ee7e477b09f496f33ea778307fe60b
author  Szymon Kłos 2016-04-16 16:38:43
+0200
committer   Jan Holesovsky 2016-04-20 07:53:17
+

character spacing control possible to use outside sidebar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks|112269  |112629


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112269
[Bug 112269] There is a heap overflow in libwpd. This vulnerability can be
triggered in libreoffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=112629
[Bug 112629] [META] Character content panel of the Properties deck/tab of the
sidebar
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||112269

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
still repro in

Version: 6.3.0.0.alpha0+
Build ID: d31d77b7199ecc9a7edc899d9703e9da52d5cbd1
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-04-01_00:04:09
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=112269
[Bug 112269] There is a heap overflow in libwpd. This vulnerability can be
triggered in libreoffice.
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

--- Comment #3 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 111733] Sidebar character spacing popup has wrong selection

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111733

Jacques Guilleron  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||guillero...@aol.com
 Ever confirmed|0   |1

--- Comment #2 from Jacques Guilleron  ---
Hi Tamás,

I reproduce with
LO 6.0.0.0.alpha0+ Build ID: 88179e3de8865ea07d5017ca0723afd10ad44ba7
CPU threads: 2; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2017-08-06_23:49:25
Locale: fr-FR (fr_FR); Calc: CL

I agree that the actual spacing should be selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs