[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127 Meryem Ezber changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |meryemezber...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127
Muhammet Kara changed:
What|Removed |Added
Keywords||difficultyBeginner,
||easyHack, skillCpp, skillUI
--- Comment #4 from Muhammet Kara ---
(In reply to Muhammet Kara from comment #3)
> Actually, the Draw page is also named as "Slide 1". It should be "Page 1"
> instead.
Let's keep this separate for now.
Here are the code pointers (or, suggested workflow):
Let's try to find the code pointers together. We will use the Linux/bash
terminal command "grep" to search through the source files. We will issue
commands inside the "core" repo.
core git grep "Rename Slide"
android/source/res/values/strings.xml:Rename Slide
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu:
Rename Slide
sd/inc/strings.hrc:#define STR_TITLE_RENAMESLIDE
NC_("STR_TITLE_RENAMESLIDE", "Rename Slide")
So there are 3 possible candidates where this string is used. Pay attention to
sd/inc/strings.hrc:#define STR_TITLE_RENAMESLIDE
STR_TITLE_RENAMESLIDE here is called a define, and it is used as a shortcut
(google "preprocessor macros" for more info) to the string, and it allows
localization. Wherever we use this shortcut instead of directly using the
string itself, it will come up as a localized version for the user's language.
Now, let's see where this shortcut is used:
core git grep -n STR_TITLE_RENAMESLIDE
sd/inc/strings.hrc:235:#define STR_TITLE_RENAMESLIDE
NC_("STR_TITLE_RENAMESLIDE", "Rename Slide")
sd/source/ui/slidesorter/controller/SlsSlotManager.cxx:867:aTitle =
SdResId( STR_TITLE_RENAMESLIDE );
sd/source/ui/view/drviews2.cxx:792:OUString aTitle =
SdResId(STR_TITLE_RENAMESLIDE);
sd/source/ui/view/unmodpg.cxx:175:,
maComment(SdResId(STR_TITLE_RENAMESLIDE))
Since we are interested in the title of a dialog, it is probably a good idea to
check the instances of variable named "aTitle". (Btw, you see that we used
"grep -n" instead of "grep" this time. "-n" brings the results with line
numbers.)
A quick way to check which one is correct is to put a break point to the
concerned lines, open a new Draw doc, right click on the page on the page pane,
and select "Rename Page". If you hit a break point, you will know it is the
right place. Let's do that:
(You need to have gdb installed on your system, you should be inside the core
directory, and you should have a debug build: simply add these to your
autogen.input file before building:
--enable-debug
--enable-dbgutil)
core make debugrun
.
(gdb) b
/home/kara/core/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx:867
No source file named
/home/kara/core/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1
(/home/kara/core/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx:867)
pending.
(gdb) b /home/kara/core/sd/source/ui/view/drviews2.cxx:792
No source file named /home/kara/core/sd/source/ui/view/drviews2.cxx.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 2 (/home/kara/core/sd/source/ui/view/drviews2.cxx:792) pending.
(WATCH OUT! We have put the full paths of the source files beginning with
/home...)
(gdb) run --draw
...
Thread 1 "soffice.bin" hit Breakpoint 2,
sd::slidesorter::controller::SlotManager::RenameSlide (this=0x1ef8190,
rRequest=...) at
/home/kara/core/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx:867
867 aTitle = SdResId( STR_TITLE_RENAMESLIDE );
Ahhaa!
That's where the title of our rename dialog is determined.
Now:
* Just put an if-check against DocumentType, and put STR_TITLE_RENAMESLIDE or
STR_TITLE_RENAMEPAGE based on the document type. (If there is no
STR_TITLE_RENAMEPAGE, go to where STR_TITLE_RENAMESLIDE is defined, and add it
there)
* You can get the document type with
mrSlideSorter.GetModel().GetDocument()->GetDocumentType()
May it be easy! :)
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127 --- Comment #3 from Muhammet Kara --- Actually, the Draw page is also named as "Slide 1". It should be "Page 1" instead. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127 --- Comment #2 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127 kompilainenn <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||4175 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112127] Rename page dialog title says 'Rename Slide'
https://bugs.documentfoundation.org/show_bug.cgi?id=112127 Jacques Guilleron changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||guillero...@aol.com Ever confirmed|0 |1 --- Comment #1 from Jacques Guilleron --- Hi Yousuf, Reproduced with LO 6.0.0.0.alpha0+ Build ID: 9420391cc9f6af2a16c1db72596f277439df29e9 CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@39, Branch:master, Time: 2017-08-29_06:08:06 Locale: fr-FR (fr_FR); Calc: CL also with LO 3.5.3.2 Version ID : 235ab8a-3802056-4a8fed3-2d66ea8-e241b80 and OOo 3.1.0 000310m11 (Build:9399) on windows XP so Inherited from OOo. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
