[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #32 from Tor Lillqvist  ---
@Jonathan: if you want 5.4.4, 5.3.7, or some other already released version,
but with just this patch additionally applied, then you have to build a such
yourself, or ask/pay somebody else to do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #31 from steve -_-  ---
@jonathan: a backport is done already. 6.0 and 5.4.5 will include the fix. You
can always see that in the top of a bug in the "whiteboard" target info.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Adolfo Jayme  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.0.1   |target:6.1.0 target:6.0.0
   |target:5.4.5 target:6.0.0   |target:5.4.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #30 from Commit Notification 
 ---
Telesto committed a patch related to this issue.
It has been pushed to "libreoffice-6-0-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8fce4b9b76b1d5e3611c1dd05a1bcdcd84fb0474=libreoffice-6-0-0

tdf#112153: Set button theme properly

It will be available in 6.0.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.0.1   |target:6.1.0 target:6.0.1
   |target:5.4.5|target:5.4.5 target:6.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #29 from Tor Lillqvist  ---
What would such a "backport" mean? The versions you mentioned have already been
released.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #28 from Jonathan Levi  ---
When will one of the "target" versions containing the fix become available? Any
chance of a backport to 5.4.4 or 5.3.7 in the meantime?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

steve -_-  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #27 from steve -_-  ---
verified. important fix, thanks telesto!

Version: 6.1.0.0.alpha0+
Build ID: 6fc9d4a482ab50a1bf8fefb1dae2a6ded3c7e3dd
CPU threads: 4; OS: Mac OS X 10.13.3; UI render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2018-01-24_04:46:24
Locale: de-DE (de_DE.UTF-8); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Adolfo Jayme  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #26 from Commit Notification 
 ---
Telesto committed a patch related to this issue.
It has been pushed to "libreoffice-5-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=10763c32352af5e9998e430d4069fa26e087ec18=libreoffice-5-4

tdf#112153: Set button theme properly

It will be available in 5.4.5.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0 target:6.0.1   |target:6.1.0 target:6.0.1
   ||target:5.4.5

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #25 from Tor Lillqvist  ---
Awaiting review in gerrit...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #24 from Telesto  ---
Maybe also a backport to 6.0 and 5.4.5?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.1.0|target:6.1.0 target:6.0.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #23 from Commit Notification 
 ---
Telesto committed a patch related to this issue.
It has been pushed to "libreoffice-6-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b6db99279fcfbbe3ba3720f92c36b8ecd49635a=libreoffice-6-0

tdf#112153: Set button theme properly

It will be available in 6.0.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #22 from Commit Notification 
 ---
Telesto committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=44af50465a02b6f5566be45913a34fdbdba90133

tdf#112153: Set button theme properly

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #21 from Tor Lillqvist  ---
I submitted it for Telesto: https://gerrit.libreoffice.org/#/c/48334/

Thanks! This misfeature has been annoying me for a while whenever I run LO on
my Mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Alex Thurgood  changed:

   What|Removed |Added

 CC||stefan.kl...@email.de

--- Comment #20 from Alex Thurgood  ---
*** Bug 115145 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #19 from Xisco Faulí  ---
(In reply to Telesto from comment #18)
> Created attachment 139153 [details]
> Patch proposal
> 
> Same as comment 14. Working as expect with Sierra and High Sierra

Hi Telesto,
Please submit the patch to gerrit for review ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #18 from Telesto  ---
Created attachment 139153
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139153=edit
Patch proposal

Same as comment 14. Working as expect with Sierra and High Sierra

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|regression  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #17 from clemens.brun...@gmail.com ---
Any chance this will get integrated into LO 6? I just tested this with 6.0.0RC2
and the  issue hasn't been fixed.

Version: 6.0.0.2
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU threads: 8; OS: Mac OS X 10.13.2; UI render: GL; 
Locale: en-US (en_US.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Xisco Faulí  changed:

   What|Removed |Added

 CC||daniels.lewis...@gmail.com

--- Comment #16 from Xisco Faulí  ---
*** Bug 114989 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Adolfo Jayme  changed:

   What|Removed |Added

Version|5.3.0.0.alpha0+ |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #15 from Xisco Faulí  ---
(In reply to Telesto from comment #14)
> @Xisco
> I might have a solution. Moving "case ButtonValue::DontKnow:" (
> https://opengrok.libreoffice.org/xref/core/vcl/osx/salnativewidgets.cxx#113)
> between the current lines 108-109 -> resulting in return kThemeButtonOff;
> will resolve the issue.

Could you please submit a patch to Gerrit as described here:
https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #14 from Telesto  ---
@Xisco
I might have a solution. Moving "case ButtonValue::DontKnow:" (
https://opengrok.libreoffice.org/xref/core/vcl/osx/salnativewidgets.cxx#113)
between the current lines 108-109 -> resulting in return kThemeButtonOff; will
resolve the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Telesto  changed:

   What|Removed |Added

 CC||drjle...@aol.com

--- Comment #13 from Telesto  ---
*** Bug 113910 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #12 from Telesto  ---
Is this really a regression? I would expect a regression to be an issue caused
by a change in the LibO code.. A regression caused by some sort of
incompatibility with High Sierra is not a regression in the sense of the
keyword meaning; i think.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Version|5.3.6.1 release |5.3.0.0.alpha0+

--- Comment #11 from Xisco Faulí  ---
also reproduced in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 8; OS Version: Mac OS X 10.13.1; UI Render: default; 
Locale: en-US (en_ES.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Adolfo Jayme  changed:

   What|Removed |Added

Version|5.4.1.2 release |5.3.6.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #10 from mynothaur  ---
same bug on libreoffice 5.3.6.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

--- Comment #9 from mynothaur  ---
confirm this bug on high sierra

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112153] macOS 10.13 High Sierra - all buttons are blue ("default")

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112153

Adolfo Jayme  changed:

   What|Removed |Added

Summary|macOS 10.13 High Sierra |macOS 10.13 High Sierra -
   |beta - all buttons are blue |all buttons are blue
   |("default") |("default")

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs