[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #18 from Rafael Lima  ---
(In reply to Regina Henschel from comment #17)
> It should behave now so, that a line which the user has drawn with one mouse
> movement will become one object. If the user releases the mouse button a new
> line starts. That is similar to how the freeline tool works. Does it not
> behave that way for you? Could you please attach in that case the file the
> user gets after leaving presentation mode?

Forget about this... I had tested it wrong. You're right, it now works as the
freeline tool now, which is the expected behavior.

> I have not considered such. However, I think it is possible.

The advantage of this is that when the user draws something that is not a
single line (f.i. an arrow, or a word), then all of these lines are grouped
together.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #17 from Regina Henschel  ---
(In reply to Rafael Lima from comment #16)

> Hi Regina, I tested your fix for this issue and it works quite well. Thanks.
> 
> The only thing I'd like to suggest is that the final set of lines be grouped
> together.
> 
> With the current implementation, after the user exits the presentation and
> clicks the annotation shapes, they end up moving just a line segment.

It should behave now so, that a line which the user has drawn with one mouse
movement will become one object. If the user releases the mouse button a new
line starts. That is similar to how the freeline tool works. Does it not behave
that way for you? Could you please attach in that case the file the user gets
after leaving presentation mode?

> 
> It would be nice to have all of these segments grouped... what do you think?

I have not considered such. However, I think it is possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Rafael Lima  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #16 from Rafael Lima  ---
(In reply to Regina Henschel from comment #15)
> Because it is only a workaround, I will not set this issue to fixed.

Hi Regina, I tested your fix for this issue and it works quite well. Thanks.

The only thing I'd like to suggest is that the final set of lines be grouped
together.

With the current implementation, after the user exits the presentation and
clicks the annotation shapes, they end up moving just a line segment.

It would be nice to have all of these segments grouped... what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7054

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #15 from Regina Henschel  ---
The patch reduces the amount of points. I know, that these patches are only a
workaround, but I think it is better than the current state in LO 7.6.

Because it is only a workaround, I will not set this issue to fixed.

(In reply to Antonello from comment #12)
> Thank you @Regina..
> Is there any nightly build one can use on Linux to test?
> 
> As a general note, why reinvent the wheel and not just reuse the
> handwriting tool of slide editing ?

I don't know how to do it. The problem is, that the drawing happens in
slideshow mode whereas the handwriting tool is used in edit mode. The "mouse as
pen" tool is very old. There might be a reason, why the handwriting tool was
not use although that already exists at that time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #14 from Commit Notification 
 ---
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44c0f2da567b49ef8a539958a834f1bc841c2003

tdf#112687 Simplify polylines from slideshow annotations

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #13 from Buovjaga  ---
(In reply to Antonello from comment #12)
> Thank you @Regina..
> Is there any nightly build one can use on Linux to test?
> 
> As a general note, why reinvent the weheel and not just reuse the
> handwriting tool of slide editing ?

At the moment the daily builds are not being generated, but hopefully they will
come back soon: https://dev-builds.libreoffice.org/daily/master/current.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #12 from Antonello  ---
Thank you @Regina..
Is there any nightly build one can use on Linux to test?

As a general note, why reinvent the weheel and not just reuse the handwriting
tool of slide editing ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #11 from Regina Henschel  ---
In
https://cgit.freedesktop.org/libreoffice/core/commit/?id=631964a2ce1da3fbbeb53a5550c0e6728ba644aa
I have changed the creation of the persistent drawing so, that now the points
which belong to one pen move in slideshow are in one object in edit mode. That
does not solve the problem, that too many points are generated, but the
handling is now easier in edit mode.

Generating of points is somehow related to time. When you move the mouse
quickly, you get less points than moving the mouse slowly.

Generating of the points is located in virtual bool handleMouseDragged( const
awt::MouseEvent& e ) in
https://opengrok.libreoffice.org/xref/core/slideshow/source/engine/slide/userpaintoverlay.cxx?r=91ba9654#358

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #10 from Antonello  ---
It's really a pity this bur remains somehow hidden in the mass, as it is pretty
serious for me, as it prevents me from using libreoffice to realise distance
learning courses...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #9 from Regina Henschel  ---
The problem still exist in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice
Community
Build ID: 81daca18b69d31995bcd56f804659318398c02e2
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #8 from QA Administrators  ---
Dear Antonello,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||138293


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=138293
[Bug 138293] Add "save sketches on slides on exit" option to Slide Show
Settings dialog
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #7 from Antonello  ---
Still present in LO 6.3.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #6 from QA Administrators  ---
Dear Antonello,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #5 from Buovjaga  ---
(In reply to Antonello from comment #4)
> Hello, I know it's not nice to ping a bug report without bringing any news,
> but this bug is pretty important for me as it would allow me to use
> LibreOffice for teaching in distant learning projects, and at the same time
> it should be fairly simple to solve for someone with knowledge of the
> internals of LO Draw, as it is a matter of applying an already know
> algorithm in the context of live slide annotations.
> 
> Is there any way I could investigate this bug further or be more precise in
> its description?

I think the description is clear enough, so the only way you could help is to
dig into the code and provide a better algorithm. I don't believe this is a
regression, I assume it has always behaved like this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #4 from Antonello  ---
Hello, I know it's not nice to ping a bug report without bringing any news, but
this bug is pretty important for me as it would allow me to use LibreOffice for
teaching in distant learning projects, and at the same time it should be fairly
simple to solve for someone with knowledge of the internals of LO Draw, as it
is a matter of applying an already know algorithm in the context of live slide
annotations.

Is there any way I could investigate this bug further or be more precise in its
description?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #3 from Buovjaga  ---
Repro from scratch.

Arch Linux 64-bit, KDE Plasma 5
Version: 6.0.0.0.alpha1+
Build ID: af318eeb4e23694e17b09b902afb98ddf9da9b7b
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on November 1st 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

--- Comment #2 from Antonello  ---
Created attachment 136562
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136562=edit
Screenshot of the same file

Screenshot of the same file. I am uploading this, as opening the original file
is ok, but as soon you try to do something with the red lines, it may make your
pc unresponsive, so opening instead this screenshot is a safer option ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 112687] Presentation annotations are saved with way too many points

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112687

Antonello  changed:

   What|Removed |Added

 CC||blackh...@lobianco.org

--- Comment #1 from Antonello  ---
Created attachment 136561
  --> https://bugs.documentfoundation.org/attachment.cgi?id=136561=edit
Test slide with annotations

In the attachment lines in blue has been obtained using editing-mode
hand-writing tool, while lines in red with presentation-mode hand-writing tool.
You can see the differences if you click on them "edit points"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs