[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Buovjaga  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED

--- Comment #13 from Buovjaga  ---
Tests with OOO_EXIT_POST_STARTUP=1

attachment 137388

6.2.2:
real0m5,055s
user0m4,666s
sys 0m0,314s

Master with the latest commit:
real0m4,738s
user0m4,254s
sys 0m0,373s

attachment 107266 from bug 84635

6.2.2:
real0m9,534s
user0m9,217s
sys 0m0,483s

Master with the latest commit:
real0m10,906s
user0m10,469s
sys 0m0,498s

As the results are different, let's undupe this.

Thanks for the work!

Arch Linux 64-bit
Version: 6.2.2.2
Build ID: 6.2.2-2
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: 9c5d33e3c9e4a680af61a9e7af8fa73d08b33834
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 28 March 2019

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #12 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9c5d33e3c9e4a680af61a9e7af8fa73d08b33834%5E%21

tdf#113539 Slow opening of ODT file containing a large table

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Telesto  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=84 |
   |635 |
 Status|NEW |RESOLVED

--- Comment #11 from Telesto  ---


*** This bug has been marked as a duplicate of bug 84635 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #10 from Björn Michaelsen  ---
Hi all,

so IIRC the old implementation was unsafe at any speed: It had shared ownership
of the object an manually tracked it from multiple places (badly).

So whatever the solution to this is, its not reverting to that.

Both the before and after the path, the object was/is heap allocated. The
shared_ptr timingwise just adds synchronization. The way forward would be one
of:

- unfsck this design, so that in doesnt need shared ownership
- make whatever is using massive amounts of unocrsrs in these example files use
something more lowlevel (and faster) instead

Clearly 1/ is the best long-term solution, but it might be quite tricky to
unwind this hairball (though admittedly I havent look at trying that yet).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Buovjaga  changed:

   What|Removed |Added

 CC||bjoern.michaelsen@libreoffi
   ||ce.org

--- Comment #9 from Buovjaga  ---
(In reply to Telesto from comment #2)
> I ended up here when following the 16 second lead:
> authorBjoern Michaelsen  
> 2015-05-22
> 14:42:23 (GMT)
> committer Bjoern Michaelsen  
> 2015-05-25
> 22:51:11 (GMT)
> commit50356872b9421303b9c7b4a3135b3cdcc3a0af50 (patch)
> tree  e87d19df1c26853d567516f37f08344f287fbe72
> parent96898cd49830333d752b9aa56fe91a8e21c9dca8 (diff)
> new unocrsrs for SwXTextCursor
> Change-Id: I5932f75ee4814ca42f16d349094c7fa8bbb2ee63

Björn: what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=84
   ||635

--- Comment #8 from Telesto  ---
This seems to more or less a dupe of bug 84635. Except for the part where it
got worse in the 5.0 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #7 from Buovjaga  ---
Created attachment 137912
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137912=edit
Callgrind output from master

Arch Linux 64-bit
Version: 6.0.0.0.alpha1+
Build ID: 1d9eed341db208f11de6f020538dfdb74a5c48dd
CPU threads: 8; OS: Linux 4.13; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on November 22nd 2017

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Telesto  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #6 from Telesto  ---
A callgrind trace could be helpful.. ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Telesto  changed:

   What|Removed |Added

 Blocks||103100


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Telesto  changed:

   What|Removed |Added

   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #5 from Telesto  ---
(In reply to Xisco Faulí from comment #4)
There seems to be a difference between Linux & Windows. LibreOffice 3.3.0 is
indeed the fastest. 

$ time
/cygdrive/h/LibreOfficePortable/3.3.0/App/libreoffice/program/swriter.exe
"C:\Demo.odt"

real0m4,796s
user0m0,000s
sys 0m0,000s

However, the import time on Linux always always was 14-16 seconds between 4.1
and 6.0. A contrary to Windows. The import time always was 5-8 seconds (since
3.3.0), until the change in LibO 5.0.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
Version|5.1.0.3 release |4.1 all versions
 Ever confirmed|0   |1

--- Comment #4 from Xisco Faulí  ---
The import time seems similar (few seconds up or down ) between

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

and

Version: 6.0.0.0.alpha1+
Build ID: d30522e46ca884e9bc74af21711d9537e8118859
CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

in my case, around 

real0m24,508s
user0m16,352s
sys 0m0,416s

however, it's extremely fast in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

real0m5,255s
user0m4,840s
sys 0m0,252s

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #3 from Telesto  ---
Created attachment 137389
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137389=edit
Very Sleepy time profile

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #2 from Telesto  ---
Time required did build up a bit while bibisecting:
$ time instdir/program/soffice "C:\Demo.odt"

real0m8,290s
user0m0,000s
sys 0m0,000s

Bit worse:
$ git bisect bad
Bisecting: 8 revisions left to test after this (roughly 3 steps)
[2970f29b0ee7e9988ffbb183f2e6bb156e374409] source
sha:4020f9bbd92becd3662cdc3b24ad70b370307e5e

~/bibisect-win32-5.0
$ time instdir/program/soffice "C:\Demo.odt"

real0m11,197s
user0m0,000s
sys 0m0,015s

Worser
~/bibisect-win32-5.0
$ time instdir/program/soffice "C:\Demo.odt"

real0m16,629s
user0m0,000s
sys 0m0,000s


I ended up here when following the 16 second lead:
author  Bjoern Michaelsen  2015-05-22
14:42:23 (GMT)
committer   Bjoern Michaelsen 
2015-05-25 22:51:11 (GMT)
commit  50356872b9421303b9c7b4a3135b3cdcc3a0af50 (patch)
treee87d19df1c26853d567516f37f08344f287fbe72
parent  96898cd49830333d752b9aa56fe91a8e21c9dca8 (diff)
new unocrsrs for SwXTextCursor
Change-Id: I5932f75ee4814ca42f16d349094c7fa8bbb2ee63

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 113539] FILEOPEN ODT: Slower opening of file containing a large table (25 rows 2000 columns)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113539

--- Comment #1 from Telesto  ---
Created attachment 137388
  --> https://bugs.documentfoundation.org/attachment.cgi?id=137388=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs