[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Xisco Faulí  changed:

   What|Removed |Added

 CC||jf.per...@laposte.net

--- Comment #21 from Xisco Faulí  ---
*** Bug 115402 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Buovjaga  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
 CC||todven...@suomi24.fi

--- Comment #20 from Buovjaga  ---
I ran into a variant: "Print to file", nothing about comments. Confirmed a
fresh build makes the crashing go away.

Arch Linux 64-bit
Version: 6.1.0.0.alpha0+
Build ID: e80da60895b45309fa1d018760d5f11cca4367f4
CPU threads: 8; OS: Linux 4.14; UI render: default; VCL: kde4; 
Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded
Built on January 31st 2018

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Michael Meeks  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #19 from Michael Meeks  ---
Assuming fixed then =)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Julien Nabet  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #18 from Julien Nabet  ---
(In reply to Julien Nabet from comment #16)
> https://gerrit.libreoffice.org/#/c/48890/

Pushed (see
https://cgit.freedesktop.org/libreoffice/core/commit/?id=b4f440092b852a7c66f4acdd7e9b0c8e23e212ef)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #14 from Julien Nabet  ---
Thank you Noel, I'll take this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #13 from Noel Grandin  ---
Julien, looks like the crash in comment 12 was introduced by

commit 85b3c799ede62a3d7ad0493fc80b629214956601
Author: Julien Nabet 
Date:   Sun Jan 28 22:46:46 2018 +0100

Modernize a bit vcl (part2)

where the group variable is now not being initialised at all

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #12 from Tobias Burnus  ---
(In reply to Tobias Burnus from comment #11)
> Testing with master looks good - except that I observe bug 115302.

Testing a bit more, I STILL get a CRASH:

If I hit [OK] in the print dialog, LibreOffice now crashes. You simply need to
do

1. Create new document
2. File | Print
3. [OK]

That's with: Version: 6.1.0.0.alpha0+
Build ID: 85b3c799ede62a3d7ad0493fc80b629214956601
CPU threads: 4; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-01-29_05:58:14
Locale: en-US (en_US); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #11 from Tobias Burnus  ---
Testing with master looks good - except that I observe bug 115302.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #10 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=de9bcd167b059e00818304626c0cadaa330738a4

tdf#115221 crash in printing and comment

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #9 from Michael Meeks  ---
Patch under discussion at https://gerrit.libreoffice.org/#/c/48658

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #8 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #7)

Of course. And the clear() (in the second time!) actually deletes the
document... should it do that at all? and when it does, shouldn't it have
removed itself from some listeners list beforehand, to not receive events
initiated bu that document's destruction?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #7 from Julien Nabet  ---
(In reply to Mike Kaganski from comment #6)
> (In reply to Julien Nabet from comment #5)
> 
> The destroying viewshell gets used in the update sequence, and so its
> partially destroyed data is being accessed. The problem here IMO is how to
> ensure that it doesn't get involved in the update sequence (deregister it
> somewhere prior to the clearing the mxDoc?).

Seeing the bt:
frame 15:
328 mxDoc.clear();
frame 2:
   2549 SwView* pView =  GetDoc()->GetDocShell() ?
GetDoc()->GetDocShell()->GetView() : nullptr;

It seems indeed the call to clear() which triggers the pb.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #6 from Mike Kaganski  ---
(In reply to Julien Nabet from comment #5)

The destroying viewshell gets used in the update sequence, and so its partially
destroyed data is being accessed. The problem here IMO is how to ensure that it
doesn't get involved in the update sequence (deregister it somewhere prior to
the clearing the mxDoc?).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

--- Comment #5 from Julien Nabet  ---
Noel: this part seems weird to me:
@@ -322,14 +322,11 @@ SwViewShell::~SwViewShell()
 delete mpImp; // Delete first, so that the LayoutViews are destroyed.
 mpImp = nullptr;   // Set to zero, because ~SwFrame relies on it.

-if ( mpDoc )
+if ( mxDoc.get() )
 {
-if( !mpDoc->release() )
-{
-delete mpDoc;
-mpDoc = nullptr;
-}
-else
+auto x = mxDoc->getReferenceCount();
+mxDoc.clear();
+if( x > 1 )
 GetLayout()->ResetNewLayout();
 }

Indeed, with mxDoc, we don't call acquire anymore, so getReferenceCount is
never > 1 + we shouldn't call clear() on mxDoc manually, should we?

I thought about this patch then:
diff --git a/sw/source/core/view/vnew.cxx b/sw/source/core/view/vnew.cxx
index 2998ffb131f8..6ae4f8a07a62 100644
--- a/sw/source/core/view/vnew.cxx
+++ b/sw/source/core/view/vnew.cxx
@@ -324,10 +324,7 @@ SwViewShell::~SwViewShell()

 if ( mxDoc.get() )
 {
-auto x = mxDoc->getReferenceCount();
-mxDoc.clear();
-if( x > 1 )
-GetLayout()->ResetNewLayout();
+GetLayout()->ResetNewLayout();
 }

 delete mpOpt;
what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
Created attachment 139362
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139362=edit
bt with debug symbols

On pc Debian x86-64 with master sources updated yesterday, I could reproduce
this.

I noticed that it crashes when you change "Comments" a second time.
Indeed, for the test I chose first "Place at end of document", no crash, then I
selected "Comments only" and it crashed.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
   Priority|medium  |highest
 CC||noelgran...@gmail.com
Crash report or|d8229188-fe3d-4f87-8295-168 |["SwViewShell::GetPostItMgr
crash signature|695dc4f5c   |()"]
   Severity|normal  |critical

--- Comment #3 from Xisco Faulí  ---
Regression introduced by:

author  Noel Grandin  2017-10-04 13:30:11
+0200
committer   Noel Grandin  2017-10-05
13:49:22 +0200
commit  cc483d0470dbf0d01e4da818b148ff0b851c5187 (patch)
tree8775e63c99cca6d0d44c0f2820d859691edb4cfa
parent  74977861a63c920f9b49e90087cac9a841392729 (diff)
tdf#112292 - fix memory leak and use more auto ref counting in sw
this bug was introduced in

commit a754294ac7a902fe96fbbd6b8b6824a360d6b248
use rtl::Reference in SwDocFac instead of manual acquire/release

fix it by using automatic ref-counting (i.e. rtl::Reference) everywhere.

Note that the logic in SwViewShell::~SwViewShell is somewhat
interesting.
>From my reading of it, it was previously potentially calling
getIDocumentLayoutAccess on an SwDoc that had just been deleted.

So if there is a problem with this commit I would look there first.

Bisected with: bibisect-linux64-6.0

Adding Cc: to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
Created attachment 139357
  --> https://bugs.documentfoundation.org/attachment.cgi?id=139357=edit
gdb backtrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Mike Kaganski  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Mike Kaganski  ---
Reproduced with Version: 6.0.0.2 (x64)
Build ID: 06b618bb6f431d27fd2def25aa19c833e29b61cd
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: ru-RU (ru_RU); Calc: 

and with Version: 6.1.0.0.alpha0+ (x64)
Build ID: de1bb0878fc7d7eb6071ec94d770712648013075
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: ru-RU (ru_RU); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115221] PRINTING: CRASH immediately after choosing comment (+doc) printing in the print dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115221

Tobias Burnus  changed:

   What|Removed |Added

Crash report or||d8229188-fe3d-4f87-8295-168
crash signature||695dc4f5c

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs