[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||harald.koes...@mail.de

--- Comment #16 from V Stuart Foote  ---
*** Bug 43220 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=49 |
   |710 |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||k.dalg...@gmail.com

--- Comment #15 from V Stuart Foote  ---
*** Bug 49710 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||david.burleigh@parchmentpre
   ||ss.net

--- Comment #14 from V Stuart Foote  ---
*** Bug 98877 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||lili...@gmail.com

--- Comment #13 from V Stuart Foote  ---
*** Bug 98762 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Thomas Lendo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=49
   ||710

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #12 from Cor Nouws  ---
(In reply to Heiko Tietze from comment #11)
> As an idea, it was suggested to work these functions into the Navigator
> dialog (good idea IMO) 

The tool bar of the Navigator already is quite loaded, so I see a challenge
there..

Integrating in the Navigation bar, that can be started from the Navigator?
Could be. But will then the 'edit positions' be on of the many choices, or a
separate one?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 CC|libreoffice-ux-advise@lists |
   |.freedesktop.org|

--- Comment #10 from Heiko Tietze  ---
Removing needsUX as the decision was made to keep the functionality. As Samuel
points out we have top take care about the position of the controls; should be
done in this ticket IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #11 from Heiko Tietze  ---
As an idea, it was suggested to work these functions into the Navigator dialog
(good idea IMO) or/and added to Standard toolbar (very bad idea IMO).

Fix docking left (edit: or anywhere else), another idea, is not an option since
users define the UI and have the Navigator docked left, for example.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 CC||s.mehrbr...@gmail.com

--- Comment #9 from Samuel Mehrbrodt (CIB)  ---
I one had a patch to remove this very feature at
https://gerrit.libreoffice.org/#/c/10551/ but there were some people opposing
the removal.

So it seems to be useful to some. Of course we should make sure the toolbar
doesn't randomly pops up etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #8 from Thorsten Behrens (CIB)  ---
(In reply to V Stuart Foote from comment #7)
> @Thorsten, you mentored Maja D. in 2009 for this work--do you have any
> thoughts on what is correct here in these dark corners of the code base?

If the toolbar is the problem - move the functions somewhere else? At least
when it was implemented, people thought it's quite useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||t...@libreoffice.org

--- Comment #7 from V Stuart Foote  ---
@Thorsten, you mentored Maja D. in 2009 for this work--do you have any thoughts
on what is correct here in these dark corners of the code base?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

 CC||f...@libreoffice.org,
   ||momonas...@gmail.com
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=5608

--- Comment #6 from V Stuart Foote  ---
@Maxim, Adolfo -- does this UI navigation stack make sense to retain? That is,
is it worth salvaging? And given it was a GSOC (2009 so OOo) effort would be
sad to just purge it.

See the OOo history for the feature request: 
https://bz.apache.org/ooo/show_bug.cgi?id=5608

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=43
   ||220

--- Comment #5 from Cor Nouws  ---
(In reply to V Stuart Foote from comment #4)

> The use case is still valid, but not sure the implementation is fully
> complete, and no documentation was added to help (bug 38781).

Indeed. So better improve then remove

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar ( a GSOC 2009 contribution see bug 32869)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

V Stuart Foote  changed:

   What|Removed |Added

Summary|Removal or disabling of the |Removal or disabling of the
   |Navigation toolbar  |Navigation toolbar (a GSOC
   ||2009 contribution see bug
   ||32869)

--- Comment #4 from V Stuart Foote  ---
The Navigation toolbar is a counterpoint to the modal "Navigator", as intended
its backward and forward navigation was to be more like navigating a web
browser's history, positioning document focus to any of the established
markers. 

The use case is still valid, but not sure the implementation is fully complete,
and no documentation was added to help (bug 38781).

Kind of think that if this were fully developed, it would be a reasonable
interface to allow history movement between soffice.bin modules rather than
just the Writer shell, where as noted it is a bit confusing as to function.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

--- Comment #3 from V Stuart Foote  ---
(In reply to Heiko Tietze from comment #2)
> Jay was right, we better have an extra ticket for the UX issue. 

Sorry I should also have included link to the navmgr.hxx.

Here is Maja's original description of the navigation history. When originaly
implemented the function tracked SwPosition--but Michael S. changed that to use
SwUnoCrsr (unocrsr.hxx) for more robust behavior [1]:

class SW_DLLPUBLIC SwNavigationMgr
{
private:
/*
* List of entries in the navigation history
* Each entry is a SwPosition, which represents a position within the document
* SwPosition is given by a node index (SwNodeIndex) which usually represents
the paragraph the position is in
* and an index (SwIndex), which represents the position inside this paragraph.
* You can find more on SwPositions at
http://wiki.services.openoffice.org/wiki/Writer_Core_And_Layout
*
* The navigation history behaves as a stack, to which items are added when we
jump to a new position
* (e.g. click a link, or double click an entry from the navigator).
* Every use of the back/forward buttons results in moving the stack pointer
within the navigation history
*/

So, it seems the Navigation toolbar is a dedicated shell for Writer that tracks
movement through the UI and permits "back" button navigation of its stack with
some concept of "curency" of position in the history of movements. Provides a
helper in addition to other Navigator's by "mode" provided movements. 

For example the "reminder" mode (the Paper clip icon) keeps a separate stack of
Marks (to depth of MAX_MARKS default of 5)--but the NavigationMgr
m_aNavigationMgr receives and follows these swUnoCursr objects on its stack.
The modes provided in Navigator are specific for each flavor of events. 

IIUC the NavigationMgr exposes the movement events (that it is aware of)
[2]--and implements a toolbar with Back/Forward button controls to move among
all of them.

I think the buttons from the toolbar probably ought to have been added to the
Navigator from the beginning. The Navigator's current Previous/Next buttons
apply to the active Navigator mode--while the Navigation buttons draw events
from across the UI.  Is there a spot on the Navigator UI the more general
movements from the Navigation toolbar would make sense?

Likewise I think some of the movements in the sw UI ought to be exposed to the
Navigation toolbar's buttons but aren't--position to Top of document, End of
document, next Paragraph, next page, etc. This may need some additional dev
effort to 

Also, seems the same ability to navigate between cursor positions in the other
LO modules by Back/Forward button action would be a good enhancement if this is
the right framework to hang it off of.


=-ref-=
[1]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navmgr.hxx?#24
[2]
https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/wrtsh.hxx?#461

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Heiko Tietze  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|RESOLVED|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=38
   ||781
 Resolution|DUPLICATE   |---

--- Comment #2 from Heiko Tietze  ---
Jay was right, we better have an extra ticket for the UX issue. Discussion so
far on bug 38782:

(In reply to Olivier Hallot from comment #10)
> Behaviour is apparently erratic and lack of description does not help user.
> 
> https://ask.libreoffice.org/en/question/114955/navigation-toolbar-appears-on-inserting-headerfooter-in-a-document/

(In reply to Heiko Tietze from comment #11)
> Introduced with bug 32869 in
> https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/navmgr.cxx
> the purpose is to navigate over hyperlinks in the document. We could enhance
> the toolbar with next/previous page.

(In reply to V Stuart Foote from comment #13)
> The source [1][2] is reasonably well documented. And the Greenberg &
> Cockburn [3] "recency with temporal ordering" based back and forward history
> navigation remains.  But, if fully functional would expect the feature to be
> less about navigating hyperlinks (internal or external) and for the control
> to provide more generic Back and Forward movements within a document.
> 
> A GoToMark, GoToFLy, GotoINetAttr, GotoOutline (index), GotoOutline
> (string), GotoRegion, GotoRefMark, GotoNextTOXBase, GotoTable,GotoFld, and
> GotoRedline action were linked as history navigation targets. 
> 
> Unfortunately, not clear the "recency with temporal ordering" of the
> navigation history is still implemented correctly. I couldn't identify where
> in UI a user could "add" a mark to trigger inclusion of a SwUnoCsr position
> to the m_entries[] list and _activate_ the control. And while inserting an
> internal hyperlink--reference, bookmark, header, footer, etc. the Cusor is
> registered into the navigation history, and activates the Navigation toolbar
> controls--other actions for cursor/focus movement do not.  For example a
> Go-to-End of document should provide a Navigation toolbar action to return
> from.
> 
> =-ref-=
> [1]
> https://opengrok.libreoffice.org/xref/core/sw/source/uibase/wrtsh/navmgr.
> cxx?a=true
> 
> [2] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/navsh.hxx
> 
> [3] https://prism.ucalgary.ca/bitstream/handle/1880/45977/1999-641-04.pdf

(In reply to V Stuart Foote from comment #14)
> Aslo, if fully functional seems like this set of controls--.uno:NavigateBack
> & .uno:NavigateForward would make sense to appear in the Standard toolbar,
> or maybe the Navigator dialog adjacent to the PreviousPage/NextPage buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Heiko Tietze  ---
Raised in bug 38781 comment 10 and we should keep it there IMHO.

*** This bug has been marked as a duplicate of bug 38781 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Olivier Hallot  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=32
   ||869

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 115817] Removal or disabling of the Navigation toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115817

Yousuf Philips (jay) (retired)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||tietze.he...@gmail.com,
   ||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs