[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #7 from Xisco Faulí  ---
@Noel, should it be backported to 6-0?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

--- Comment #6 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ad0d1db3ce862ef74a7a1849b821f5010f9ba3fd

tdf#116799 Border selection icon tool in sidebar disappearing

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

--- Comment #5 from Telesto  ---
> The other bug is that sometimes selecting a different thing in the drop-down
> does not update the main icon. For some reason, sometimes that event does
> not get called. This part of the bug exists at least as far back as 
> the 6.0.1.1 release, and affects both Windows and Linux(Gnome).

Probably unfinished work or an implementation error. It's also in:
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

And thinking about it, this same deck should be in Writer too (for consistency
reason)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

--- Comment #4 from Noel Grandin  ---
Note that there is at least two bugs here: 

One bug is the one I caused, and which I'll have a fix for shortly, where the
code that draws the border lines over the main toolbox icon is not working
properly.

The other bug is that sometimes selecting a different thing in the drop-down
does not update the main icon. For some reason, sometimes that event does not
get called. This part of the bug exists at least as far back as 
the 6.0.1.1 release, and affects both Windows and Linux(Gnome).

Perhaps Telesto can see if the second part can be bisected further?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

Telesto  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||noelgran...@gmail.com

--- Comment #3 from Telesto  ---
Adding CC to Noel Grandin

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

--- Comment #2 from Telesto  ---
Created attachment 141091
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141091=edit
Bibisect log

Bisected to

author  Noel Grandin  2018-02-16 13:32:47
+0200
committer   Noel Grandin  2018-02-16
19:51:05 +0100
commit  fe96d07621f75e6e5a106407c8ef80ace1b7f137 (patch)
tree2c282c165e93ad7fe259e63dda4d249882bbc90e
parent  bddd6c77811e0489a5632437116f5eec356cc397 (diff)
move CellBorderUpdater bitmap update to VirtualDevice
part of the process of making Bitmap an internal detail of vcl/

and remove last outside-of-vcl use of BitmapWriteAccess from
header file.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=fe96d07621f75e6e5a106407c8ef80ace1b7f137

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116799] UI: Border selection icon tool in sidebar disappearing ( white square)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116799

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
On Windows 10 Ent 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 83204c1fbf2cb85f3a22a922411ed8291cfb3fe8
CPU threads: 8; OS: Windows 10.0; UI render: default; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-29_01:08:27
Locale: en-US (en_US); Calc: group

The representation of the borders does show, but not for all border
assignments.

Seems mostly correct in building the icon.

The No Border representation is what shows as the white icon.

The right, left, top, bottom and all borders shows when refreshed (i.e. select
No Border, and then the border format as applied to the selection). 

Seems the double and heavy borders are not symbolized in the icon preview.
Also, neither the Diagonal Up nor Diagonal Down border has any symbolism in the
border(s) icon.

Needs a bit more work...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs