[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #10 from Justin L  ---
(In reply to Justin L from comment #8)
> I couldn't figure out where the reference
> in grouped-compact was used, so I left it.
In the end, I removed that too. In Impress, it is in the "Slide" menu, but the
corresponding "Page" menu is missing in Draw.

I will let others determine whether this fixes the bug report, or whether there
is more that still needs to be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #9 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/78ec4f4cbd5b7cc5b7eeb465fe7950fc72ce2847

tdf#116815 Draw UI: remove presentation-only stuff

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #8 from Justin L  ---
Proposed patch http://gerrit.libreoffice.org/c/core/+/107002
These items are not saved or imported into Draw,
so remove them from the UI interface.
They are just inherited from Impress.

Specifically:
-Display Master Background
-Display Master Objects
-Master Elements

This patch removes these 3 elements in Draw from:
-sidebar page properties
-main traditional Page menu
-Tabbed Notebook bar's layout tab,
and the tab's Layout menu,
and when viewing master - context tab
-Compact Notebook bar's layout tab,
and the tab's Layout menu,
and when viewing master - context tab
-Single Notebook bar's master context view

I couldn't figure out where the reference
in grouped-compact was used, so I left it.
(In Impress it is in a slide menu, but there
 is no corresponding Page menu in Draw
 - probably a bug.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Justin L  changed:

   What|Removed |Added

 CC||mwtjunkm...@gmail.com

--- Comment #7 from Justin L  ---
*** Bug 136843 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||6843

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #6 from Regina Henschel  ---
The "Master Elements" still exist in Draw.
Tested in Version: 6.4.0.0.alpha1+ (x64)
Build ID: 7c6226bee72805db7f0e567ca9f06c786a7d0da2
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #5 from QA Administrators  ---
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
   Keywords|needsUXEval |

--- Comment #4 from Heiko Tietze  ---
No further input, so let's kill the master. Perhaps in two steps, first by
removing access and if no user complains the actual code.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Heiko Tietze  changed:

   What|Removed |Added

 CC|tietze.he...@gmail.com  |

--- Comment #3 from Heiko Tietze  ---
+1 to remove the Impress stuff from Draw. This is a potential regression for a
few users, however.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

--- Comment #2 from Thomas Lendo  ---
Created attachment 141206
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141206=edit
Bug 2: page field not visible until reopening file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116815] Remove "Master Elements" from Draw

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116815

Thomas Lendo  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||c...@nouenoff.nl,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||thomas.le...@gmail.com,
   ||tietze.he...@gmail.com
   Hardware|x86-64 (AMD64)  |All
 Blocks||85811, 108198
 Ever confirmed|0   |1
 OS|Windows (All)   |All

--- Comment #1 from Thomas Lendo  ---
I talked to Regina face to face to understand this bug report. :) There are
several bugs within this report which can be resolved with a single solution.

I could do the steps that Regina mentioned in 6.1, 6.0 and 5.4.
Note: Command 'Master Elements...' is available in 6.1.0.0.alpha0+ via Page
menu, but due to Draw menu changes for 6.1 it isn't there in older versions
(tested 6.0, 5.4, 5.1). It's available via Customize dialog in section "Modify"
but that only works in 6.0 and 5.4. I couldn't see the manually inserted
command in 5.1.

Bug 1:
'Master Elements...' is simulating the 'Insert Header/Footer' item of Impress.
I don't know if this is necessary for Draw anyway. As this isn't intended by
the ODF specification as Regina said, 'Master Elements...' is either a
suboptimal naming or completely false regarding ODF specification and should be
removed from Draw.

Bug 2:
After inserting all 3 master elements and giving them a border color or area
color to emphasize them visually, go to the normal view and you see that the
page number field/frame isn't visible. (I'll attach a screenshot.)
It's only visible after saving and reopening the file.

Bug 3:
After that all and going back to the 'Master Elements...' dialog, the
checkboxes aren't activated anymore although they exist in the opened file.


Proposed solution:
Get rid of the complete dialog from the UI and from the code to get conform
with the ODF spec.
Page number can be inserted over menu Insert > Field > Page number. Maybe this
needs a more prominent place in the menu or toolbar.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=85811
[Bug 85811] [META] Main menu bar bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108198
[Bug 108198] [META] ODF export is unsuitable or invalid XML
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs