[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2020-10-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Alex Thurgood  changed:

   What|Removed |Added

 CC||avshara...@list.ru

--- Comment #21 from Alex Thurgood  ---
*** Bug 137365 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2019-02-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Tamas Bunth  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2019-01-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Robert Großkopf  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||2815

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-10-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||0691

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-06-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #20 from Drew Jensen  ---
Also, neither the attached budget.odb file nor the file on my local disc
trigger the 30 character error message any longer. However, they do seem to
have a common denominator, they both have table with more than 1 space in the
name. But that is a different (currently closed) issue ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-06-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #19 from Drew Jensen  ---
I'd agree. Just close this as fixed. 

I think an issues for the UI parts (table vs column vs view) is appropriate,
even if minor, and I'll go ahead and do that.

I think is would be worth while to open a RFE for a simple automatic name
change, the added task of sweeping through sql statements to replace the old
name for new name is IMO a reasonably straight forward coding task. 

An RFE because it would be a 'like' over a 'must have' type of feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-06-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Xisco Faulí  changed:

   What|Removed |Added

   Severity|critical|normal
   Priority|highest |medium

--- Comment #18 from Xisco Faulí  ---
Lowering severity as the error reporting in the original report has been
fixed...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-06-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #17 from Xisco Faulí  ---
(In reply to Drew Jensen from comment #16)
> However regarding new issues from this one.
> 
> Right now there are a couple of things going on here.
> 
> 1 - False positives for this 30 character limit are happening. Two test
> files which as far as I can tell have no identifiers over 30 characters
> (Table, Column, View, Relation, Trigger, Domain, Generator or Sequence, or
> Stored Procedure) yet trigger this error message anyhow, the first file
> attached to this issue is one and a different one on my disc.
> 
> 2 - Another issue was recently resolved about the migration assistant
> continuing after an error. For this 30 character limit error (and it seems
> only this one) the migration assistant still bails at that point.
> 
> 3 - The error message doesn't correctly state which type of identifier
> triggered it.
> 
> There has not been new issues opened for those.

Hello Drew,
Could you please create a new report for each point you mentioned?

@Alex, OTOH, since the original problem is no longer happening, should it be
closed as RESOLVED FIXED ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #16 from Drew Jensen  ---
However regarding new issues from this one.

Right now there are a couple of things going on here.

1 - False positives for this 30 character limit are happening. Two test files
which as far as I can tell have no identifiers over 30 characters (Table,
Column, View, Relation, Trigger, Domain, Generator or Sequence, or Stored
Procedure) yet trigger this error message anyhow, the first file attached to
this issue is one and a different one on my disc.

2 - Another issue was recently resolved about the migration assistant
continuing after an error. For this 30 character limit error (and it seems only
this one) the migration assistant still bails at that point.

3 - The error message doesn't correctly state which type of identifier
triggered it.

There has not been new issues opened for those.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #15 from Drew Jensen  ---
(In reply to Xisco Faulí from comment #14)
> > Bad News:
> > Using the test file from earlier (budget.odg) with Ubuntu (18.04) and  this
> > build:
> > Version: 6.1.0.0.alpha1+
> > Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843
> > CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
> > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
> > 2018-05-17_00:32:17
> > Locale: en-US (en_US.UTF-8); Calc: group
> > 
> > Libo goes into a race condition and must be forced to shut down.
> 
> Could you please report it in a new bug ?

Done, patched and closed already. Welcome back from vacation btw.

https://bugs.documentfoundation.org/show_bug.cgi?id=117670

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #14 from Xisco Faulí  ---
> Bad News:
> Using the test file from earlier (budget.odg) with Ubuntu (18.04) and  this
> build:
> Version: 6.1.0.0.alpha1+
> Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843
> CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
> TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
> 2018-05-17_00:32:17
> Locale: en-US (en_US.UTF-8); Calc: group
> 
> Libo goes into a race condition and must be forced to shut down.

Could you please report it in a new bug ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #13 from Drew Jensen  ---
Good news bad news:
good news, using this mornings build and testing with the file I attached today
this function works, the migration is halted. Picky little point the failure is
due to a column name but the error message reports it as a long table name.

Bad News:
Using the test file from earlier (budget.odg) with Ubuntu (18.04) and  this
build:
Version: 6.1.0.0.alpha1+
Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-05-17_00:32:17
Locale: en-US (en_US.UTF-8); Calc: group

Libo goes into a race condition and must be forced to shut down.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #12 from Drew Jensen  ---
Created attachment 142161
  --> https://bugs.documentfoundation.org/attachment.cgi?id=142161&action=edit
Test File

Single table test file with a column name longer than 30 characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-05-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #10 from Commit Notification 
 ---
Tamas Bunth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1825b219a22be8b6cf0ca54bf0ee6c64f55dc6d

tdf#116987 dbahsql: check for table names..

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #9 from Drew Jensen  ---
One note, querys or more acuratly queryDefinition names are not affected by the
fb naming limits. Tables, Views, Triggers, Domains and Procedure names are.

In the current import function (drag drop of a table) a long table name is
simply truncated at 30 characters.

As for a fully automated migration, after the name change the routine would
need to check for other items using that identifier (querydefs, views, forms,
reports and macros).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #8 from Alex Thurgood  ---
(In reply to Tamas Bunth from comment #7)
> A workaround would be to truncate table names with more than 30 characters.
> 


Not really a very satisfactory one though from a user perspective. The whole
point of being able to uniquely identify a table in hsqldb with a "long" file
name has clearly been used by DBAs and users alike. 

On the one hand, imposing a new form of table naming as you suggest isn't going
to go down well with those users unless there is a valid reason, which there
doesn't seem to be given that in FB4 that limitation will be lifted (but of
course when that might happen is a different matter).

On the other hand, one could submit that having table names in excess of 30
characters really isn't the way one should be managing a DB in the first place,
but that is a debate for another day.

Would it not be better to simply abort with a more meaningful message than is
currently offered, something along the lines of :

"Firebird 3 doesn't currently support table/query/view names of more than 30
characters, please shorten your table names in the original file and try
again."

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #7 from Tamas Bunth  ---
A workaround would be to truncate table names with more than 30 characters.

If there are tables with the same name after the truncation, then put an
increasing number at the end. (e.g. truncate to 29 characters and the 30th
character would be a number to distinguish tables with the same name)

If there is more than 10 tables with the same name, then throw exception /
migration fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|regression  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Xisco Faulí  changed:

   What|Removed |Added

 OS|Mac OS X (All)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
 Blocks||116968
 Ever confirmed|0   |1

--- Comment #6 from Xisco Faulí  ---
Regression introduced by:

author  Tamas Bunth2018-03-25 13:26:57
+0200
committer   Tamás Bunth  2018-04-07 17:08:26 +0200
commit  159dd28651788a19848eae56693ad06ed947414d (patch)
treeb69013db1c0fa45677b59d58999ce0d8ebebd76c
parent  1a9bfdd8976d28fa3a56726bdcae9f2b294d6c6d (diff)
dbaccess: Enable hsql migration by default
Also make Firebird driver not experimental anymore.

Bisected with: bibisect-linux64-6.1

Adding Cc: to Tamas Bunth


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116968
[Bug 116968] [META] Migrating existing embedded HSQLDB databases to Firebird
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #5 from Alex Thurgood  ---
Hmm, even if I rename all of the entries to less than 30 characters in LO6032,
save under a different name, and re-import to master, I still get the same
error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

--- Comment #4 from Alex Thurgood  ---
In the sample file, none of the tables have names or columns with more than 30
characters.

The queries and reports have names with more than 30 characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 116987] FIREBIRD : Migration : error on importing tables or queries with names longer than 30 characters

2018-04-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116987

Alex Thurgood  changed:

   What|Removed |Added

Summary|FIREBIRD : Migration :  |FIREBIRD : Migration :
   |error on importing tables   |error on importing tables
   |with long table names   |or queries with names
   ||longer than 30 characters

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs