[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #10 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #9 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #8 from QA Administrators  ---
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998
Bug 116998 depends on bug 117228, which changed state.

Bug 117228 Summary: EDITING: crash in SfxItemSet::GetItemState(unsigned short, 
bool, SfxPoolItem const**) when pasting comment of closed document
https://bugs.documentfoundation.org/show_bug.cgi?id=117228

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

Eike Rathke  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 Depends on||117228
   Assignee|er...@redhat.com|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #7 from Eike Rathke  ---
So it's one of the Undo docs that holds the comment after Cut and gets
destroyed when pasting thus the captions are rightly forgotten there. Can't fix
for released versions. In master/6.1 it works by accident because of the cause
of bug 117228 (captions never forgotten), which needs to be fixed first before
this could be tackled. Handing back to pool for now.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117228
[Bug 117228] EDITING: crash in SfxItemSet::GetItemState(unsigned short, bool,
SfxPoolItem const**) when pasting comment of closed document
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #6 from Eike Rathke  ---
darn..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #5 from Eike Rathke  ---
Which makes sense because that change threw the note content away if the
clipboard source document was closed to prevent a crash. Later changes preserve
the content but the drawing layer caption can't be preserved so has to be
regenerated (with a different size). I'm still baffled though that the code
would be executed in this scenario here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #4 from Buovjaga  ---
(In reply to Eike Rathke from comment #3)
> I somewhat doubt that bisecting result as that code is only executed when
> closing a document that was the source of the clipboard (detection more
> stringent and behaviour slightly modified since then, see also bug 104967).
> Also, that commit went into 5.2.6 as well, so is it reproducible there but
> not in 5.2.5?

Indeed, the problem is seen in 5.2.6, but not in 5.2.5.
To be exact, in 5.2.6 (as in some commits in my bisect), it manifests in the
second pasted instance showing no content at all (while also having less
height).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

--- Comment #3 from Eike Rathke  ---
I somewhat doubt that bisecting result as that code is only executed when
closing a document that was the source of the clipboard (detection more
stringent and behaviour slightly modified since then, see also bug 104967).
Also, that commit went into 5.2.6 as well, so is it reproducible there but not
in 5.2.5?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

Buovjaga  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
Version|6.1.0.0.alpha0+ Master  |5.3.0.3 release
   Keywords||bisected, regression
 CC||er...@redhat.com,
   ||todven...@suomi24.fi
 Blocks||101216
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #2 from Buovjaga  ---
Repro.

Bisected to
https://cgit.freedesktop.org/libreoffice/core/commit/?id=cb566c056b0e8f9f73dac3cbaf497e102a247cb9

commit  cb566c056b0e8f9f73dac3cbaf497e102a247cb9 (patch)
tree93ba07dd11cab7ef22778971959de3bc7694ee1d
parent  2fb220093f7178f75ebd582bbcd956c1ee7e03db (diff)
tdf#104967 prevent crash when pasting notes originating from a closed document
This is only a workaround to prevent a crash, the actual note content is lost
when pasting, only a standard empty note caption will be pasted.

Change-Id: Ifaef5d30cc2024f3d03d6b2b4f56c5ccfbb67142

Adding Eike to CC.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
[Bug 101216] [META] Calc comment bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116998] The comment box is smaller when pasting the same comment twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116998

Jacques Guilleron  changed:

   What|Removed |Added

 CC||guillero...@aol.com

--- Comment #1 from Jacques Guilleron  ---
Hi Telesto,

I worked this way until
LO  5.3.0.2 Build ID: 5ad7b2889021c491af62f7930a4b1cb631392f16
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; Moteur
de mise en page : nouveau; 
Locale : fr-FR (fr_FR); Calc: single
This is a Text fonctionnality, set to Fit height to text, but not applied to
the first copy.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs