[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

--- Comment #13 from Maxim Monastirsky  ---
I believe the current behavior is reasonable, and at least not worse than what
was before. Would be great to get some feedback about current master (for this
bug and Bug 113894) before considering a backport.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #12 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=632bc11ce8fab1c4046ab24810b90a7ce9ac5914

tdf#117017 Pasting into the formula bar shouldn't retain formatting

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #11 from Maxim Monastirsky  ---
(In reply to Eike Rathke from comment #10)
Maybe we can paste as unformatted text when the focus is in the formula bar (so
users could still override this with the paste special dialog or the toolbar
button), i.e. something like this:

diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index e3e6ec2f35de..75ddf11ece37 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -1468,7 +1468,8 @@ void ScTextWnd::StartDrag( sal_Int8 /* nAction */, const
Point& rPosPixel )
 void ScTextWnd::KeyInput(const KeyEvent& rKEvt)
 {
 bInputMode = true;
-if (!SC_MOD()->InputKeyEvent( rKEvt ))
+if (rKEvt.GetKeyCode().GetFunction() == KeyFuncType::PASTE ||
+!SC_MOD()->InputKeyEvent( rKEvt ))
 {
 bool bUsed = false;
 ScTabViewShell* pViewSh = ScTabViewShell::GetActiveViewShell();
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx
index 804401b303f4..5c8d00bff7b3 100644
--- a/sc/source/ui/view/editsh.cxx
+++ b/sc/source/ui/view/editsh.cxx
@@ -217,7 +217,11 @@ void ScEditShell::Execute( SfxRequest& rReq )
 break;

 case SID_PASTE:
-pTableView->PasteSpecial();
+if (pTopView && pTopView->GetWindow()->HasFocus())
+pTableView->Paste();
+else
+pTableView->PasteSpecial();
+
 if (pTopView)
 pTopView->Paste();
 break;

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #10 from Eike Rathke  ---
Ugh.. I think bug 113894 is right, pasting arbitrarily formatted text into the
Input Line should not retain the formatting (different to pasting into the
cell). However, it shouldn't depend on (release of) modifier keys. No quick
idea right now though how that should be correctly handled in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

Maxim Monastirsky  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||3894

--- Comment #9 from Maxim Monastirsky  ---
Now I noticed that the format resetting via modifier keys was done on purpose
for Bug 113894, but I don't understand that report:

1. By default a copy-paste procedure preserves formatting. Why there should be
a difference if pasting while the focus is inside the formula bar?

2. Even if pasting into the formula bar really should strip formatting like Bug
113894 wants, it's odd that it's implemented via pressing of a modifier key.

3. As it was after the fix of Bug 113894, users were getting different results
when pasting via toolbar/menu, or if assigned a different keyboard shortcut for
the paste command.

4. AFAICS resetting of the format is a relatively new behavior, as old LO
releases didn't have it.

So I still think that modifier keys should not change formatting, and Bug
113894 should be instead closed as WONTFIX.

@Eike: What's your take on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #8 from Xisco Faulí  ---
Cherry-picked to 6.0: https://gerrit.libreoffice.org/#/c/53144/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||6329

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #7 from Maxim Monastirsky  ---
(In reply to Eike Rathke from comment #6)
> @Maxim:
> May it be that bug 116329 has the same cause?
It appears so. The hyperlink breaks after pressing the modifier key, and it
doesn't happen if using the toolbar button or menu to copy the hyperlink. And
the patch seems to fix it as well.

There is also somewhat similar Bug 70597 which is about destroying the
hyperlink with a right click. I suspect it can be fixed in a similar way, this
time for CommandEventId::ContextMenu (but had no chance to try it yet).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #6 from Eike Rathke  ---
@Maxim:
May it be that bug 116329 has the same cause?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

--- Comment #5 from Commit Notification 
 ---
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a860c94f0da22065074cc36e8ddda73261641533

tdf#117017 Make modifier keys not trigger the InputChanged handler

It will be available in 6.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #4 from Maxim Monastirsky  ---
The revert of formatting is caused by the releasing of the modifier key (Ctrl).
The same effect can be reproduced also if applying the formatting using the
menu, and then pressing Ctrl. I hope that simply ignoring all modifier key
changes here is OK (didn't notice any problems so far):

https://gerrit.libreoffice.org/52924/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

V Stuart Foote  changed:

   What|Removed |Added

 CC||er...@redhat.com
 OS|Linux (All) |All

--- Comment #3 from V Stuart Foote  ---
(In reply to Jean-Baptiste Faure from comment #1)
> It works if you select the text part in the cell instead of in the formula
> bar.

Yes, it does work with a selection made from the cell. And, likely how most
folks would be applying the formatting.  

But the formatting does apply to a selection made in the Formula Bar when the
.uno command are applied from the menu or the sidebar panel--just not when done
with the keyboard. Which momentarily toggles the format, but releases it. 

To me that seems some mishandling of the keyboard shortcut and .uno when focus
and text selection is in the Formula Bar.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117017] Text formatting .uno:Subscript, .uno: Superscript work from menu and Sidebar deck, but not completed with assigned keyboard shortcut

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117017

V Stuart Foote  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 CC||vstuart.fo...@utsa.edu
 Resolution|NOTABUG |---
Summary|Subscripting of text part   |Text formatting
   |works through menu but not  |.uno:Subscript,
   |keyboard shortcut   |.uno:Superscript work from
   ||menu and Sidebar deck, but
   ||not completed with assigned
   ||keyboard shortcut
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote  ---
Confirmed on Windows 10 Home 64-bit en-US with
Version: 6.1.0.0.alpha0+ (x64)
Build ID: 55e84652ae84bd2374462ee19afd359a8cc90b95
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-04-13_05:08:28
Locale: en-US (en_US); Calc: CL

Seems to be an issue with keypress--the Subscripted, or Superscripted, keyboard
accelerators are linked to the .uno:Subscript, or .uno:Superscript, and will
apply the format to the selected text while the B, or P, is held keydown. But
on release the formating reverts.

>From Format -> Text menu or the Sidebar Properties deck, the menu item or
button press applies the formatting and it is retained.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs