[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||445

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #23 from Timur  ---
I see 2 messages, so not clear if resolved since there used to be 1 up to 4.2,
and who will comment on comment 18 and API.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #22 from Timur  ---
Xisco, please retest since you tested before.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #21 from Mike Kaganski  ---
I guess so :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #20 from Justin L  ---
Mike: should this bug be marked as fixed now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #19 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/7f34ac5201ffec31bd336cf9fb1f8d2554bc6f72

tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListener

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #18 from Mike Kaganski  ---
FTR: The solution implemented in the abovementioned commits is to pass
com.sun.star.view.PrintableState [1] value in the
com.sun.star.document.DocumentEvent struct's Supplement, passed as event
handler's argument. So the event handler could look like this:


> Sub OnPrintHandler(e)
>   If (e.Supplement = com.sun.star.view.PrintableState.JOB_STARTED) Then
> MsgBox("JOB_STARTED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_COMPLETED) Then
> MsgBox("JOB_COMPLETED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_SPOOLED) Then
> MsgBox("JOB_SPOOLED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_ABORTED) Then
> MsgBox("JOB_ABORTED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_FAILED) Then
> MsgBox("JOB_FAILED")
>   ElseIf (e.Supplement = 
> com.sun.star.view.PrintableState.JOB_SPOOLING_FAILED) Then
> MsgBox("JOB_SPOOLING_FAILED")
>   Else
> MsgBox(e.Supplement)
  EndIf
End Sub

Julien has removed one likely unnecessary notification, so the event is
generated twice instead of three times, as was noticed in comment 3. The two
other invocations are legitimate, and typically reflect JOB_STARTED then
JOB_SPOOLED, or JOB_STARTED then JOB_ABORTED. The handler should handle the
kind of event that it needs, based on the PrintableState, as shown above.

Interesting, if this is an API change. Also, it likely needs documentation.
Also, it might be possible in the future to re-consider what is put into
Supplement field, so user code should be prepared that Supplement may be empty
(as prior to the change), or numeric (as now), or maybe something else (a
struct?).

[1]
https://api.libreoffice.org/docs/idl/ref/namespacecom_1_1sun_1_1star_1_1view.html#ad9b0afaffefc166344fd9575516b6626

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #17 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/28eef82cb16faef0b8ddc9912560efb779baa9f9

tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListener

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #16 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/20f56c937c44a9cbe3c05fa7c510feaf9d2341df

tdf#117280: fix multiple Macro execution when triggered by Document print event

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0
   ||target:7.3.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #15 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/774c6a6e1603bf3f12f1573b0778e0f0f9783169

tdf#117280: fix multiple Macro execution when triggered by Document print event

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Julien Nabet  changed:

   What|Removed |Added

   Assignee|serval2...@yahoo.fr |libreoffice-b...@lists.free
   ||desktop.org
 CC|serval2...@yahoo.fr |
 Status|ASSIGNED|NEW

--- Comment #14 from Julien Nabet  ---
My patch was wrong and I don't understand all the stuff with supplement and
context => unassign myself and from this bugtracker.

Sorry for the noise Mike (don't hesitate to uncc of course).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #13 from Julien Nabet  ---
Thank you Mike for your feedback!
I gave a try with https://gerrit.libreoffice.org/c/core/+/126018 as you may
have seen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #12 from Mike Kaganski  ---
I suppose that we just need to supply a proper data to the Supplement member of
com.sun.star.document.DocumentEvent struct getting passed as an argument to the
event handler. It could be a string, or an integer constant, so that the
handler could differentiate the events.

(In reply to Julien Nabet from comment #11)
> The pb is we got several printable states:
> - JOB_STARTED
> - JOB_COMPLETED
> etc.
> and only 1 event onPrint

The approach above allows to address that. com.sun.star.view.PrintableState
enum looks a natural choice here... unless we want something more powerful.

I assume that we actually want two events (before and after) out of three, and
the first one maybe can go. But the two calls in
SfxPrinterController::jobStarted appear before and after calling
getJobProperties - maybe that has a value, and we only need to clarify what
options are available for developer at each call (and then we definitely need
something else than com.sun.star.view.PrintableState there, since there's no
values to disambiguate the two; and actually, I don't know what user can really
do with the getJobProperties, so the above is just a guess). Also the two
methods not only call Basic methods, but do other work - I would expect
problems simply removing the calls from here - we'd need to provide a way for
passing the information "do not call events" there, e.g. setting a
SfxApplication flag, or pushing a context (see
).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Julien Nabet  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #11 from Julien Nabet  ---
(In reply to Julien Nabet from comment #10)
> I retrieved 3 bts (1 per message displayed).
> ...

The 2 last ones are due to the already quoted commits.
In include/sfx2/event.hxx

The 2 ctrs of SfxPrintingHint call SfxViewEventHint with second arg
"GlobalEventConfig::GetEventName( GlobalEventId::PRINTDOC )"
See
https://opengrok.libreoffice.org/xref/core/include/sfx2/event.hxx?r=503e0173#239.

The pb is we got several printable states:
- JOB_STARTED
- JOB_COMPLETED
etc.
and only 1 event onPrint
see
https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/view/PrintableState.idl?r=2b383d19#31

At which moment should we trigger the event when job began, when it finished?

Also, I don't know event mechanism to distinguish what
SfxGetpApp()->NotifyEvent compared to mpObjectShell->Broadcast
Perhaps the initial call "SfxGetpApp()->NotifyEvent..." could be removed?

Mike: any opinion here or any idea whom may help here?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #10 from Julien Nabet  ---
I retrieved 3 bts (1 per message displayed).
All of them come from sfx2/source/view/viewprn.cxx

The first 2 ones are in SfxPrinterController::jobStarted()
1)
316 SfxGetpApp()->NotifyEvent( SfxEventHint(SfxEventHintId::PrintDoc,
GlobalEventConfig::GetEventName( GlobalEventId::PRINTDOC ), mpObjectShell ) );

2)
324 mpObjectShell->Broadcast( SfxPrintingHint(
325 view::PrintableState_JOB_STARTED, aOpts, mpObjectShell, xController
) );

the last one is in SfxPrinterController::jobFinished
334 mpObjectShell->Broadcast( SfxPrintingHint( nState ) );

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #9 from Justin L  ---
repro 7.3+ with three message boxes.
I expect that the macro hook should be watching a different event, but I know
nothing at all about that code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #8 from QA Administrators  ---
Dear Thierry Jeanneret,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Blocks||107659


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107659
[Bug 107659] [META] Macro bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #7 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I confirm I got 3 times
the message.
I didn't try with reverting locally my commit because since the file changed is
in "include/sfx2", it takes some time to just build.
Again, feel free to revert the patch if you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #6 from Julien Nabet  ---
I won’t be able to give it a try before about a week, so feel free to revert my
patch if you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||serval2...@yahoo.fr
Version|5.4.6.2 release |4.2 all versions

--- Comment #5 from Xisco Faulí  ---
The dialog being displayed 2 times started after

author  Ariel Constenla-Haile   2013-02-24 18:23:21
+
committer   Caolán McNamara 2013-06-19 15:46:54
+0100
commit  87dfa6dd336d596112c0beb6b42f082178461678 (patch)
treeb3bde0c7c200ac231a522e496213ad38e65337e5
parent  bf4ecd6138f07ca6207eeec306517eff4aff220e (diff)
Resolves: #i121810# Adapt SfxPrintingHint to work with...
the "new" XDocumentEventBroadcaster

(cherry picked from commit 1bfae56dd9d633a80924bfeefc03368100d75a8f)

Conflicts:
sfx2/inc/sfx2/event.hxx
sfx2/source/view/viewprn.cxx

Bisected with bibisect-42max

and the problem with the dialog being displayed 3 times started after

author  Julien Nabet   2018-01-30 21:34:52 +0100
committer   Noel Grandin  2018-02-01
15:47:22 +0100
commit  4b2476b5ac464d876cb1be4d3e02e30c329607cc (patch)
tree157ed4bb5beed33129560a5e5b4d11194bb6ac36
parent  ae8b65eea784e4f718e3170577b670fe1e6a3700 (diff)
Avoid empty avoid name for SfxPrintingHint
Create a brand new doc on Writer, click Print then Cancel button
=>
warn:legacy.tools:2382:2382:sfx2/source/doc/sfxbasemodel.cxx:3071: Empty event
name!

Bisected with: bibisect-linux64-6.1

Adding Cc: to Julien Nabet

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Xisco Faulí  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
 OS|Mac OS X (All)  |All

--- Comment #4 from Xisco Faulí  ---
Reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 4.13; Render: default;

and

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #3 from Xisco Faulí  ---
Actually, the dialog is displayed 3 times in

Version: 6.1.0.0.alpha1+
Build ID: 653e58f9eb3d4ee61d8103993cdff2660c9127a5
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

2 times in

Version: 6.0.3.2
Build ID: 1:6.0.3~rc2-0ubuntu0.16.04.1~lo2
CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Thierry Jeanneret  changed:

   What|Removed |Added

 CC||thierry.jeanne...@gmail.com

--- Comment #2 from Thierry Jeanneret  ---
Created attachment 141697
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141697=edit
Document containing a demo macro hooked to the print event

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs