[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Bartosz  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |gan...@poczta.onet.pl
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

--- Comment #8 from Armin Le Grand (CIB)  ---
No idea what to do when it's only on the Mac- I do not have one. The code
changed as follows:

-const BitmapColor& rColor = mrPalette[ (pData[mnX >> 3 ] >> ( 7 -
( mnX & 7 ) )) & 1];
+// Caution(!) rPalette.GetEntryCount() may be != (depth^^2)-1 (!)
+const sal_uInt8 nIndex( (pData[mnX >> 3 ] >> ( 7 - ( mnX & 7 ) ))
& 1);

Checking the index acces *is* needed (there are palettes with less than 0xff
colors - I thought about fixing this first). Maybe a Mac-Dev could tr to use
sal_uInt16 instead of sal_uInt8 - something strange with the Mac-Compiler seems
to be happening here (due to working on all other systems...).
Sprry, I have (still) no Mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

--- Comment #7 from Andrew Watson  ---
Reproduced in:

Version: 6.1.0.0.beta1
Build ID: 8c76dfe1284e211954c30f219b3a38dcdd82f8a0
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
GetEntryCount returns maBitmapColor
197  sal_uInt16 GetEntryCount() const
198  {
199  return maBitmapColor.size();
200  }

see https://opengrok.libreoffice.org/xref/core/include/vcl/salbtype.hxx#197

but I noticed that maBitmapColor is initialized with a sal_uInt16 number, see
https://opengrok.libreoffice.org/xref/core/include/vcl/salbtype.hxx#maBitmapColor#177

Shouldn't we use sal_uInt16 for mnPaletteCount?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||111486


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111486
[Bug 111486] [META] Regressions from EMF+ reworking
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Xisco Faulí  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||armin.le.gr...@me.com

--- Comment #5 from Xisco Faulí  ---
Regression introduced by:

author  Armin Le Grand   2017-10-30 16:29:09 +0100
committer   Armin Le Grand   2018-04-17 02:05:57
+0200
commit  7f9b0f47979dcb7abfed37bb7cd38ab51eac6011 (patch)
tree639b6289605dc4b108b70d2da56dd214e62a5be1
parent  0f93692fda4226323422cf82ce34ae4bd5e22fab (diff)
tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if needed
Added code to quartz vcl implementation that takes care
when BitmapPalette.count != (depth^^2)-1 - which may
be the case anytime. If then a bitmap value exists that
goes beyond that count, a invalid access was executed

Bisected with: bibisect-mac64-6.1

Adding Cc: to Armin Le Grand

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|UNCONFIRMED |NEW
 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1

--- Comment #4 from Xisco Faulí  ---
Reproduced in

Version: 6.1.0.0.alpha1+
Build ID: 13a1bc409d9b2f0d14f4d316b7977b1fc2eb3c8a
CPU threads: 8; OS: Mac OS X 10.13.3; UI render: default; 
Locale: en-US (en_ES.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

--- Comment #3 from Andrew Watson  ---
Yes, it looks as if this may be a Mac-only bug.

I tried a different Mac running an older version of Mac OS (10.9.5). The GIFs
also do NOT display with LO 6.1.0.0.alpha1 on:

Version: 6.1.0.0.alpha1
Build ID: cb47f0d320994e001bc38dc2ee9b7d957b15e6ab
CPU threads: 4; OS: Mac OS X 10.9.5; UI render: default; 
Locale: en-US (en.UTF-8); Calc: group

But DO display on the same Mac with an older LO version:

Version: 5.3.0.3
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU Threads: 4; OS Version: Mac OS X 10.9.5; UI Render: default; Layout Engine:
new; 
Locale: en-GB (en.UTF-8); Calc: group

I also tried Linux Mint 18 (Sarah), and found that the GIFs DO display with LO 
6.1.0.0.alpha1 under:

Version: 6.1.0.0.alpha1
Build ID: cb47f0d320994e001bc38dc2ee9b7d957b15e6ab
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Locale: en-GB (en_GB.UTF-8); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
I see image in Version: 6.1.0.0.alpha1+
Build ID: 4dbce627d3643babaf90a93c70b365ff08abfca6
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: gtk2; 
Mac only?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117335] GIF images fail to display in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117335

Andrew Watson  changed:

   What|Removed |Added

 CC||notinterest...@gmx.com

--- Comment #1 from Andrew Watson  ---
Created attachment 141760
  --> https://bugs.documentfoundation.org/attachment.cgi?id=141760=edit
Test Impress file whose GIF images fail to display

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs