[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #15 from Xisco Faulí  ---
> Let it only concern the issue Tomaž fixed, thanks for that!
> Closing as FIXED.

Setting to VERIFIED!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Aron Budea  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   See Also|https://crashreport.libreof |
   |fice.org/stats/signature/Bi |
   |tmapReadAccess::SetPixelFor |
   |N24BitTcBgr(unsigned%20char |
   |%20*,long,BitmapColor%20con |
   |st%20&,ColorMask%20const%20 |
   |&)  |
Crash report or|["BitmapReadAccess::SetPixe |
crash signature|lForN24BitTcBgr(unsigned|
   |char *,long,BitmapColor |
   |const &,ColorMask const |
   |&)"]|
 Blocks|105537  |
 Status|NEW |RESOLVED

--- Comment #14 from Aron Budea  ---
This bug report mentioned different issues I encountered after following the
same steps. Let it only concern the issue Tomaž fixed, thanks for that! Closing
as FIXED.

I'm not getting an assert anymore, perhaps that's gone as well, but saving
still crashes after consuming a lot of memory, I will check how that behaves
sometimes, and open a different bug report if needed.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=105537
[Bug 105537] [META] Assertion failed crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #13 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=22dbd5904f4f69d98530fecdd9e4383dd088f76f=libreoffice-6-1

tdf#117797 guard access to mpSwapFile as it may not be set

It will be available in 6.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0|target:6.2.0 target:6.1.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #12 from Commit Notification 
 ---
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3cd264bb09c6c14bf9eb769d508d7015c4bdc83b

tdf#117797 guard access to mpSwapFile as it may not be set

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #11 from Aron Budea  ---
Adding an if guard checking if mpSwapFile isn't empty around the following
lines gets rid of the debugger break and the assertion failure:

https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/impgraph.cxx#1592
==
setOriginURL(mpSwapFile->maOriginURL);
mpSwapFile.reset();
==

However, I'm not sure if that makes the code consistent, and would rather leave
the change to Tomaz.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #10 from Aron Budea  ---
Still getting it with 565340d457f41197474a75ba1b036bdc3d569041 (from 06-03),
only with default rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #9 from Xisco Faulí  ---
Not reproduced in

Version: 6.1.0.0.beta1+
Build ID: 91d8af2c5cf4e8ec0f1ce0e532e0c896de77750b
CPU threads: 16; OS: Windows 6.3; UI render: default; 
Locale: en-GB (en_GB); Calc: group threaded

either

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #8 from Xisco Faulí  ---
Not reproduced in

Version: 6.2.0.0.alpha0+
Build ID: 48b49937fed5e50d299a94063eb325799ff672e9
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-06-05_01:47:06
Locale: es-ES (es_ES); Calc: group threaded

either

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Xisco Faulí  changed:

   What|Removed |Added

   Priority|high|medium
   Severity|major   |normal

--- Comment #7 from Xisco Faulí  ---
I can't reproduce the crash in

Version: 6.2.0.0.alpha0+
Build ID: 48b49937fed5e50d299a94063eb325799ff672e9
CPU threads: 1; OS: Windows 6.1; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-06-05_01:47:06
Locale: es-ES (es_ES); Calc: group threaded

@MM, @Aron, @Raal, @Julien, Could you please retry with a daily build?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Xisco Faulí  changed:

   What|Removed |Added

 Blocks||116280


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=116280
[Bug 116280] [META] Regressions introduced by the image handling refactoring
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #6 from Aron Budea  ---
I guess the crash report and the most recent crash are different bugs,
considering one was there in 6.0, and the other was introduce during 6.1
development.

Additionally, my observations in comment 1 again refer to a different bug, only
observable when debugging a Windows debug build with OpenGL disabled (maybe
Linux, too, haven't checked). That was introduced in the following commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=075e2d8b8d98b1c6daa430e9b9a396b15ba22837
author  Tomaž Vajngerl  2018-02-13
21:26:40 +0900
committer   Tomaž Vajngerl    2018-02-13 20:29:24
+0100

graphic: Remember the origin URL after swap out - swap in

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

--- Comment #5 from Regis Perdreau  ---
Work perfectly with 
Version: 6.1.0.0.alpha1+
Build ID: 1e2afc9bd3062cfba6b65b45c17a08f298014239
CPU threads: 4; OS: Linux 4.8; UI render: default; VCL: gtk3; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group
Linux mint 18.2 64 bits.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated yesterday + enable-dbgutil, I
killed LO after about 30 seconds because it was too slow.
I noticed these kinds of logs:
warn:legacy.tools:5207:5207:sfx2/source/control/bindings.cxx:793:
SfxBindings::Register while status-updating
warn:legacy.tools:5207:5207:sfx2/source/control/bindings.cxx:1288: Reschedule
in StateChanged => buff

warn:vcl.gdi:5207:5207:vcl/source/graphic/Manager.cxx:135: Calculated size
mismatch. Variable size is '-89853776' but calculated size is '114107674'
warn:vcl.gdi:5207:5207:vcl/source/graphic/Manager.cxx:135: Calculated size
mismatch. Variable size is '725992024' but calculated size is '409817674'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||qui...@gmail.com,
   ||r...@post.cz

--- Comment #3 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Tomaž Vajngerl; Could you possibly take a look at this one?
Thanks

 0b17b35d7aff81ec5ba3790ff3544d18e5f6ae44 is the first bad commit
commit 0b17b35d7aff81ec5ba3790ff3544d18e5f6ae44
Author: Norbert Thiebaud 
Date:   Tue May 8 17:47:24 2018 -0700

source sha:711c2e49dd3c51877263148267344e2eb4ca7c0d
author  Tomaž Vajngerl  2018-05-08 19:45:36
+0900
committer   Tomaž Vajngerl    2018-05-09 02:03:16
+0200
commit  711c2e49dd3c51877263148267344e2eb4ca7c0d (patch)
treef6b676ceb8a607922bdcff0b1d70567c03d5a26f
parent  f4e7d521aab79ecbb16c0518f14c7635902e9e10 (diff)
tdf#116272 use correct property name when exporting to PPT

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from MM  ---
Confirmed on windows 7 x64 with Version: 6.0.4.2 (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 3; OS: Windows 6.1; UI render: default

crashreport.libreoffice.org/stats/crash_details/91ef0460-5d32-472a-816a-0ed4da90d367

Unconfirmed on ubuntu 16.04 x64 with Version: 6.1.0.0.alpha1+
Build ID: 47dc3115f12ff16dc326b6edd12c46e6a6ef1843
CPU threads: 2; OS: Linux 4.4; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2018-05-17_00:32:17
Locale: en-US (en_US.UTF-8); Calc:

Seems windows only then.
Also the white rectangle isn't there in the linux build.
But saving seems a lot slower than with v6.0.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 117797] Crash / assert when resaving a specific PPT

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117797

Aron Budea  changed:

   What|Removed |Added

 CC||vmik...@collabora.co.uk

--- Comment #1 from Aron Budea  ---
Interestingly the debugger breaks elsewhere:

setOriginURL(mpSwapFile->maOriginURL);
https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/impgraph.cxx#1579

Here mpSwapFile->maOriginURL is ??? (undefined I assume), even though it was
empty until the bRet = ImplSwapIn( xIStm.get() ) call a bit above.

Actually, ImplSwapIn( SvStream* xIStm ) calls ImplClear(), which does this:
mpSwapFile.reset();

So if the swap file is thrown away, why is its maOriginURL taken later?

Miklos, can you please take a look at what's supposed to be going on there?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs