[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1986 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Rohit kumar changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=14 | |1986| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Mike Kaganski changed: What|Removed |Added CC||kbw9xf...@relay.firefox.com --- Comment #115 from Mike Kaganski --- *** Bug 155653 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Bug 118320 depends on bug 148085, which changed state. Bug 148085 Summary: About dialog hyperlinks look bad (invisible / have no contrast) in dark mode on Windows https://bugs.documentfoundation.org/show_bug.cgi?id=148085 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Stéphane Guillou (stragu) changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=11 | |8017| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||2994 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Timur changed: What|Removed |Added Depends on|148376 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148376 [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Bug 118320 depends on bug 148376, which changed state. Bug 148376 Summary: Insert Table toolbar: text with table size does not respect dark mode https://bugs.documentfoundation.org/show_bug.cgi?id=148376 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Blocks|103184, 103303 |150915 --- Comment #114 from Timur --- I'm adding Windows Dark Mode meta as bug 150915. I kindly ask reporters of duplicate bugs to verify that their requests were resolved, if not please set bug from duplicate to Unconfirmed and to block bug 150915. Stuart, you are welcome to write a wrarp up there. I think it's safe to close this one now with huge thanks to Caolán. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103184 [Bug 103184] [META] UI theming bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=103303 [Bug 103303] [META] Desktop integration bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=150915 [Bug 150915] [META] Windows Dark Mode bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 V Stuart Foote changed: What|Removed |Added CC||xordevore...@gmail.com --- Comment #113 from V Stuart Foote --- *** Bug 150521 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #112 from Pedro --- Thank you for clarifying this for me Mike. :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #111 from Pedro --- Created attachment 181883 --> https://bugs.documentfoundation.org/attachment.cgi?id=181883=edit In windows 11 color highlight is too light and up and down buttons still not themed. Additional issues in Windows 11 that should be addressed before 7.5.0 move out of experimental. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #110 from Mike Kaganski --- (In reply to Pedro from comment #109) Moving out of experimental early enough in the release cycle is fine; it's always possible to undo that, but this way, it gets more testing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #109 from Pedro --- I would wait to remove it out of experimental because there's those multiple minor issues that were reported by me and Ryzal that should be addressed before the 7.5.0 release. Unless those are worked on before the release? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #108 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/db4c4676b70bb5f9a1c169735e8fbe92b097a57b Related: tdf#118320 don't require experimental to be set anymore It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Rafael Lima changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8675 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 V Stuart Foote changed: What|Removed |Added CC||baliczeri...@gmail.com --- Comment #107 from V Stuart Foote --- *** Bug 148898 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #106 from John Mills --- I agree with Pedro here, what is remaining for this to be moved out of experimental now? What would be expected in a 'meta' ticket? Something like selectable light/dark or follow system theme? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #105 from Pedro --- Agreed. And move it out of experimental. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #104 from Timur --- Please make a wrap-up or rather close this one and open new ones for what's missing, unless already open. We have Meta for many issues, this one also deserved meta. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Heiko Tietze changed: What|Removed |Added Depends on||148085 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148085 [Bug 148085] Hyperlinks look bad (invisible / have no contrast) in dark mode on Windows -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #103 from ifrozenphoe...@outlook.com --- I've tested this feature with the daily master build of today (7.4 alpha) on Windows 11 22000.613 and it looks really good to me. Ok, it looks perfect :-). I haven't found any issues so far. Tested it with: Writer Calc Impress Thanks for the hard and long work on this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 V Stuart Foote changed: What|Removed |Added Depends on||148376 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148376 [Bug 148376] Insert Table toolbar: text with table size does not respect dark mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #102 from Rizal Muttaqin --- Created attachment 179282 --> https://bugs.documentfoundation.org/attachment.cgi?id=179282=edit There's white area in document recovery Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 52ef78f4923283e6e52d575bec81985b031cb30b CPU threads: 8; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win Locale: id-ID (id_ID); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #101 from Pedro --- Ah got it. Yes I noticed that it detects the theme option selected in Windows. I thought your comment referred to change the UI color from inside LibreOffice. My mistake then. Thank you for clarifying Stuart. :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #100 from V Stuart Foote --- (In reply to Pedro from comment #92) > Where is the dark theme toggle located? Can't find it. Not a manual action, the toggle is detected by Win10+ API called from dwmapi.dll and uxtheme.dll--ShouldAppsUseDarkMode() and SetPreferredAppMode()--mechanisms that Caolán picked up responding to how we set the Win10 Settings -> Colors -> "Choose your color" list box 'Light', 'Dark', or 'Custom'. Unfortunately we have no framework to consume a full XAML based UWP theme from the WDM. The old legacy GetSysColor() calls no longer suffice and were never parsed for UI color theme on the Windows builds. So while we now auto toggle the icon theme to Colibre Dark (thank you Caolán) we must still select the Tools -> Options -> Application Colors "LibreOffice Dark" color scheme--where a subset of the VCL widgets have colors set with defaults that appear OK in a Windows 10+ dark mode--but are not taken from the theme. Application color widgets set 'Automatic' are intended to pick up a color from os/DE theme, but those are not delivered to Windows builds, so they get set with defaults. User can customize either the LibreOffice or the LibreOffice Dark--or build/save their own UI color scheme. We just can't read it in automatically from any of the Windows builds. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #99 from Pedro --- Created attachment 179036 --> https://bugs.documentfoundation.org/attachment.cgi?id=179036=edit Column x Line numbers are still black (on black background) Column x Line numbers are still black (on black background) in Insert Table drop-down menu (both Impress and Writer). They should be White so that the numbers are readable (in the example the numbers should be 6*8). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #98 from Pedro --- Created attachment 179035 --> https://bugs.documentfoundation.org/attachment.cgi?id=179035=edit White background on display views Edit Modes White background also visible in Edit Modes of Display Views drop-down menu. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #97 from Pedro --- Created attachment 179034 --> https://bugs.documentfoundation.org/attachment.cgi?id=179034=edit White background on Slide background drop-down The background on Slide background drop-down in Standard toolbar view in Impress is light. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 John Mills changed: What|Removed |Added CC||jmill...@yahoo.com --- Comment #96 from John Mills --- On a semi related note could I also ask is the header bar colour (in this case black)is an option that can be changed, I ask this because I think it would be really nice to see this reflect the colours of the constituent application, e.g. Blue for Witer, Green for Calc, red for Impress etc. Some colour would improve the look of what is a very grey application and make identification easier when you have many windows open at once. Cheers, John -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #95 from John Mills --- Hi all,hi Caolán, This is starting to look really good,I would definitely use this now! Would the new tabs also be possible to implement in the Light mode? If it is possible then it would resolve the issue that I created in Bugzilla in 2018. https://bugs.documentfoundation.org/show_bug.cgi?id=122361 Thanks and very best regards, John -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #94 from Pedro --- So active Tab title background is the same as inactive tab background. It's different from Tab body background. This seems like a conscious design decision from Caolán that might be dictated by limitations on what he can do or by a personal decision. Either way, I like it even if it's not the same as the Light tabbed UI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #93 from Pedro --- Created attachment 179033 --> https://bugs.documentfoundation.org/attachment.cgi?id=179033=edit Tabs with latest commit These are the tabs after Caolán's latest commits. The white border surrounding the Tab body is gone. That immensely improved the visual of the dark mode and in itself to me, makes it suitable to be moved out of experimental. So I give my +1 to V Stuart Foote proposal. There's still no connection between Tab title and tab body, But I like the floating Tab titles and I kind of like highlight of the active Tab title? I'm conflicted. It looks good, but it's different from the look with Light mode so I would say consistency would be necessary. But I like this mode, so maybe change the Light mode to look like this. It reminds me of the tabs of the new Firefox UI. If they had rounded corners they would look awesome. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #92 from Pedro --- (In reply to V Stuart Foote from comment #89) > @Caolán, had a test drive of today's > Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: a997bd0e77d9721d55311dcfbd50fea802d801bd > CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: > win > Locale: en-US (en_US); UI: en-US > Calc: CL > > Dark icon theme toggle [1] is functioning. > > Can we do similar to toggle over to the "LibreOffice Dark" color scheme in > 'Application Colors'? > > Although might need an expert config to be able to suppress for folks who > still want a White canvas while in dark mode. > > Other than that, just the fg/bg colors on the MUFFIN NB Paragraph style > previews for the Tabbed NB look to need a tweak for dark mode. But looks > like you already got that [2]. > > This can probably come out of Experimental... > > =-ref-= > [1] https://gerrit.libreoffice.org/c/core/+/131843 > > [2] https://gerrit.libreoffice.org/c/core/+/131902 Where is the dark theme toggle located? Can't find it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #91 from Mike Kaganski --- (In reply to Heiko Tietze from comment #90) We need some change in how "automatic" colors are treated in the color schemes, trying hard to get some meaningful colors from system, including taking dark mode into account. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #90 from Heiko Tietze --- (In reply to V Stuart Foote from comment #89) > Can we do similar to toggle over to the "LibreOffice Dark" color scheme in > 'Application Colors'? The LibreOffice Dark might follow Breeze Dark but could also be some random pink colors. I don't see the system colors and the application colors being on the same level. Same idea coincidentally on Twitter https://twitter.com/nekohayo/status/1505374769176358914 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #89 from V Stuart Foote --- @Caolán, had a test drive of today's Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a997bd0e77d9721d55311dcfbd50fea802d801bd CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Dark icon theme toggle [1] is functioning. Can we do similar to toggle over to the "LibreOffice Dark" color scheme in 'Application Colors'? Although might need an expert config to be able to suppress for folks who still want a White canvas while in dark mode. Other than that, just the fg/bg colors on the MUFFIN NB Paragraph style previews for the Tabbed NB look to need a tweak for dark mode. But looks like you already got that [2]. This can probably come out of Experimental... =-ref-= [1] https://gerrit.libreoffice.org/c/core/+/131843 [2] https://gerrit.libreoffice.org/c/core/+/131902 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #88 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/29c4d47161dab81971029717ce358de59f52f8c3 Related: tdf#118320 tabpane is too white in darkmode It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #87 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c51140847efa90897253011bd0382a32440d73e3 Related: tdf#118320 swap TILES_SELECTED and TILES_FOCUSED It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #86 from Pedro --- It is just a matter of changing Tab body selected background color from #202020 to #66. And to use also #66 for the Tab body border color so that it disappears. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #85 from Pedro --- Created attachment 178993 --> https://bugs.documentfoundation.org/attachment.cgi?id=178993=edit Make background of Tab body and Tab title same color and make Tab body border transparent (or give it same color as the other two) I would say these two things would clear up the Dark mode from Experimental to being supported: - Make background of Tab body and Tab title same color. - make Tab body border transparent (or give it same color as the other two). This would make the selected Tab body and Tab title seem continuous like the tabs look in Light mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #84 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/892ef6e8b6888b3029041ab150b409f81a5c31b0 Related: tdf#118320 let windows icon theme know when a dark theme is preferred It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #83 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/348407dfdf5fd41b99f5998463eb032128799555 Related: tdf#118320 tabitems appear as light in darkmode It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #82 from Pedro --- Created attachment 178974 --> https://bugs.documentfoundation.org/attachment.cgi?id=178974=edit Arrows to increase and decrease numbers The arrows highlighted in the red box do not obtain dark theme. This is minor compared to the issue with tabs in dialogs and the Tabbed UI. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #81 from Pedro --- --off-topic-- You don't do a great disservice in steering Windows users to a UI paradigm they are used to working with for the past 15 years and that they are confortable with. You have kids in high school that have known no other Office suite UI paradigm besides a tab-like UI. A great disservice would be to force them onto an UI paradigm they never saw in their lives using office suites if they want to use an open-source office suite. Well maybe they would just move to Only Office, which is another open source Office suite that is more agile in their development and that actually provides that familiar UI paradigm. I agree that it's a great disservice that there's always been so much outright hostility towards developing a well thought out Tabbed UI with a more appropriate code. If anyone wants to do it, they're welcome. Any talk of removing the Tabbed UI or disincentivize its use for Windows users, nor properly supporting is just downright hostility towards Windows users of LibreOffice. I welcome Caolán work towards this. If he has a Patreon account or something I would like to buy him lunch for this work. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #80 from Pedro --- Created attachment 178973 --> https://bugs.documentfoundation.org/attachment.cgi?id=178973=edit Paragraph dialog Mike Kaganski screenshot in LibreOffice Design Telegram channel showing Paragraph dialog after commit https://git.libreoffice.org/core/+/c43c4a00089b1965c7ef69ef40c9e645dffc2e43 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #79 from Pedro --- Created attachment 178972 --> https://bugs.documentfoundation.org/attachment.cgi?id=178972=edit Bullets and numbering dialog Apparently the issue with the Tabbed UI is not restricted to the Tabbed UI itself but with tabbed dialogs themselves. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #78 from V Stuart Foote --- As Caolán notes: "Its possible it makes more sense to not try and use the windows control drawings apis and just set some dark colors and draw with the old built-in vcl widget rendering or alternative." The uxtheme.dll ShouldAppsUseDarkMode() and SetPreferredAppMode() mechanism is functional if not the best documented API [1] for Win32 WDM development, but much better than other suggested approach of reading a DWORD value from the Windows Registry. But as the APIs are structured it means we can only provide DarkMode to Win 10 build 1904 (18362) or later (with things still settling out for changes in Win 11). It can not support Win 7.1, 8, 8.1 or earlier builds of Win 10. How much of an issue is that? And as Caolán suggests are we better served to round out the VCL based "Application Colors" dialog with the additional widgets that need UI color assignment? [1] https://github.com/microsoft/WindowsAppSDK/issues/41 =-off-topic-= Given that the vaunted "Tabbed UI" MUFFIN assemblages for the Notebook Bar are not native MS "Ribbon framework" code it remains wrong to put that forward as a work alike, especially as the standard UI toolbars, menus and dialogs supplemented with the Sidebar deck are the documented (and fully supported) LibreOffice work flows cfross-platform. Absent a major refactoring there, we do a disservice to users by steering them to the Tabbed UI--but that is off topic. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #77 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c43c4a00089b1965c7ef69ef40c9e645dffc2e43 Related: tdf#118320 darkmode DrawThemeBackground doesn't work for tab bodies It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #76 from Pedro --- IMO (since I don't have the user data to back it up), the Tabbed UI is the most used in Windows because it is closer to the Ribbon UI from Microsoft Office. Thus, the only requirement to move this out of experimental would be to fix that bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #75 from V Stuart Foote --- (In reply to Caolán McNamara from comment #73) > With "tools, options, advanced, enable experimental features" enabled this > partial very experimental "demo" is available with the caveats mentioned in > the above commit message. Maybe it can help point people the right way > towards a full solution and illustrate some of the code involved in how we > do the windows themeing and color selection Yep, looking very promising. Setting Rizal's new Colibre Dark icons, and setting Application colors to the 'LibreOffice Dark' this last piece is doing a nice job of rendering in a Dark mode. With this configuration toolbars, menus and the SB deck all look great. And of the MUFFIN assemplages, every thing is pretty presentable except the 'Tabbed' and the 'Tabbed Compact', which have bg color issues for the UI area fills. This is a lot better than we were able to achieve using the os/DE passed theme details when an Assistive Technology 'HighContrast' theme is set; e.g. GreyEve and the forced Sifr icon theme. Looks like weere on the right track for Windows 10+, shame about the Tabbed UI--I know some folks will fuss. Thanks Caolán! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #74 from Pedro --- Caolán, quite frankly this looks amazing already. The only real blocker I see is the Tabbed UI. There a couple of other minor issues that I'll open bug reports and append here. Another couple of suggestion can be done as enhancements: - Change Application color automatically to LibreOffice Dark when it toggles to Dark mode. - Change to Dark version of icon sets when Dark mode is activated. - Create option in the menu for the users to select Light or Dark mode by themselves (ex. user with light theme that wants dark mode in LibO or vice-versa) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #73 from Caolán McNamara --- With "tools, options, advanced, enable experimental features" enabled this partial very experimental "demo" is available with the caveats mentioned in the above commit message. Maybe it can help point people the right way towards a full solution and illustrate some of the code involved in how we do the windows themeing and color selection -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #72 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a3f400886768bf95fbd8e6b236e11d7aac393b96 Related: tdf#118320 enable some windows dark theme support It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #71 from Pedro --- Implementing this behind experimental mode would be a great way to gather more feedback and eve help from other devs, true. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #70 from Rizal Muttaqin --- (In reply to Telesto from comment #68) > > Quote > "Toggling from dark to light mode is detected, and getting some > suitable colors for dark mode works. > > The titlebar will toggle into dark/light mode successfully. > > DrawThemeBackground does something sensible for buttons and scrollbar at > least, comboboxes can be forced to work. SpinButtons are less > successful. Menubar and toolbar just bodged to draw a solid backcolor." > > > It's simply not good enough at this point. I am sorry I don't get the point. If some UI elements have issues so why it prevent to be just experimental one? What kind of blocker is that? Should we wait for API change for Microsoft or should any further reengineering from LibO side? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #69 from Pedro --- Yes, I understand. Don't want to push for something that is still not working properly to be included. I don't build on a daily basis, no... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #68 from Telesto --- (In reply to Pedro from comment #65) > That seems perfect to me Caolan. > Is it available on Master? How to enable it? I can test it out and provide > you feedback. There isn't a pre-build. You can build it yourself with commit in question (but lot of work if you don't build LibreOffice on daily basis). I don't think there is no point of having this in Master already looking at the (current) commit message of https://gerrit.libreoffice.org/c/core/+/131453 Quote "Toggling from dark to light mode is detected, and getting some suitable colors for dark mode works. The titlebar will toggle into dark/light mode successfully. DrawThemeBackground does something sensible for buttons and scrollbar at least, comboboxes can be forced to work. SpinButtons are less successful. Menubar and toolbar just bodged to draw a solid backcolor." It's simply not good enough at this point. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #67 from Pedro --- https://bugs.documentfoundation.org/show_bug.cgi?id=121877 Tabbed UIs do not use theme color - keeps the default application color This might be a challenge for dark mode support in Tabbed bar Caolan. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Pedro changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1877 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #66 from Pedro --- There might be another issue though: the Tabbed bar. I doubt it will use the dark theme in Windows. That would probably need another set of patches to fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #65 from Pedro --- That seems perfect to me Caolan. Is it available on Master? How to enable it? I can test it out and provide you feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #64 from Caolán McNamara --- Created attachment 178901 --> https://bugs.documentfoundation.org/attachment.cgi?id=178901=edit screenshot of that approach Its not totally hopeless to go down a route like https://gerrit.libreoffice.org/c/core/+/131453 but it is not totally satisfactory either on trying to use the private windows apis and then bodge around with SetWindowTheme to get the handful of windows theme items that seem to work in that mode. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #63 from Pedro --- Wow, those are good news indeed. So it's possible to detect dark theme from Windows 10 and it changes elements? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #62 from Caolán McNamara --- Created attachment 178847 --> https://bugs.documentfoundation.org/attachment.cgi?id=178847=edit some partial effect With the experimental https://gerrit.libreoffice.org/c/core/+/131453 I get this screenshot. Menus are in dark mode too. So perhaps worth exploring further as there are some partial useful effects. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #61 from John Mills --- As Microsoft Windows users are an order of magnitude larger than Linux and MacOS combined in LibreOffice there should be feature parity in the desktop feature set mode between OS versions. As a primarily Windows user who donates on releases of LibreOffice I feel that my contributions are less valued than other OS users. The dark mode is also a usability feature as highlighted above and an expected feature in modern desktop applications. Emphasis should be made to remove this disparity for Windows users and improve the LibreOffice experience for >90% of the user base. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #60 from Caolán McNamara --- (In reply to Pedro from comment #59) > Trying to read their code in Github. Is this the relevant bit? > > https://github.com/winscp/winscp/blob/master/source/windows/UserInterface.cpp following that example would suggest that the relevant piece is: static int __fastcall SysDarkTheme(HKEY RootKey) at https://github.com/winscp/winscp/blob/master/source/windows/WinConfiguration.cpp#L2123 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320
--- Comment #59 from Pedro ---
Trying to read their code in Github. Is this the relevant bit?
https://github.com/winscp/winscp/blob/master/source/windows/UserInterface.cpp
line 376:
void __fastcall ConfigureInterface()
{
int BidiModeFlag =
AdjustLocaleFlag(LoadStr(BIDI_MODE), WinConfiguration->BidiModeOverride,
false, bdRightToLeft, bdLeftToRight);
Application->BiDiMode = static_cast(BidiModeFlag);
SetTBXSysParam(TSP_XPVISUALSTYLE, XPVS_AUTOMATIC);
if (WinConfiguration != NULL)
{
UnicodeString Theme = WinConfiguration->UseDarkTheme() ? L"DarkOfficeXP" :
L"OfficeXP";
if (!SameText(TBXCurrentTheme(), Theme))
{
TBXSetTheme(Theme);
}
}
And maybe in these next pages?
https://github.com/winscp/winscp/blob/master/source/components/ThemePageControl.cpp
https://github.com/winscp/winscp/blob/master/source/components/ThemePageControl.h
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #58 from Pedro --- Github repo of WinSCP https://github.com/winscp/winscp https://winscp.net/eng/index.php -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #57 from Pedro --- Another non-UWP app that supports automatic dark mode in Windows 10 is the ftp client open source client WinSCP (GPLv3). Maybe it would be a good idea to get in contact with other open source software that managed to add this support to ask for pointers. Furthermore WinSCP is written in C++ so they might be able to help even. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #56 from Jahin Z. --- (In reply to V Stuart Foote from comment #54) > (In reply to V Stuart Foote from comment #53) > > > > "Either of two ways to address. One would be to implement support for UWP > > theming mechanism--a lot of native Windows code." > > > > Only that would "solve" the incorrectly read UWP system colors, though we'll > > need to keep track of HC mode behavior as well. > > > > Though another approach, as in comment 40, avoids the unsupportable UWP > framework and uses winrt.UI.ViewManagement UIsettings for win32 calls to > pickup the os/DE (XAML) theme support. Seems like this provides a functional > alternative API providing full os/DE theme. But just of use for Windows 10 > onward. [1] > > I think we can agree there will never be a win32 API for passing Windows WPF > color theming. > > =-ref-= > [1] > https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/using-the- > xaml-hosting-api I can list about 5 or so non-UWP apps on my computer that support auto-dark mode from the system: Discord, Chrome, Firefox, MS Office, Paint.NET, Adobe Acrobat, and probably more I can't recall. I really cannot understand why you guys are making a big deal out of this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 --- Comment #55 from Pedro --- (In reply to V Stuart Foote from comment #54) > (In reply to V Stuart Foote from comment #53) > > > > "Either of two ways to address. One would be to implement support for UWP > > theming mechanism--a lot of native Windows code." > > > > Only that would "solve" the incorrectly read UWP system colors, though we'll > > need to keep track of HC mode behavior as well. > > > > Though another approach, as in comment 40, avoids the unsupportable UWP > framework and uses winrt.UI.ViewManagement UIsettings for win32 calls to > pickup the os/DE (XAML) theme support. Seems like this provides a functional > alternative API providing full os/DE theme. But just of use for Windows 10 > onward. [1] > > I think we can agree there will never be a win32 API for passing Windows WPF > color theming. > > =-ref-= > [1] > https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/using-the- > xaml-hosting-api I think focusing on Windows 10 onwards for this is what makes sense. OS level support for dark themes was only introduced in W10. So it should be offered to W10 forward. Previous Windows versions are not supported by Microsoft anymore. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118320] Add support for Windows 10/11 dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=118320 Adolfo Jayme changed: What|Removed |Added Summary|Add support for Windows 10 |Add support for Windows |dark mode |10/11 dark mode -- You are receiving this mail because: You are the assignee for the bug.
