[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-02-22 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

Justin L  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Justin L  ---
The beautiful green colour is lost, but the macro button exists and is still
functional after multiple round-trips. I'll mark it as fixed.

What does NOT work is .xls -> .xlsm, or .xlsm -> .xls. However, those are
fairly different internal binary changes IIUC, so that doesn't surprise me. The
fact that it can simply round-trip is already rather impressive.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

--- Comment #8 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/245912dc42bfc13cbf0db3f04f2411f3dede9615

tdf#117266 tdf#120374 sc oox: export correct vml button name #2

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

--- Comment #7 from Justin L  ---
Created attachment 184825
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184825=edit
webster-sainte-lague-calculator.xls: Excel 2010 roundtrip of attachment 145441

Note: starting from an Excel-created XLS and round-tripping that as XLS works
fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120374] FILESAVE XLSM: VBA button doesn't execute linked macro after round-trip

2023-01-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120374

Justin L  changed:

   What|Removed |Added

Summary|VBA button disappears after |FILESAVE XLSM: VBA button
   |resaving to XLSM, also  |doesn't execute linked
   |doens't work if saved to|macro after round-trip
   |ODS |
 Resolution|DUPLICATE   |---
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||7266,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||4203
 Status|RESOLVED|NEW
 CC||jl...@mail.com

--- Comment #6 from Justin L  ---
This was mostly fixed by commits for bug 117266. The buttons no longer
disappear on a round-trip. However, the macro doesn't execute - probably
because "ThisWorkbook" has been duplicated. (That is also true in bug 124203.)

Removing as duplicate, since the broken VBA is not necessarily due to the same
reason as any of the others.

Round-tripping as XLS didn't work and exhibits the same duplicate ThisWorkbook1
(at least as seen in Excel 2003).

Manually running the macro code in LO works - so perhaps the first thing to
look into is why the macro-link is lost on the button. Perhaps that is caused
by something different than some of the other export issues? Ahh, probably the
name changed. It is based on a _Click macro. In the round-trip it is just
getting a numberId and is losing the spid connection. So some of the
name-related commits in bug 117266 weren't good enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.