[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7880 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #14 from Mike Kaganski --- (In reply to Rizal Muttaqin from comment #13) This is not related to this bug. If needed, please file another one. Specifically, the icons that you fixed, you fixed *correctly* to 24px. Your question is related to "do we want to use *these* icons for inserted objects, or should we use lxNNN_32 variants instead?". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #13 from Rizal Muttaqin --- Created attachment 179221 --> https://bugs.documentfoundation.org/attachment.cgi?id=179221=edit Image inserted as OLE in Galaxy use 32px (In reply to Rizal Muttaqin from comment #12) > Just curious, do we need too enlarge the icon? The 24px for me is too tiny > for a OLE OBJECT document icon inserted? Galaxy as the main fallback in the past use 32px (lx03125.png) for inserted OLE Object image type. This size more suitable for me, not too large nor too tiny. But how we deal with lx* file? Mike you said that the file is supposed to be 24 px? So why some of res/lx* Galaxy icons are 32px? I think we should have an agreement here - What are proper/the best icon dimension size for the embedded OLE Object file? - Do all lx* files have to be 24px? If there is a 32px size, do we need to define it in the coding section, for example an xlx* image with a size of 32px. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #12 from Rizal Muttaqin --- Created attachment 179220 --> https://bugs.documentfoundation.org/attachment.cgi?id=179220=edit Object inserted in WPS Office use huge icons Just curious, do we need too enlarge the icon? The 24px for me is too tiny for a OLE OBJECT document icon inserted? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #11 from Commit Notification --- Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/95e85730ad850a66879a639d9f5936fa67549ab7 Colibre: tdf#120425 equalize icon dimensions It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #10 from Adolfo Jayme Barrientos --- (Back in 2019, I wrote in commit bea44e5c1b982d05314b72452b94fe288071a496 that the canonical size should be 24 × 24. It’s a logical value that has precedence in Linux icon themes, and I’ve never known why Sun decided on a seemingly random value of 26 pixels.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #9 from Rizal Muttaqin --- (In reply to Mike Kaganski from comment #8) > https://opengrok.libreoffice.org/xref/core/include/vcl/vclenum. > hxx?r=2f4f4cbe=Size26#320). Likely 26px should be updated as now all icon themes are using 24px instead. But it's another topic. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #8 from Mike Kaganski --- (In reply to Rizal Muttaqin from comment #6) > Does lx* files are supposed to be 24px (Galaxy use 26px instead of 24px in > their large size variants) or 32px? This is my long question actually https://opengrok.libreoffice.org/xref/core/svtools/source/misc/imagemgr.cxx?r=60eaa424#505 (and its respective BMP_* constants defined in https://opengrok.libreoffice.org/xref/core/svtools/inc/bitmaps.hlst?r=60eaa424) suggests that lx are 24/26 pixels (and the 24/26 is documented at https://opengrok.libreoffice.org/xref/core/include/vcl/vclenum.hxx?r=2f4f4cbe=Size26#320). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #7 from Rizal Muttaqin --- (In reply to Mike Kaganski from comment #5) > (In reply to Rizal Muttaqin from comment #4) > > Could you please tell which specific icons (filenames) are those? And what > is different wrt those filenames compared to Tango (comment 0)? For Tango - ODT: res/lx03251.png (24px) - ODS: res/lx03250.png (24px) - XLSX: res/lx03126.png (24px) which has same exact appearance with res/lx03127.png. But from Galaxy reference, I can say lx03126.png is the file - DOCX: res/lx03162.png (24px) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #6 from Rizal Muttaqin --- (In reply to Mike Kaganski from comment #5) > (In reply to Rizal Muttaqin from comment #4) > > Could you please tell which specific icons (filenames) are those? And what > is different wrt those filenames compared to Tango (comment 0)? Just tried Galaxy and the issue is reproducible also. I guess some icons that being used from Galaxy reference: - ODT: res/lx03251.png (26px) - ODS: res/lx03250.png (26px) - XLSX: res/lx03188.png or res/lx03126.png (?) (32px) - DOCX: res/lx03162.png or res/lx03156.png (?) (32px) Here come the confusion. Does lx* files are supposed to be 24px (Galaxy use 26px instead of 24px in their large size variants) or 32px? This is my long question actually -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #5 from Mike Kaganski --- (In reply to Rizal Muttaqin from comment #4) Could you please tell which specific icons (filenames) are those? And what is different wrt those filenames compared to Tango (comment 0)? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 Rizal Muttaqin changed: What|Removed |Added CC||riz...@libreoffice.org --- Comment #4 from Rizal Muttaqin --- Reproducible with Colibre Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2816f498505bab01bc0f17ef0962ece663c607c9 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: id-ID (id_ID.UTF-8); UI: en-US Calc: threaded Any design part which should be updated? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 Mike Kaganski changed: What|Removed |Added Blocks||107810 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107810 [Bug 107810] [META] OLE/Embedded object bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 --- Comment #3 from Mike Kaganski --- Still repro with Version: 6.4.0.0.alpha1+ (x64) Build ID: c0b8be4d7eb9fa1a0d8abfb1d27c71ac34bffd1b CPU threads: 12; OS: Windows 10.0 Build 18362; UI render: GL; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120425] Different icon sizes for different filetypes inserted as icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120425 Buovjaga changed: What|Removed |Added CC||kain...@gmail.com, ||todven...@suomi24.fi Severity|normal |minor Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Buovjaga --- Repro with Colibre, but not with Tango. Got a crash with master, have to check it tomorrow. Arch Linux 64-bit Version: 6.1.2.1 Build ID: 6.1.2-1 CPU threads: 8; OS: Linux 4.18; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); Calc: group threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
