[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

Dieter Praas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1816
 Resolution|--- |NOTABUG

--- Comment #13 from Dieter Praas  ---
(In reply to Jim Raykowski from comment #12)

> I would also expect this but after checking I see that a no style table
> inserted with the table picker has borders and a no style table inserted
> with the Insert Table dialog has no borders. I would think for consistency
> both should have the same?

So my suggestion is to close this as NAB. I've opened a new report (bug 121816)
about the difference you mentioned.
If somebody doesn't agree, feel free to reopen the report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #12 from Jim Raykowski  ---
(In reply to Dieter Praas from comment #11) 
> So what I would expect (regarding your
> explanations) is that using the table picker has the same result than
> choosing "none style" in the insert dialog.

I would also expect this but after checking I see that a no style table
inserted with the table picker has borders and a no style table inserted with
the Insert Table dialog has no borders. I would think for consistency both
should have the same?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #11 from Dieter Praas  ---
(In reply to Jim Raykowski from comment #10)
> IMHO NAB because Default Table style and no table style are not the same.
> When Default Table style is applied to a table with no style the slight
> expansion might be viewed as a subtle hint to an observant user that
> something has been done to the table. It may have been purposely design this
> way?

I agree, that Default table style and no table style can or should look
different. But actually the defference is so minimal that perhaps a lot of
users think it's the same. So what I would expect (regarding your explanations)
is that using the table picker has the same result than choosing "none style"
in the insert dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #10 from Jim Raykowski  ---
IMHO NAB because Default Table style and no table style are not the same. When
Default Table style is applied to a table with no style the slight expansion
might be viewed as a subtle hint to an observant user that something has been
done to the table. It may have been purposely design this way?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #9 from Dieter Praas  ---
Jim, so taking your commetn into account, what is your suggestion for this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #8 from Jim Raykowski  ---
(In reply to Telesto from comment #4)
> (In reply to Dieter Praas from comment #3)
> > I confirm it with
> > 
> > Version: 6.2.0.0.beta1 (x64)
> > Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
> > CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> > Locale: en-US (de_DE); UI-Language: en-GB
> > Calc: threaded
> > 
> > This happens because of different width of table borders
> > table picker: Table border 0,05pt
> > default style: Table border 0,5pt
> > 
> > Table borders of table with table picker should also have 0,5pt
> 
> @Jim
> You're the table style expert ;-). So I thought you might be interested..

Thank you for the compliment but... really I'm no expert, just enjoy hacking on
LO and being a part of this awesome community :-)

Guessing the "table picker" is the insert table tool button. The button that
inserts a table with no style. If so, it is plausible the cause of the shift is
as Dieter has pointed out. 

Tables inserted with the insert table tool button have no style. Table Default
Style is an auto format table style. When a table style is applied to a table
any direct formatting is replaced by the table style when rows or columns are
added/deleted. We tried using Default Style as the default for newly inserted
tables. Probably shouldn't do that again. It may hold the record for the most
bug reports :(, see bug 115573

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

Dieter Praas  changed:

   What|Removed |Added

Version|6.2.0.0.alpha1+ |6.1.3.2 release

--- Comment #7 from Dieter Praas  ---
Also repro in

Version: 6.1.3.2 (x64)
Build-ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; 
Gebietsschema: de-DE (de_DE); Calc: group threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

Telesto  changed:

   What|Removed |Added

 Attachment #147155|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #6 from Telesto  ---
Sorry, wrong bug..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

--- Comment #5 from Telesto  ---
Created attachment 147155
  --> https://bugs.documentfoundation.org/attachment.cgi?id=147155=edit
Bibisect log

Bisected to

author  Armin Le Grand   2018-10-25 10:06:05 +0200
committer   Armin Le Grand   2018-10-25 12:43:55
+0200
commit  313392119522c21a6ecd14403d6f92c948149df7 (patch)
treefbd1a112a41f83d34c6bb6ea79eeccf73dba3e7b
parent  8dec85a3b3f4cbd46b03f707458347a25cc22c15 (diff)
Reorganize FrameBorderPrimitive creation (II)
Step5: Move the view-dependent decomposition from
BorderLinePrimitive2D to SdrFrameBorderPrimitive2D.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=313392119522c21a6ecd14403d6f92c948149df7

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

Telesto  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #4 from Telesto  ---
(In reply to Dieter Praas from comment #3)
> I confirm it with
> 
> Version: 6.2.0.0.beta1 (x64)
> Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
> CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
> Locale: en-US (de_DE); UI-Language: en-GB
> Calc: threaded
> 
> This happens because of different width of table borders
> table picker: Table border 0,05pt
> default style: Table border 0,5pt
> 
> Table borders of table with table picker should also have 0,5pt

@Jim
You're the table style expert ;-). So I thought you might be interested..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121029] The table borders using the table picker tool is slightly different from Table Insert

2018-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121029

Dieter Praas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||dgp-m...@gmx.de
 Blocks||107701
Summary|The table size using the|The table borders using the
   |table picker tool is|table picker tool is
   |slightly different from |slightly different from
   |Table Insert|Table Insert
 Ever confirmed|0   |1

--- Comment #3 from Dieter Praas  ---
I confirm it with

Version: 6.2.0.0.beta1 (x64)
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded

This happens because of different width of table borders
table picker: Table border 0,05pt
default style: Table border 0,5pt

Table borders of table with table picker should also have 0,5pt


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107701
[Bug 107701] [META] Table border bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs