[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-02-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #12 from Commit Notification 
 ---
Tamas Bunth committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/16710fab5248b21c1c2cb8b6a4eac3a7a2d64792%5E%21

tdf#121069, tdf#121469 migrate special characters

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-02-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.3.0|target:6.3.0 target:6.2.1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Tamas Bunth  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #11 from Commit Notification 
 ---
Tamas Bunth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2ec13411b7e7b18d1ea28faee9ad93e0b7b21dde%5E%21

tdf#121069, tdf#121469 migrate special characters

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #10 from Julien Nabet  ---
Tamas:
I created a local patch consisting to:
- copy lcl_ConvertToUTF8 and lcl_IndexOfUnicode from createparser.cxx to
parseschema.cxx
- in parserschema.cxx, SchemaParser::parseSchema method replace:
OUString sSql = xTextInput->readLine();
by 
OUString sSql = lcl_ConvertToUTF8(OUStringToOString(xTextInput->readLine(),
RTL_TEXTENCODING_UTF8));

Of course, it'd better to centralize ConvertToUTF8 mechanism because
rColumnName in parseColumnPart method must need it, but what do you think about
the principle?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Stephan Bergmann  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #9 from Stephan Bergmann  ---
See bug 117115 comment 14: "I assume the issue with table names has not yet
been addressed (cf. bug 121469)?"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2019-01-30 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Julien Nabet  changed:

   What|Removed |Added

 CC||tho...@junovagen.se

--- Comment #8 from Julien Nabet  ---
*** Bug 123020 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-12-02 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||9502

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Xisco Faulí  changed:

   What|Removed |Added

   Priority|medium  |high
 OS|Linux (All) |All
   Hardware|x86-64 (AMD64)  |All

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #7 from Drew Jensen  ---
Created attachment 146716
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146716&action=edit
Pictures are worth lots of words

Here is what I find using a recent build of LO 6.2Alpha1 on Linux.

I found no problem using unicode characters with Base GUI controls with ODB
files using HSQL or Firebird, this included Table Designer, Query Designer,
Form Designer and Report Builder.

Created the table Straße with a column Straße in HSQL and used Drag-n-Drop to
create a copy of it in an empty Firebird ODB, with no problem. 

Created the table Straße with a column Straße in Firebird and used Drag-n-Drop
to create a copy of it in an empty HSQL ODB, with no problem. 

For the rest of the checks, I put them in pictures - an Impress file attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #6 from rob...@familiegrosskopf.de ---
(In reply to m.a.riosv from comment #5)
> CREATE TABLE Straße (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT
> NULL, PRIMARY KEY (CUST_NO) )

This is wrong code for creating a table with lower characters. "ß" is a special
lower character. With 
CREATE TABLE Strasse
the table will be named STRASSE.
With the right delimiters 
CREATE TABLE "Straße" 
it will work well as observed by you.

There will be used delimiters during the migration-process, because the tables
where shown with lower and upper case characters. So this isn't the problem of
the migration-process.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #5 from m.a.riosv  ---
If I'm not wrong LibreOffice base always use delimiters.
Doing a test with direct SQL with a sentence like:
CREATE TABLE TESTTABLE (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT
NULL, PRIMARY KEY (CUST_NO) )
works, but
CREATE TABLE Straße (CUST_NO INTEGER NOT NULL, CUSTOMER VARCHAR(25) NOT NULL,
PRIMARY KEY (CUST_NO) )
givers an error:
1: firebird_sdbc error:*Dynamic SQL Error *SQL error code = -104 *Token unknown
- line 1, column 18.
Just in the position of ß.
With CREATE TABLE "Straße" seems work.

Perhaps the issue it's the migration process not using delimiters.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

--- Comment #4 from Drew Jensen  ---
(In reply to m.a.riosv from comment #3)
> Maybe because non 7-bit ASCII are not allowed as regular identifiers, they
> must be delimited.
> http://www.firebirdtest.com/file/documentation/reference_manuals/fblangref25-
> en/html/fblangref25-structure-identifiers.html
> 
> It has no change on FB 3 see page 22
> https://www.google.com/
> url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=2ahUKEwjY7JXXt9veAhUqNOwKHXSnDWc
> QFjAAegQIARAC&url=https%3A%2F%2Ffirebirdsql.
> org%2Ffile%2Fdocumentation%2Frelease_notes%2FFirebird-3.0.0-ReleaseNotes.
> pdf&usg=AOvVaw2PXMthc9Ii-VAJjhxHKy_j

No, if you creat that table or the relationship using Base w/emb firebird
database there is no problem with these characters. It is the migration
assistant code having the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #3 from m.a.riosv  ---
Maybe because non 7-bit ASCII are not allowed as regular identifiers, they must
be delimited.
http://www.firebirdtest.com/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-structure-identifiers.html

It has no change on FB 3 see page 22
https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=2ahUKEwjY7JXXt9veAhUqNOwKHXSnDWcQFjAAegQIARAC&url=https%3A%2F%2Ffirebirdsql.org%2Ffile%2Fdocumentation%2Frelease_notes%2FFirebird-3.0.0-ReleaseNotes.pdf&usg=AOvVaw2PXMthc9Ii-VAJjhxHKy_j

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Adolfo Jayme  changed:

   What|Removed |Added

   Severity|normal  |major
 CC||fit...@ubuntu.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Drew Jensen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1069
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from Drew Jensen  ---
Added issue 121069 to see also. There problem, during migration, when special
characters in column names and the column is used in a foreign key.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 121469] FIREBIRD: Migration for table names with special characters fails

2018-11-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121469

Drew Jensen  changed:

   What|Removed |Added

 CC||drewjensen.in...@gmail.com

--- Comment #1 from Drew Jensen  ---
Created attachment 146698
  --> https://bugs.documentfoundation.org/attachment.cgi?id=146698&action=edit
example HSQL base file

Confirmed with Ubuntu 18.04 
LibreOffice Version: 6.2.0.0.alpha1+
Build ID: 85dba18a3d3644a4ac49bd32ea106a4d69159fb4
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2018-11-13_23:14:30


Attached test file (hsql) with both table name and a column as "Straße"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs