[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 Nicolas Christener changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4358 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544
--- Comment #14 from Nicolas Christener ---
(In reply to Xisco Faulí from comment #13)
> (In reply to Nicolas Christener from comment #11)
> > I suggest to also disable the menu entry "File > Close document" ("Datei >
> > Dokument schliessen" in German) - this one still leads to the crash.
>
> Hello Nicolas,
> Would you mind reporting the mentioned problem in a new ticket ? Normally we
> try to have one problem per ticket.
> Closing as RESOLVED FIXED as the reported problem in the ticket was fixed by
> Tor.
IMHO its still the same root issue, but of course I'm happy to create a new
ticket. Thanks for your support.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544
Xisco Faulí changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REOPENED|RESOLVED
--- Comment #13 from Xisco Faulí ---
(In reply to Nicolas Christener from comment #11)
> I suggest to also disable the menu entry "File > Close document" ("Datei >
> Dokument schliessen" in German) - this one still leads to the crash.
Hello Nicolas,
Would you mind reporting the mentioned problem in a new ticket ? Normally we
try to have one problem per ticket.
Closing as RESOLVED FIXED as the reported problem in the ticket was fixed by
Tor.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544
Nicolas Christener changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |---
--- Comment #11 from Nicolas Christener ---
I suggest to also disable the menu entry "File > Close document" ("Datei >
Dokument schliessen" in German) - this one still leads to the crash.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #12 from Nicolas Christener --- Created attachment 150137 --> https://bugs.documentfoundation.org/attachment.cgi?id=150137=edit Menu entry "close document" still triggers the crash -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 Tor Lillqvist changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #10 from Tor Lillqvist --- Nicolas, please mark as verified when you have eventually verified that the bug is gone. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #9 from Tor Lillqvist --- I mean collabora-online-4 branch, not cp-6.0. That change was to online, not core. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #8 from Tor Lillqvist --- The above somewhat ugly workaround fixes the issue. Patch applied also in the cp-6.0 branch. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #7 from Commit Notification --- Tor Lillqvist committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/online/+/e9ca86de8531aeec7458578ee6e932aae11260ca%5E%21 tdf#122544: Disable the 'closemobile' button while tunnelled dialog is showing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 Commit Notification changed: What|Removed |Added Whiteboard||target:6.3.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #6 from Tor Lillqvist --- A wild idea would of course be to change the horrible mess of raw pointers and references between the types involved to use smart pointers (std::shared_ptr) instead, but I wouldn't be surprised if there are circular references involved, so that would likely lead to leaks. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #5 from Tor Lillqvist --- Created attachment 150095 --> https://bugs.documentfoundation.org/attachment.cgi?id=150095=edit Patch attempt Tried this, did not work, cause heap corruption, sigh. Not sure whether I should continue this approach or try something completely different. Maybe that SfxItemPoolUser/AddSfxItemPoolUser/RemoveSfxItemPoolUser mechanism is crack that was just one guy's idea back in the days, and that he used only in one corner case (it is used only by some very limited stuff in editeng, which isn't a good sign, is it?) and it isn't usable in general Kendy talks about LOKNotifier, maybe that is a better idea? > Yeah, I meant in core - something similar to the code that does "when the > window has no LOKNotifier, cancel it right away" > Just iterate through the list of the windows that have the LOKNotifier, and > cancel them (?) > But hmm, when I look at that, there it just immediately returns false from > ImplStartExecute() > [Still, the iteration over the LOKNotifiers would be possible, if it helps in > any way.] -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #4 from Tor Lillqvist --- Problem is that a SfxItemPool object is destructed at: > #00x00010228ece0 in SfxItemPool::~SfxItemPool() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/svl/source/items/itempool.cxx:333 > #10x00010281cec4 in SwAttrPool::~SwAttrPool() [inlined] at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/core/attr/swatrset.cxx:59 > #20x00010281cec0 in SwAttrPool::~SwAttrPool() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/core/attr/swatrset.cxx:59 > #30x00010228ff60 in SfxItemPool::Free(SfxItemPool*) at > /Volumes/TML13/lo/ios-optimised-cp-6.0/svl/source/items/itempool.cxx:366 > #40x0001028905c0 in SwDoc::~SwDoc() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/core/doc/docnew.cxx:600 > #50x00010285de44 in SwDoc::release() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/core/doc/doc.cxx:151 > #60x000102cee2bc in rtl::Reference::clear() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/include/rtl/ref.hxx:157 > #70x000102cee01c in SwDocShell::RemoveLink() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/uibase/app/docshini.cxx:466 > #80x000102cede90 in SwDocShell::~SwDocShell() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/uibase/app/docshini.cxx:393 > #90x000102cee098 in SwDocShell::~SwDocShell() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/uibase/app/docshini.cxx:383 > #10 0x000102cee0f0 in SwDocShell::~SwDocShell() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/uibase/app/docshini.cxx:383 > #11 0x0001020742f8 in tools::SvRef::~SvRef() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/include/tools/ref.hxx:56 > #12 0x0001020293e8 in tools::SvRef::~SvRef() [inlined] > at /Volumes/TML13/lo/ios-optimised-cp-6.0/include/tools/ref.hxx:55 > #13 0x0001020293e4 in > IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:237 > #14 0x00010202926c in > IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() [inlined] > at /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:236 > #15 0x000102029268 in > IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:236 > #16 0x000102029e38 in std::__1::__shared_count::__release_shared() > [inlined] at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3490 > #17 0x000102029e10 in std::__1::__shared_weak_count::__release_shared() > [inlined] at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:3532 > #18 0x000102029e10 in > std::__1::shared_ptr::~shared_ptr() at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4468 > #19 0x000102018e84 in > std::__1::shared_ptr::~shared_ptr() > [inlined] at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4466 > #20 0x000102018e7c in > std::__1::shared_ptr::reset() [inlined] at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:4603 > #21 0x000102018e68 in SfxBaseModel::dispose() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:761 > #22 0x00010201b2e4 in SfxBaseModel::close(unsigned char) at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:1367 > #23 0x000102e0cb34 in SwXTextDocument::close(unsigned char) at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sw/source/uibase/uno/unotxdoc.cxx:632 > #24 0x000102018ea4 in SfxBaseModel::dispose() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/sfx2/source/doc/sfxbasemodel.cxx:722 > #25 0x00010213a724 in > desktop::LibLODocument_Impl::~LibLODocument_Impl() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/desktop/source/lib/init.cxx:886 > #26 0x00010213a7dc in > desktop::LibLODocument_Impl::~LibLODocument_Impl() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/desktop/source/lib/init.cxx:885 > #27 0x00010212cc2c in doc_destroy(_LibreOfficeKitDocument*) at > /Volumes/TML13/lo/ios-optimised-cp-6.0/desktop/source/lib/init.cxx:1471 > #28 0x0001006e4ccc in lok::Document::~Document() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/include/LibreOfficeKit/LibreOfficeKit.hxx:41 > #29 0x0001006e4c88 in lok::Document::~Document() at > /Volumes/TML13/lo/ios-optimised-cp-6.0/include/LibreOfficeKit/LibreOfficeKit.hxx:40 > #30 0x0001006e4a38 in > std::__1::default_delete::operator()(lok::Document*) const > [inlined] at > /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:2285 >
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #3 from Tor Lillqvist --- Looking at this now. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Moving to NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122544] Crash when tunneled dialog is open and document is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=122544 --- Comment #1 from Nicolas Christener --- Created attachment 148112 --> https://bugs.documentfoundation.org/attachment.cgi?id=148112=edit Crash after documents is closed while tunneled dialog is open -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
