[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021 Jim Raykowski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021 --- Comment #5 from Jim Raykowski --- Here is a purposed patch for review and comments: https://gerrit.libreoffice.org/#/c/67236/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021 Timur changed: What|Removed |Added URL||https://help.libreoffice.or ||g/6.3/en-US/text/shared/opt ||ionen/01110100.html --- Comment #4 from Timur --- (In reply to Katarina Behrens (CIB) from comment #0) > this is extremely minor so don't worry about it too much, right?! Not right. If "Press Cancel to cancel" doesn't really cancel, what in the world could we have confidence at. But there seems more to be in this bug if OK is pressed: - if Data series i.e. 10 is selected, on revisit Data series 1 is still selected. - if replacement colour in the palette selector on the right is changes, on revisit it's not. I may not understand how this is supposed to work (and some images in Help would be nice) but this doesn't look logical. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021 --- Comment #3 from Katarina Behrens (CIB) --- (In reply to Jim Raykowski from comment #2) > Whew! Didn't know if Katarina's comment in Additional Info was intended that > this should actually be fixed quickly. Ah nope, quite the contrary. It's not that my daily work would depend on formatting chart data series, I found this bug by accident. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021
--- Comment #2 from Jim Raykowski ---
Whew! Didn't know if Katarina's comment in Additional Info was intended that
this should actually be fixed quickly. I think it should be. So I jumped right
in trying to find how I introduced this bug. Could have saved myself some
stress by looking at the version (earliest affected) 6.0.7.3. This was way
before the palette selection patch I made was merged. :-)
Putting this one on the try to fix without breaking other things list.
For anyone that would like to try to fix this, here is where I was looking:
pChartOptions is always true here:
cui/source/options/optchart.cxx
void SvxDefaultColorOptPage::dispose()
{
// save changes
if (pChartOptions)
{
pChartOptions->SetDefaultColors( pColorConfig->GetColorList() );
pChartOptions->Commit();
pColorConfig.reset();
pChartOptions.reset();
}
...
}
Now off to try to fix something I did break :(
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123021] Cancel doesn't cancel in Tools > Options > Chart colours
https://bugs.documentfoundation.org/show_bug.cgi?id=123021 MM changed: What|Removed |Added Ever confirmed|0 |1 Version|6.3.0.0.alpha0+ Master |6.0.7.3 release Status|UNCONFIRMED |NEW --- Comment #1 from MM --- Confirmed on mint 19.1 with Version: 6.3.0.0.alpha0+ Build ID: 3424004cca7cb61043800f0ff0acc9de64768276 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-26_00:45:09 Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded Confirmed with Version: 6.0.7.3 Build ID: 1:6.0.7-0ubuntu0.18.04.2 CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
