[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5544

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |tietze.he...@gmail.com
   |.freedesktop.org|
 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Keywords|needsUXEval |

--- Comment #39 from Heiko Tietze  ---
Closing this issue as fixed. I filed bug 125544 as follow-up, please keep an
eye on the progress, Cor, so we can change the default later.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #38 from bugzil...@cb-computerservice.at ---
(In reply to Cor Nouws from comment #37)
> I reverted the patch. https://gerrit.libreoffice.org/#/c/61065/

Thanks for restoring the old behavior :) Just a pity we didn't get it in time
for 6.2.4 release...


(In reply to Heiko Tietze from comment #36)
> 3. Aligning numbers to the bottom just for formulas is bad.
> I don't see any reason to have some values at top and other at
> middle or bottom depending on number, date/time, or text
> and I'm not aware of a norm.

That  confused me too. Doesn't make any sense to me.


(In reply to Heiko Tietze from comment #36)
> we could inherit the default option into a document setting
> (Format > Page) and store it (wouldn't do that). Or we remove the
> alignment option completely (#3).

I think all options that have impact on formatting of a document should be
saved IN the document and not in a application setting. So moving this option
into the stylesheet was my first idea too. But, if no one can give a good
reason why the alignment option exists at all, removing it would be a lot
easier of course.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #37 from Cor Nouws  ---
Since reapplying the patch, after the issue is solved, is easy, I reverted the
patch. https://gerrit.libreoffice.org/#/c/61065/
This also allows to look at the other ideas / topic mentioned by Heiko.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Heiko Tietze  changed:

   What|Removed |Added

   Keywords|bibisectRequest |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Heiko Tietze  changed:

   What|Removed |Added

 CC||michael.st...@cib.de,
   ||rb.hensc...@t-online.de

--- Comment #36 from Heiko Tietze  ---
To summarize, we have these issues:

1. When opening existing documents the table content is realigned depending on
Tools > Options > Writer > Table (see c11) (this issue is relevant whether we
default to on or off since the user may change it manually but wouldn't expect
that just opening a document applies it)

2. The layout of newly inserted tables may differ if the option was changed
meanwhile (again, this is independent from the default).

3. Aligning numbers to the bottom just for formulas is bad. I don't see any
reason to have some values at top and other at middle or bottom depending on
number, date/time, or text and I'm not aware of a norm.

4. The hierarchy of Number Recognition and underlying items is wrong resp. not
respected in the code (as commented in c34, the disabled parent applies to the
children)


We should definitely solve #1. For #2 we could inherit the default option into
a document setting (Format > Page) and store it (wouldn't do that). Or we
remove the alignment option completely (#3). By doing this a single "[x] Number
Format Recognition" checkbox could be enough (and solves #4). 
The easiest but not the best solution for the regression is to revert the
patch, of course.

Any opinion, Regina, Michael?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #35 from Wolfgang Denk  ---
I tried all combinations of of settings for Number recognition / Number format
recognition / Alignment and could not find a setting that actually prevented
the horizontal alignment issue reported in Bug 125371l; this is in v6.2.3.2 (to
be exact: 6.2.3.2-1.fc30 in Fedora).

>From a user point of view this is clearly a bug, as you simply don't notice
when aligment of one or a few cells changes in a bigger table, eventually even
on the next page so you don't actually see it move.

*Please* fix!  Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Drew Jensen  changed:

   What|Removed |Added

 CC||drewjensen.in...@gmail.com

--- Comment #34 from Drew Jensen  ---
I tired running bibisect against this (for the duplicate issue) and couldn't
come up with a reasonable commit for where it came in, but I did not run
against the gap repo between 6.1 and 6.2, maybe it was during that time frame.
Though it looks like that isn't needed actually 

Just to agree with some folks here, it would seem reasonable that when Number
Recognition is disabled overall it should not matter if Alignment is selected
or null, and that is what I would call an anomaly.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Drew Jensen  changed:

   What|Removed |Added

 CC||w...@denx.de

--- Comment #33 from Drew Jensen  ---
*** Bug 125371 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Oliver Brinzing  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||5371

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #32 from Cor Nouws  ---
(In reply to bugzilla2 from comment #31)
> Can we have that in 6.2.4 RC2?
I'm not too familiar with that process and way too busy until Monday. @heiko:
can you help here please?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #31 from bugzil...@cb-computerservice.at ---
(In reply to Cor Nouws from comment #30)
> > I'd wish we can simply change the default options back to what they were
> I think that is best. And then later when import is changed, reapply.

Can we have that in 6.2.4 RC2?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #30 from Cor Nouws  ---
(In reply to bugzilla2 from comment #29)
> Btw, Number recognition can be left ON, its the "alignment"-switch that
And then have someone with formulas but without number formatting, seeing
changes maybe ;)

> causes the troubles (and I don't even know what it shall be good for).
Aligning numbers right is not uncommon.(In reply to bugzilla2 from comment #28)

> I'd wish we can simply change the default options back to what they were
I think that is best. And then later when import is changed, reapply.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #28 from bugzil...@cb-computerservice.at ---
I'd wish we can simply change the default options back to what they were before
6.2, so we can have a good 6.2.4 release. Thats the fast shot.

After that, it can be safely discussed how to make number-recognition on by
default, without breaking compatibility to existing documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

--- Comment #29 from bugzil...@cb-computerservice.at ---
Btw, Number recognition can be left ON, its the "alignment"-switch that causes
the troubles (and I don't even know what it shall be good for).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124860] FileOpen: Formula result has different alignment than regular values

2019-05-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124860

Cor Nouws  changed:

   What|Removed |Added

Version|6.2.2.2 release |6.2.0.3 release
   Keywords||regression
Summary|Formatting: Formula result  |FileOpen: Formula result
   |has different alignment |has different alignment
   |than regular values |than regular values

--- Comment #27 from Cor Nouws  ---
(In reply to bugzilla2 from comment #26)
> Thats because you replaced a formula value with a regular value. As noted in
> my initial report of the issue (and also in the outline), its about regular
> values and formula results getting different formatting with the new
> settings.
Got it. (Bit late, to be honest, but I think I've reasons to forgive myself for
that ;) ) Thanks for you patience!
I think the reason is clear: formula content of cells has to be evaluated on
opening the document.

Test: 
 - create old settings
 - open your file 
   > all as it was
 - change settings
 - File > Reload
   > changes are there.

So I guess this can be achieved: if Number Recognition is off, the other two
should not be evaluated. Not sure if it's easy (*). 
  ( @devs: any code pointers of where to look? )

If it won't be picked up (by me - agenda :( - or someone else) to change that,
I tend to say that the disadvantage of changing older files puts in more weight
than the advantage of a more logic default setting.

*) not to mention another possibility of storing table data on saving, as is
done with spreadsheets.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs