[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-12-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #10 from Mosin Motte  ---
Source - https://manchesterwebdesigncompany.co.uk/ios-iphone-app-development/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #9 from Andreas Gruhler  ---
(In reply to Tor Lillqvist from comment #7)
> After the above commits (which are also present in the branch from which the
> iOS app is built for the customer), empty lines or invalid URLs in the file
> no longer crash the app.
> 
> About error messages, should they really be displayed to the user? The end
> user can't do anything about it anyway. Would it be better to just NSLog
> them, so that a support person can see them using whatever tool they use?

On one hand, as long as an end user is able to modify this setting through the
UI and choose another template URL in the iOS-Settings, it makes sense to also
provide her the error message in case something goes wrong (maybe in a
simplified form).

On the other hand, if the template URL were a setting only accessible by an
admin or super-user, I'd rather not show it to an end user.

In any case, writing the errors to NSlog can be helfpul.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #8 from Andreas Gruhler  ---
(In reply to Tor Lillqvist from comment #3)
> It is btw not necessary to mention the thumbnails for the templates in the
> template list file. Just the template files. The names of the corresponding
> thumbnails are constructed automatically by appending .png.

Thank you for the tip, I did not know about this. Actually, is this setting for
the template URL already documented somewhere?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

Tor Lillqvist  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Tor Lillqvist  ---
After the above commits (which are also present in the branch from which the
iOS app is built for the customer), empty lines or invalid URLs in the file no
longer crash the app.

About error messages, should they really be displayed to the user? The end user
can't do anything about it anyway. Would it be better to just NSLog them, so
that a support person can see them using whatever tool they use?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #5 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/d550944053cca481e3bae1e981b16a23132c0126%5E%21

tdf#124918: More logging in template download error situations

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #4 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/4e2ad4d2bc018584c074d91b6d5927c5c2b905bf%5E%21

tdf#124918: Allow empty lines in the template list file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #6 from Commit Notification 
 ---
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/+/db9208d36417490ea1a0a536c701233279a49e0d%5E%21

tdf#124918: Don't crash on invalid URLs in the template list file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #3 from Tor Lillqvist  ---
It is btw not necessary to mention the thumbnails for the templates in the
template list file. Just the template files. The names of the corresponding
thumbnails are constructed automatically by appending .png.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #2 from Andreas Gruhler  ---
We just discovered the problem about the second url,
https://tpl.dev.base4kids2.ch/tpl_de_ch/00_index.txt, which is fixed by now:

There was an empty line at the end of the file, which lead to the crash. To
summarize, index files cannot contain:
* empty lines
* umlauts (ä,ö,ü)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124918] iOS App Crashes with Invalid Template URL

2019-04-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124918

--- Comment #1 from Andreas Gruhler  ---
Video too big for upload, is on:
https://cloud.dev.base4kids2.ch/index.php/s/5SGqzPmjossRFiD

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs