[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 --- Comment #9 from Wolfgang Jäger --- (In reply to Mike Kaganski from comment #6) > We actually do create a new object each time a range object is requested > (see e.g. ScTableSheetsObj::GetObjectByIndex_Impl[1], which implements > functionality of XIndexAccess::getByIndex). So at least in case of range > objects (which have their range read-only, thus for all uses should be > considered "same" when refer to same range), ... ... we need some special casing to > check if they are objects of the same type (e.g., one could be "sheet", and > the other "all cells, but not sheet", ... ... and these are different objects), and > then refer to the same range. > > https://git.libreoffice.org/core/+/1c3eb7e329cd2eaeb83068907ba0c9a5b3ef7852/ > sc/source/ui/unoobj/docuno.cxx#3577 Thanks. I can't start to study and analyze the complex C++ code (I never understood sufficiently nor ever liked). As a frequent user of the API I would, however, expect that things are consistent to a degree allowing for a sufficient understanding either by a kind of self-explanation and educated reasoning or by well structured documentation. That there are objects of different types in a sense as underlying the above example without giving the user reliable information about it is just confusion, imo. I'm told that only service names are assured to be stable. OK. But if so there must be a service helping to distinguish "different object types" in every case. Otherwise implementation names must get assured stability, and must be applied in a way offering the mentioned functionality. Also a kind of bundling or "merging" services in a way that results in facts like EqualUNOobjects(cellObject, cellObject.Text)=True (same "object type"?) is evil if not at least there are reliable means to make the needed distinctions in a different way. An API will always partly be useless or create errors if its usage requires full understanding of the core code. If "object types" are actually defined by their BUNDLING of services, these types must have stable names, and their bundling (including the surprising "identities") must be documented. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 --- Comment #8 from Wolfgang Jäger --- Checked with V 7.5.3.2 under Win10 Behaviour unchanged. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107659 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 --- Comment #6 from Mike Kaganski --- We actually do create a new object each time a range object is requested (see e.g. ScTableSheetsObj::GetObjectByIndex_Impl[1], which implements functionality of XIndexAccess::getByIndex). So at least in case of range objects (which have their range read-only, thus for all uses should be considered "same" when refer to same range), we need some special casing to check if they are objects of the same type (e.g., one could be "sheet", and the other "all cells, but not sheet", and these are different objects), and then refer to the same range. https://git.libreoffice.org/core/+/1c3eb7e329cd2eaeb83068907ba0c9a5b3ef7852/sc/source/ui/unoobj/docuno.cxx#3577 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Oliver Brinzing changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6487 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 --- Comment #5 from Wolfgang Jäger --- You may also have a glance at a related post in a forum where sometimes actual discussion occurs: https://forum.openoffice.org/en/forum/viewtopic.php?f=20=98435 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 --- Comment #4 from Oliver Brinzing --- Created attachment 151602 --> https://bugs.documentfoundation.org/attachment.cgi?id=151602=edit EqualUnoObjects - working example with controls adding a working example, searching a control on drawpage -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Wolfgang Jäger changed: What|Removed |Added CC||j...@psilosoph.de --- Comment #3 from Wolfgang Jäger --- I should subjoin that even the expression EqualUnoObjects(ThisComponent.Sheets.GetByIndex(0), ThisComponent.Sheets.GetByIndex(0)) will return False. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421
Julien Nabet changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #2 from Julien Nabet ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Since in this part:
3171 if( x1 == x2 )
3172 {
3173 refVar->PutBool( true );
3174 }
x1 isn't considered as == to x2, refVar stays at false.
Now I don't know how to fix this or if we should fix this.
Indeed, I suppose it may have impacts on existing macros.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125421] The Basic function EqualUnoObjects wrongly returns False for two variables having assigned the same object by different ways of access.
https://bugs.documentfoundation.org/show_bug.cgi?id=125421 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Code pointer: https://opengrok.libreoffice.org/xref/core/basic/source/classes/sbunoobj.cxx?r=fbc038cc#3118 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
