[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #14 from Xisco Faulí --- Verified in Version: 6.4.0.0.alpha0+ Build ID: ed2107f047528d8e49135d3270705f389ed5 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Julien Nabet, Thanks for fixing this issue! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Julien Nabet changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #13 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/fa088732e195500d1e50318d7c88a46e73a307ea%5E%21 tdf#126004: test EditShell is ok before calling ValidateAllParagraphSignatures It will be available in 6.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #12 from Ashod Nakashian --- Looks good to me. Merged. Thanks Julien. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #11 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/12252f27d108402df02a298bbe1b6e8f290b34d7%5E%21 tdf#126004: test EditShell is ok before calling ValidateAllParagraphSignatures It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #10 from Julien Nabet --- (In reply to Julien Nabet from comment #9) > (In reply to Xisco Faulí from comment #8) > > ... > > > > @Julien, Could you please submit a patch to gerrit so others can review it ? > No pb, I'll be able to do it after my daytime job. Done here: https://gerrit.libreoffice.org/#/c/74714/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #9 from Julien Nabet --- (In reply to Xisco Faulí from comment #8) > ... > > @Julien, Could you please submit a patch to gerrit so others can review it ? No pb, I'll be able to do it after my daytime job. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #8 from Xisco Faulí --- (In reply to Julien Nabet from comment #5) > With this patch, it doesn't crash > diff --git a/sw/source/core/doc/DocumentTimerManager.cxx > b/sw/source/core/doc/DocumentTimerManager.cxx > index 266ee7386875..f13a25559f1f 100644 > --- a/sw/source/core/doc/DocumentTimerManager.cxx > +++ b/sw/source/core/doc/DocumentTimerManager.cxx > @@ -200,7 +200,8 @@ IMPL_LINK_NOARG( DocumentTimerManager, DoIdleJobs, > Timer*, void ) > m_rDoc.getIDocumentFieldsAccess().UpdateRefFields(); // References > > // Validate and update the paragraph signatures. > -m_rDoc.GetEditShell()->ValidateAllParagraphSignatures(true); > +if (m_rDoc.GetEditShell()) > +m_rDoc.GetEditShell()->ValidateAllParagraphSignatures(true); > > pTmpRoot->EndAllAction(); > but as always, is it a real fix or am I just hiding the root cause. @Julien, Could you please submit a patch to gerrit so others can review it ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Xisco Faulí changed: What|Removed |Added Version|6.4.0.0.alpha0+ Master |6.3.0.0.alpha0+ CC||xiscofa...@libreoffice.org OS|Windows (All) |All --- Comment #7 from Xisco Faulí --- Also reproducible on linux -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #6 from Julien Nabet --- Also I noticed a lot of these 2 kinds of logs: warn:legacy.osl:15258:15258:sw/source/core/txtnode/swfont.cxx:428: Unsupported direction warn:sw.core:15258:15258:sw/source/core/txtnode/swfont.cxx:407: unsupported direction for VertLRBT but that's another story -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 --- Comment #5 from Julien Nabet --- With this patch, it doesn't crash diff --git a/sw/source/core/doc/DocumentTimerManager.cxx b/sw/source/core/doc/DocumentTimerManager.cxx index 266ee7386875..f13a25559f1f 100644 --- a/sw/source/core/doc/DocumentTimerManager.cxx +++ b/sw/source/core/doc/DocumentTimerManager.cxx @@ -200,7 +200,8 @@ IMPL_LINK_NOARG( DocumentTimerManager, DoIdleJobs, Timer*, void ) m_rDoc.getIDocumentFieldsAccess().UpdateRefFields(); // References // Validate and update the paragraph signatures. -m_rDoc.GetEditShell()->ValidateAllParagraphSignatures(true); +if (m_rDoc.GetEditShell()) +m_rDoc.GetEditShell()->ValidateAllParagraphSignatures(true); pTmpRoot->EndAllAction(); but as always, is it a real fix or am I just hiding the root cause. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- Created attachment 152295 --> https://bugs.documentfoundation.org/attachment.cgi?id=152295=edit bt with debug symbols (gtk3) On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||ashodnakash...@yahoo.com --- Comment #3 from raal --- This seems to have begun at the below commit. Adding Cc: to Ashod Nakashian ; Could you possibly take a look at this one? Thanks 30cd613ce80a70bb15bc8f67e983a1e68854c274 is the first bad commit commit 30cd613ce80a70bb15bc8f67e983a1e68854c274 Author: Norbert Thiebaud Date: Thu Jan 3 10:26:45 2019 -0800 source sha:5d6102ce297f12a81e1d21b4ffc9df1d97d0b847 author Ashod Nakashian2018-10-03 05:53:28 -0400 committer Ashod Nakashian2019-01-03 19:12:07 +0100 commit 5d6102ce297f12a81e1d21b4ffc9df1d97d0b847 (patch) treececcb733e926c69d9ef75fe078c6f28ba6a3e2b4 parent dd2972d4c323afddc1eca90c88fe6240f40685dd (diff) sw: paragraph-sign: process signatures in one pass on loading -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression --- Comment #2 from Telesto --- No repro with Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||r...@post.cz --- Comment #1 from raal --- I can confirm with Version: 6.3.0.0.beta1+ (x86) Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126004] Crash swlo!SwEditShell::ValidateAllParagraphSignatures
https://bugs.documentfoundation.org/show_bug.cgi?id=126004 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8392 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
