[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 Kevin Suo changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |l.lu...@collabora.com |desktop.org | --- Comment #11 from Kevin Suo --- Proposed pach by Luboš Luňák: https://gerrit.libreoffice.org/c/core/+/86750 Thanks a lot, I am building and testing. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 --- Comment #10 from Luboš Luňák --- You're right, the one call ignores the return value, my mistake. Does doing this change https://pastebin.com/4ShVezNR also fix the problem for you? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 --- Comment #9 from Kevin Suo --- (In reply to Luboš Luňák from comment #8) It is the following function which caused this bug: SvtScriptType ScDocument::GetCellScriptType Specifically, it is related to OUString aStr. The bug is gone if I use back the following code: OUString aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, , *mxPoolHelper->GetFormTable()); and remove those lines added by that commit. I see the main difference between these two version is, previously the aStr is assigned a value: OUString aStr = ScCellFormat::GetString but in the new one, aStr is never assigned a value, but rather it is directly used in cCellFormat::GetString call, while the nRet still uses aStr as an arg. Is this correct? I am not familiar with c++ anyway. I added a std::cout and then print the value of aStr - With the bug code, aStr is always blank (none?) when I type in text in the cell. With the old code, aStr is correctly showing the text I type in. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 --- Comment #8 from Luboš Luňák --- The only place where I can see those two commits to possibly affect this is https://cgit.freedesktop.org/libreoffice/core/diff/sc/source/core/data/documen6.cxx?id=6f810e3d7dafcd7d0101173a501786226f4d8886 . If you want to debug that, I suggest trying to revert the changes in either of those two functions and seeing what happens, and then possibly debugging why the functions called from there behave differently even though they shouldn't. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 Kevin Suo changed: What|Removed |Added Keywords||bisected --- Comment #7 from Kevin Suo --- I compiled the source code with debug and dbgutil enabled. Good in: 0d58f51d7672c569c93c6e814dbfffa586eebfb7 2019-05-16 12:33:16 +0200 Build error in the following commit ((Ubuntu 18.04 LTS), ignored: ace16e500c92797bb47ad580cf535de0702137bd 2019-05-16 12:34:42 +0200 Bad in: 6f810e3d7dafcd7d0101173a501786226f4d8886 2019-05-16 12:34:51 +0200 The output message in terminal for both the good and bad commits are identical, so it may not be useful. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126248] Calc 6.3: Asian Font is Wrongly Applied to Western Text
https://bugs.documentfoundation.org/show_bug.cgi?id=126248 Kevin Suo changed: What|Removed |Added Summary|Asian Font is Wrongly |Calc 6.3: Asian Font is |Applied to Western Text |Wrongly Applied to Western ||Text --- Comment #6 from Kevin Suo --- This is a disaster. We are not able to work in Calc with Simplified Chinese locale with the 6.3+ version. Could someone investigate? I can help to debug on master with a debug build if needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
