[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Xisco Faulí changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7610 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Commit Notification changed: What|Removed |Added Whiteboard|target:6.4.0|target:6.4.0 target:6.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #12 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/6e12c2f0f59fb191924df44e1214640a2c3d781d%5E%21 tdf#126266 adjust calculations for invisble tabs It will be available in 6.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Jan-Marek Glogowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #11 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/d55654fa962002b2f78b44a01dc4aa25428b1ca2%5E%21 tdf#126266 adjust calculations for invisble tabs It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #10 from andreas_k --- ok if there is something I can improve in the notebookbar.ui file, please let me know. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #9 from Xisco Faulí --- (In reply to andreas_k from comment #8) > as you have beta 1 and rc1 installed can you copy the notebookbar.ui file > from writer/calc/impress/draw whatever from b1 to rc1 folder? cause than we > would know if it's an issue in the notebookbar.ui file change between b1 and > rc1 or somewhere else (I think the issue come from somewhere else) Jmux has already a patch in gerrit < https://gerrit.libreoffice.org/#/c/75230/3 > no need to check it -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #8 from andreas_k --- as you have beta 1 and rc1 installed can you copy the notebookbar.ui file from writer/calc/impress/draw whatever from b1 to rc1 folder? cause than we would know if it's an issue in the notebookbar.ui file change between b1 and rc1 or somewhere else (I think the issue come from somewhere else) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||107237 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107237 [Bug 107237] [META] Notebookbar Tabbed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #7 from Xisco Faulí --- Conversation from IRC: jmux, removing this if < https://opengrok.libreoffice.org/xref/core/vcl/source/control/tabctrl.cxx?r=d00ee2cb#2352 > displays the menu the strange part is, that even the "Applications" folder menu name is translated... en_it? x1sc0: you mean the tabs? jmux, yep, sorry, the tabs x1sc0: the only place, which can change the visibility is NotebookbarTabControlBase::SetContext * individual-it (~Thunderbi@27.34.70.174) s'ha unit jmux, should it be m_bEnabled instead ? x1sc0: no. That was the old code and it was broken. Any it works everywhere else. And @mirkoprp why do you have en_IT.UTF-8 in the locale? x1sc0: Can you put a SAL_DEBUG(nPageId << " " << bVisible); at the start of TabControl::SetPageVisible @mirkoprp what if you launch LibreOffice in safe mode? https://wiki.documentfoundation.org/UserProfile#Resolving_corruption The menu location is different on macos * floeff ha sortit (Quit: Bye.) * xisco2 (b9d8dafb@gateway/web/cgi-irc/kiwiirc.com/ip.185.216.218.251) s'ha unit jmux, https://paste.ee/p/WSlvA * MechtiIde ha sortit (Ping timeout: 258 seconds) xisco2: that looks ok. You should see tabs 1-7 + 15 xisco2: Can you move the debug 4 lines and make it SAL_DEBUG(nPageId << " " << bVisible << " " << pItem << " " << pItem->m_bVisible); after the return jmux https://paste.ee/p/x2nKD This is very strange. From the debug output the right tabs are visible. Just the hidden tabs get hidden. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #6 from Martin Srebotnjak --- Andreas, it is a problem with Calc, Impress etc. as well. As well as with the tabbed compact. Unusable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #5 from andreas_k --- Writer only or also in calc, draw, impress There is new tabbed compact. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #4 from Jan-Marek Glogowski --- (In reply to Xisco Faulí from comment #3) > Regression introduced by: > > authorJan-Marek Glogowski 2019-06-16 21:41:31 > + > committer Jan-Marek Glogowski 2019-06-22 20:02:08 > +0200 > commit9f53774b1f177b99317b90d756ea8fe9c7930d73 (patch) > tree a74f4f275416846b239b809453a8d5de7f35a392 > parent5bd5894379fc9b89958b31db8caf96d13cae86d7 (diff) > VCL merge most of NotebookbarTabControlBase > > Bisected with: bibisect-mac64-6.3 > > Adding Cc: to Jan-Marek Glogowski Hmm - I was expecting the bug to be in the later patch to fix bug 105884. Problem is I don't have a Mac. I'll see if I can spot something in the patch, but it was a large refactoring and other patches depend on it, so there is no real option to revert it. What a mess :-( -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Xisco Faulí changed: What|Removed |Added CC||glo...@fbihome.de, ||xiscofa...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisected, bisected, ||regression --- Comment #3 from Xisco Faulí --- Regression introduced by: author Jan-Marek Glogowski 2019-06-16 21:41:31 + committer Jan-Marek Glogowski 2019-06-22 20:02:08 +0200 commit 9f53774b1f177b99317b90d756ea8fe9c7930d73 (patch) treea74f4f275416846b239b809453a8d5de7f35a392 parent 5bd5894379fc9b89958b31db8caf96d13cae86d7 (diff) VCL merge most of NotebookbarTabControlBase Bisected with: bibisect-mac64-6.3 Adding Cc: to Jan-Marek Glogowski -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 Martin Srebotnjak changed: What|Removed |Added Priority|medium |high CC||kain...@gmail.com, ||tima...@gmail.com Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #1 from Martin Srebotnjak --- Created attachment 152617 --> https://bugs.documentfoundation.org/attachment.cgi?id=152617=edit No tabs in 6.3 RC1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126266] LO63rc1: on macOS in Writer's tabbed notebookbar mode the tabs are missing/non switchable
https://bugs.documentfoundation.org/show_bug.cgi?id=126266 --- Comment #2 from Martin Srebotnjak --- Created attachment 152618 --> https://bugs.documentfoundation.org/attachment.cgi?id=152618=edit Tabs available in 6.3 b1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
