[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #12 from Telesto --- (In reply to Xisco Faulí from comment #11) > (In reply to Jan-Marek Glogowski from comment #10) > > This is not fixed. Disabling a unit test is no fix! I'm not sure that having > > an open bug will help fixing the underlying problem, but personally I would > > just leave it open. > > I agree. The summary needs to be adapted though Also the status: resolved fixed not to ideal either :D -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #11 from Xisco Faulí --- (In reply to Jan-Marek Glogowski from comment #10) > This is not fixed. Disabling a unit test is no fix! I'm not sure that having > an open bug will help fixing the underlying problem, but personally I would > just leave it open. I agree. The summary needs to be adapted though -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #10 from Jan-Marek Glogowski --- This is not fixed. Disabling a unit test is no fix! I'm not sure that having an open bug will help fixing the underlying problem, but personally I would just leave it open. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #9 from Alex Thurgood --- Fixed in the sense that I can at least get a completed build ;-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 Alex Thurgood changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Alex Thurgood --- Thanks to everyone for their input and for fixing this ! Closing as RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #7 from Alex Thurgood --- (In reply to Xisco Faulí from comment #6) > @Alex, Could you please try to build again including Julien's commit ? Sure, when I'm next in front of my build machine, later on this week. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 --- Comment #6 from Xisco Faulí --- @Alex, Could you please try to build again including Julien's commit ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #5 from Commit Notification --- Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/236593a0544ea41e37d35b8fac83b31d0e7c5b67%5E%21 tdf#126559: vcl_pdfexport unit test failure It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 Commit Notification changed: What|Removed |Added Whiteboard||target:6.4.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559
--- Comment #4 from Jan-Marek Glogowski ---
(In reply to Julien Nabet from comment #2)
> Jan-Marek: I noticed 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be which has
> enabled testTdf107868 for MacOS whereas there was:
> "FIXME: Why does this fail on macOS?"
> Any thoughts here? Should we put avoid to test this one on MacOS for the
> moment?
As I wrote in my mail to the dev-list:
Weitergeleitete Nachricht
Betreff: Re: vcl_pdfexport test failing on master with MacOS
Datum: Mon, 22 Jul 2019 16:59:53 +0200
Von: Jan-Marek Glogowski
An: libreoff...@lists.freedesktop.org
Am 22.07.19 um 13:16 schrieb Alexander Thurgood:
> Test name : (anonymous namespace)::PdfExportTest::testTdf107868
> pdfexport.cxx:668 (anonymous namespace)::PdfExportTest:testSoftHyphenPos
Not AFAIK. But I enabled many tests in commit 3f7e8ddea89f ("Enable many more
unit tests on all archs"). These were included and had a "// FIXME: Why does
this fail on macOS?" in front of the #ifndef. If you can't debug the problem,
you might want to re-disable these on MACOSX. Jenkins and tinderboxes seemed to
be fine.
Jan-Marek
P.S.:
> As from today, or at earliest from Thurs or Fri last week,
commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
Author: Jan-Marek Glogowski
Date: Tue Jun 25 19:56:13 2019 +
Enable many more unit tests on all archs
That doesn't match your claimed dates, so probably something really broke just
now. Maybe bisect?
and:
Weitergeleitete Nachricht
Betreff: Re: vcl_pdfexport test failing on master with MacOS
Datum: Mon, 22 Jul 2019 17:18:58 +0200
Von: Jan-Marek Glogowski
An: libreoff...@lists.freedesktop.org
Replying to myself, as the commit was a bit later:
Am 22.07.19 um 16:59 schrieb Jan-Marek Glogowski:
> commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be
> Author: Jan-Marek Glogowski
> Date: Tue Jun 25 19:56:13 2019 +
>
> Enable many more unit tests on all archs
>
Commit: Jan-Marek Glogowski
CommitDate: Fri Jul 5 20:05:59 2019 +0200
Still more then a few days ago.
I can't investigate or fix this, so decide whatever you want to do.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #3 from Julien Nabet --- There's also this failing test: PdfExportTest::testSofthyphenPos /Users/Shared/LO/core/vcl/qa/cppunit/pdfexport/pdfexport.cxx:668:(anonymous namespace)::PdfExportTest::testSofthyphenPos double equality assertion failed - Expected: 11.05 - Actual : 1 - Delta : 1e-06 Delta is quite strange... This test has also been reenabled for MacOS in the same commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 Julien Nabet changed: What|Removed |Added CC||glo...@fbihome.de, ||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- Jan-Marek: I noticed 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be which has enabled testTdf107868 for MacOS whereas there was: "FIXME: Why does this fail on macOS?" Any thoughts here? Should we put avoid to test this one on MacOS for the moment? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126559] vcl_pdfexport unit test failure
https://bugs.documentfoundation.org/show_bug.cgi?id=126559 --- Comment #1 from Alex Thurgood --- Created attachment 152998 --> https://bugs.documentfoundation.org/attachment.cgi?id=152998=edit Build output -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
