[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED CC||xiscofa...@libreoffice.org Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #10 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/137574 Heiko/Xisco: perhaps you'd be interested in this one since it's related to UI part. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754
--- Comment #9 from Julien Nabet ---
It seems we're already distinguish both cases here:
140 bool FeatureCollector::collect()
141 {
142 gr_face* grFace = hb_graphite2_face_get_gr_face(m_pHbFace);
143
144 if (grFace)
145 {
146 return collectGraphite();
147 }
148 else
149 {
150 collectForTable(HB_OT_TAG_GSUB); // substitution
151 collectForTable(HB_OT_TAG_GPOS); // positioning
152 return true;
153 }
154 }
the test is exactly the same as here:
146 bool LogicalFontInstance::IsGraphiteFont()
147 {
148 if (!m_xbIsGraphiteFont)
149 {
150 m_xbIsGraphiteFont =
hb_graphite2_face_get_gr_face(hb_font_get_face(GetHbFont())) != nullptr;
151 }
152 return *m_xbIsGraphiteFont;
153 }
in vcl/source/font/fontinstance.cxx
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754
--- Comment #8 from Julien Nabet ---
Thank you for the feedback.
Here's a bt:
#0 vcl::font::FeatureCollector::collectForLanguage(unsigned int, unsigned int,
unsigned int, unsigned int, unsigned int)
(this=0x7fff08fa5690, aTableTag=1196643650, nScript=0,
aScriptTag=1145457748, nLanguage=65535, aLanguageTag=1684434036) at
vcl/source/font/FeatureCollector.cxx:105
#1 0x7f1808285efa in
vcl::font::FeatureCollector::collectForScript(unsigned int, unsigned int,
unsigned int) (this=0x7fff08fa5690, aTableTag=1196643650, nScript=0,
aScriptTag=1145457748)
at vcl/source/font/FeatureCollector.cxx:115
#2 0x7f18082861c3 in vcl::font::FeatureCollector::collectForTable(unsigned
int) (this=0x7fff08fa5690, aTableTag=1196643650) at
vcl/source/font/FeatureCollector.cxx:137
#3 0x7f180828629c in vcl::font::FeatureCollector::collect()
(this=0x7fff08fa5690) at vcl/source/font/FeatureCollector.cxx:150
#4 0x7f1807ae11aa in
OutputDevice::GetFontFeatures(std::__debug::vector >&) const
(this=0xab9ae30, rFontFeatures=std::__debug::vector of length 1, capacity
1 = {...}) at vcl/source/outdev/font.cxx:174
#5 0x7f17b5893835 in getFontFeatureList(rtl::OUString const&,
VirtualDevice&) (rFontName="Liberation Serif", rVDev=...) at
cui/source/util/FontFeatures.cxx:23
#6 0x7f17b544f50c in cui::FontFeaturesDialog::initialize()
(this=0x7fff08fa5b78) at cui/source/dialogs/FontFeaturesDialog.cxx:54
#7 0x7f17b544f2c0 in
cui::FontFeaturesDialog::FontFeaturesDialog(weld::Window*, rtl::OUString)
(this=0x7fff08fa5b78, pParent=0xa055768, aFontName="") at
cui/source/dialogs/FontFeaturesDialog.cxx:29
I also noticed:
20 OpenTypeFeatureDefinitionListPrivate& OpenTypeFeatureDefinitionList()
21 {
22 static OpenTypeFeatureDefinitionListPrivate SINGLETON;
23 return SINGLETON;
24 };
(see
https://opengrok.libreoffice.org/xref/core/vcl/source/font/OpenTypeFeatureDefinitionList.cxx?r=85d15cfa#23)
Let's keep digging...
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 --- Comment #7 from Caolán McNamara --- I don't really know the dialog and feature. Would it work to just offer two different views of this depending on IsGraphiteFont(), the current view when that's true and another when its false to address this. I see that using literal Sukhumala:afrc Sukhumala:afrc Sukhumala:frac give me three different things, so maybe for !IsGraphite() the Fraction and Alternative Fraction should just be checkboxes. I don't think we have to too concerned about backwards compat here(?) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Julien Nabet changed: What|Removed |Added CC||caol...@redhat.com --- Comment #6 from Julien Nabet --- About "afrc", LO displays "Alternative (Vertical) Fractions" at top left of the screenshot. (I suppose the name comes from https://docs.microsoft.com/en-us/typography/opentype/spec/features_ae). https://en.wikipedia.org/wiki/List_of_typographic_features indicates: Fractions fracS4 Converts figures separated by slash with diagonal fraction Alternative Fractions afrcS4 Converts figures separated by slash with alternative stacked fraction form In addition to be able to distinguish Opentype tags and Graphite tags, another pb will be to not break config on existing files, what a mess... Caolán: perhaps you may have some thoughts since it concerns vcl part (vcl/source/font/FeatureCollector.cxx + vcl/source/font/OpenTypeFeatureDefinitionList.cxx). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2242 CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet --- Just for information, there's frac=0 (so with None) since 7.0.0 (see tdf#132242). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Dieter Praas changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from Dieter Praas --- (In reply to Tobias Hemm from comment #3) > What RGB stated is absolutely correct. => Status NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 --- Comment #3 from Tobias Hemm --- What RGB stated is absolutely correct. I am about to file a bug/enhancement report regarding OpenType features, and have, in that course, found out that a newer version already contains a GUI implementation of them. So I have updated LO and tested the features. And it is true: The fractions feature uses a wrong code (frac=1). Furthermore, the default value is "diagonal", which doesn’t make sense. This is a feature that should not be turned on by default. Instead, there should be three values: "none", "diagonal" and "stacked". (Please see my other report to see how I would implement it graphically.) The code for "diagonal" would be "frac"; the code for "stacked" would be "afrc". And I wouldn’t call the latter "nut" – that’s nuts. At the moment, if I select the "nut fractions", what is created are diagonal fractions. As stated above, the default value is "diagonal", which creates no fractions at all. But, guys, you are awesome to implement this, at all. We will certainly get it to work properly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC|libreoffice-ux-advise@lists |dr.khaled.ho...@gmail.com, |.freedesktop.org|heiko.tietze@documentfounda ||tion.org --- Comment #2 from Heiko Tietze --- Don't see need for UX input (besides the UI, which is a different topic). Please add the keyword again if input is needed. Khaled, what do you think about the issue? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126754] FONT FEATURES DIALOG: Wrong OpenType tag for fractions in "font features" dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=126754 Dieter Praas changed: What|Removed |Added Blocks||108734 Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Summary|Wrong OpenType tag for |FONT FEATURES DIALOG: Wrong |fractions in "font |OpenType tag for fractions |features" dialog|in "font features" dialog Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108734 [Bug 108734] [META] Character dialog bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
