[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #9 from Julien Nabet  ---
(In reply to Stephan Bergmann from comment #7)
> ...
> See above.  Looks like you didn't follow all those steps that are required
> to edit a new macro?
> ...
Yes I saw this on Win10, I wanted to retest tonight on my Linux computer

> > + warnings on console just before when creating the macro
> 
> Those are apparently only warnings for now (i.e., with Java 11, and also
> tested now with OpenJava 12.0.2 where it's still only a warning).  That
> leaves us some more time to come up with a fix eventually.  :)
Yes and when 6.3 will be EOL, we'll be able to deal with Java from 1.8 instead
of 1.6

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #8 from Oliver Brinzing  ---
(In reply to Julien Nabet from comment #6)
> Now the problem is I don't know how to use this class since import don't
> work.
> I searched how to import to avoid all the introspection stuff (it's quite
> ugly and I suppose it doesn't help for speed) but failed.

maybe something like this can help:

import java.io.StringWriter;

import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;

import org.w3c.dom.DOMConfiguration;
import org.w3c.dom.DOMImplementation;
import org.w3c.dom.DOMStringList;
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.ls.DOMImplementationLS;
import org.w3c.dom.ls.LSOutput;
import org.w3c.dom.ls.LSSerializer;

public class LSSerialize {

public static void main(String[] args) throws Exception {

DocumentBuilderFactory factory =
DocumentBuilderFactory.newInstance();
DocumentBuilder builder = factory.newDocumentBuilder();
Document document = builder.newDocument();

Node n = document.appendChild(document.createElement("Hello"));
n.appendChild(document.createElement("World"));

DOMImplementation impl = document.getImplementation();
DOMImplementationLS implLS = (DOMImplementationLS)
impl.getFeature("LS", "3.0");
LSSerializer dsi = implLS.createLSSerializer();

DOMConfiguration dc = dsi.getDomConfig();

DOMStringList params = dc.getParameterNames();
for (int i = 0; i < params.getLength(); i++) {
System.out.println(params.item(i));
}

dc.setParameter("well-formed", true);
dc.setParameter("format-pretty-print", true);
dc.setParameter("xml-declaration", true);

LSOutput lsOutput = implLS.createLSOutput();
lsOutput.setEncoding("UTF-8");

StringWriter stringWriter = new StringWriter();
lsOutput.setCharacterStream(stringWriter);
dsi.write(document, lsOutput);
System.out.println("\n" + stringWriter.toString());

}
}

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #7 from Stephan Bergmann  ---
(In reply to Julien Nabet from comment #0)
> Steps to Reproduce:
> 1. Launch LO
> 2. Tools/Macros/Organize Macros/BeanShell...
> 3. Select "Untitled 1" doc + click "Create..."

...which opens a "Create Library" dialog that asks for a name, with "Library1"
already suggested, so press "OK"; then click on the triangle to the left of
"Untitled 1" to expand it, then click on "Library1", then click "Create..."
which opens a "Create Macro" dialog that asks for a name, with "Macro1" already
suggested, so press "OK"; then click on the triangle to the left of "Library1"
to expand it, then click on "Macro1.bsh", then click on "Edit" which is now
enabled.

> The macro seems created but logs quoted display
> 
> click on the macro
> 
> Actual Results:
> "Edit" button is disabled

See above.  Looks like you didn't follow all those steps that are required to
edit a new macro?

> + warnings on console just before when creating the macro

Those are apparently only warnings for now (i.e., with Java 11, and also tested
now with OpenJava 12.0.2 where it's still only a warning).  That leaves us some
more time to come up with a fix eventually.  :)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #6 from Julien Nabet  ---
(In reply to Julien Nabet from comment #5)
> I'm not sure but it seems that with LSSerializer, we can avoid using
> formatterClass and just keep serializerClass. Perhaps we can remove the
> try/catch and avoid the introspection and plainly use LSSerializer.
I meant "LSSerializerImpl" since "LSSerializer" is just an interface.

Now the problem is I don't know how to use this class since import don't work.
I searched how to import to avoid all the introspection stuff (it's quite ugly
and I suppose it doesn't help for speed) but failed.

I must recognize I'm stuck.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #5 from Julien Nabet  ---
I'm not sure but it seems that with LSSerializer, we can avoid using
formatterClass and just keep serializerClass. Perhaps we can remove the
try/catch and avoid the introspection and plainly use LSSerializer.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

--- Comment #4 from Julien Nabet  ---
(In reply to Oliver Brinzing from comment #3)
> ...
> IMHO the XMLSerializer class instantiation via introspection has to be
> replaced, cause Java 9 does not allow it anymore.

It seems LSSerializer may be used even with Java6,
https://www.doc.ic.ac.uk/csg-old/java/jdk6docs/api/org/w3c/dom/ls/LSSerializer.html

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

Oliver Brinzing  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #3 from Oliver Brinzing  ---
reproducible with:

Version: 6.4.0.0.alpha0+ (x64)
Build ID: 082e95f684e44954275dc58e306b8dc69590ac80
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-US
Calc: threaded

IMHO the XMLSerializer class instantiation via introspection has to be
replaced, cause Java 9 does not allow it anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

Julien Nabet  changed:

   What|Removed |Added

 CC||sberg...@redhat.com

--- Comment #2 from Julien Nabet  ---
code pointer:
https://opengrok.libreoffice.org/xref/core/scripting/java/com/sun/star/script/framework/container/XMLParserFactory.java?r=0063cf28#113

Olivier: you're right but we got to deal with Java versions.

Stephan: I re read https://www.libreoffice.org/get-help/system-requirements/,
if 
Java is indicated as prerequisite for Base mainly, minimum version isn't
indicated.
Searching in git history, I found your commit
https://cgit.freedesktop.org/libreoffice/core/commit/?id=aafc10c9edb61e13ac557c7e43c8d4a31dce4f37.
If I well understood, until 6.3 included, min Java version would be 1.6 and
from future 6.4.0, it'll be 1.8
Any idea about a mechanism to deal from Java 6 until OpenJDK 11?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

Oliver Brinzing  changed:

   What|Removed |Added

 CC||oliver.brinz...@gmx.de

--- Comment #1 from Oliver Brinzing  ---
seems, com.sun.org.apache.xml.internal.serialize.OutputFormat is deprecated:

https://java-browser.yawk.at/java/10/java.xml/com/sun/org/apache/xml/internal/serialize/OutputFormat.java#com.sun.org.apache.xml.internal.serialize.OutputFormat

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 127015] Warnings + Edit button disabled with Beanshell + OpenJdk11

2019-08-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127015

Julien Nabet  changed:

   What|Removed |Added

Summary|Warning with Beanshell +|Warnings + Edit button
   |OpenJdk11   |disabled with Beanshell +
   ||OpenJdk11

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs