[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

Caolán McNamara  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-27 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

--- Comment #5 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/85578a6f9ca9dfb1e384d8d1f6edd8219a2ac493

tdf#129037 disable updates during multiselection

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:6.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c8afb4000f178badaf63c2f38fd3fbc12ec832f3

tdf#129037 add a way to select multiple entries of a ListBox together

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

--- Comment #3 from Caolán McNamara  ---
that would bring it down to 2 seconds for me and with
https://gerrit.libreoffice.org/#/c/83774/ added on I get 0 seconds

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from Caolán McNamara  ---
selectItemsPos is implemented by VCLXListBox::selectItemsPos in
toolkit/source/awt/vclxwindows.cxx and that loops over each index and calls
ListBox::SelectEntryPos in a loop where SelectEntryPos is in
vcl/source/control/listbox.cxx where the slow bits seems to be the very
expensive CallEventListeners calls

checking VclEventId::ListboxSelect uses I don't think there is any use of the
position argument passed in so I don't think that matters too much, consumers
seem to just look up what is selected themselves, so its plausible that we
could get away with a single CallEventListener in this scenario

https://gerrit.libreoffice.org/#/c/83771/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 129037] BASIC: Selecting items in a visible list box in a dialog is very slow

2019-11-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129037

Mike Kaganski  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #1 from Mike Kaganski  ---
Caolán, do you know if it's expected that XListBox::selectItemsPos behaves as
multiple separate refreshing select operations?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs