[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2022-02-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Michael Stahl (allotropia)  changed:

   What|Removed |Added

Version|3.4.0 release   |Inherited From OOo

--- Comment #7 from Michael Stahl (allotropia)  ---
looks like OOo 3.3 saved it as this also invalid variant:

form:current-value="1212"

in OOo 3.4 beta it is:

form:current-value="PT12H12M00S"

there are actually 2 wrong attributes

form:current-value="PT12H12M00S" form:max-value="PT23H59M59.99S" 

or even 4 maybe, form:value and form:min-value aren't written by default but
also have type "time"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-09-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Alex Thurgood  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3510

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

--- Comment #6 from Lionel Elie Mamane  ---
The error messages in comment 5 (for versions 3.4 and 3.5) suggest that the
issue is not one of XMLSchema 2 time datatype vs XMLSchema 2 duration datatype,
but that the validator expects a duration, but with all elements written out,
down to centiseconds, while the file contains only the elements actually
present and non-zero.

I mean, the error message looks like it wants PT12H12M00.00S instead of
PT12H12M00S or PT12H12M.

Is that because LibO 3.4 and 3.5 issue a different ODF version, and that part
of the specification has changed?

I see in the ODF spec (both 1.0 and 1.2) that an office:time-value must be
coded as an XMLSchema 2 *duration*, not *time*. That doesn't seem to apply to
form:current-value, though. Why the difference, I'm not sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Aron Budea  changed:

   What|Removed |Added

Version|4.1 all versions|3.4.0 release
   Keywords|bibisectRequest |preBibisect

--- Comment #5 from Aron Budea  ---
In 3.4.0.1 and in oldest commit of bibisect-43all, the validation error message
is already there, though slightly different:
1time.odt/content.xml[2,4116]: Error: attribute "form:current-value" has a bad
value: "PT12H12M00S" does not satisfy the "time" type PT23H59M59.99S"
form:validation="true">

In 3.5.0.3 the error message is:
1time.odt/content.xml[2,4284]: Error: attribute "form:current-value" has a bad
value: "PT12H12M" does not satisfy the "time" type PT23H59M59.99S"
form:validation="true">

After the first commit in comment 2's commit list (in bibisect-41max), the
error message is:
1time.odt/content.xml[2,4286]: Error: attribute "form:current-value" has a bad
value: "P0D" does not satisfy the "time" type PT2.086692451S"
form:validation="true">

This probably changes in later commits, I'm assuming there's no point in
checking those.

=> Setting keyword preBibisect.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Lionel Elie Mamane  changed:

   What|Removed |Added

   Keywords|bibisected  |bibisectRequest

--- Comment #4 from Lionel Elie Mamane  ---
(In reply to Xisco Faulí from comment #3)
> Setting to NEW and bibisected based on comment 2

"smells like" means it is my guess, and here are pointers. But that is just an
educated guess. A bibisect would be far more definitive. Setting back to
bibisectRequest.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Xisco Faulí  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1148

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Xisco Faulí  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords|bibisectRequest |bibisected

--- Comment #3 from Xisco Faulí  ---
Setting to NEW and bibisected based on comment 2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Michael Stahl (CIB)  changed:

   What|Removed |Added

 Whiteboard||odf odf_validation

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-05 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

--- Comment #2 from Lionel Elie Mamane  ---
This smells like it could have been introduced by the changes done around the
incompatible API/ABI change we had around the time of 4.1 (introduction of
nanosecond precision in times). I might have done it consciously, without
realising the consequences on ODF compliance, because time controls are (or I
thought they could be) (ab)used for duration fields in databases (and thus can
overflow 24h).

Whoever wants to investigate this can look at these candidates:

commit f5c7e770314826c121fb6a03d56f424d308e1e2f
Author: Lionel Elie Mamane 
Date:   Wed Feb 5 16:53:10 2014 +0100

commit 8ee69b0ba13f74d1515fac71df92947eb6328ab1
Author: Lionel Elie Mamane 
Date:   Sun Aug 4 01:14:22 2013 +0200

commit f4cadd9772ed0ff6e7f7b170080f90384d1f2318
Author: Lionel Elie Mamane 
Date:   Sat Aug 3 11:05:21 2013 +0200

commit ed904af8665f6f7590fedd4ad608018f78c686c1
Author: Lionel Elie Mamane 
Date:   Sun Jul 28 16:08:26 2013 +0200

commit 202d45cff25492bb4d7f550df5c368af097d2e0c
Author: Lionel Elie Mamane 
Date:   Fri Apr 19 07:14:48 2013 +0200

commit 81cf58f191f57b3cfad08f5c7d622b30f7fc72d9
Author: Lionel Elie Mamane 
Date:   Fri Apr 19 07:14:23 2013 +0200

commit f805afcf4c3056feb1690393d907442cf337b484
Author: Lionel Elie Mamane 
Date:   Thu Apr 18 23:00:07 2013 +0200

commit 9830fd36dbdb72c79703b0c61efc027fba793c5a
Author: Lionel Elie Mamane 
Date:   Sun Mar 17 08:36:26 2013 +0100

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131127] FILESAVE: Form: incorrect "time" type

2020-03-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131127

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 CC||lio...@mamane.lu,
   ||michael.st...@cib.de,
   ||mikekagan...@hotmail.com,
   ||xiscofa...@libreoffice.org
Version|7.0.0.0.alpha0+ Master  |4.1 all versions

--- Comment #1 from Xisco Faulí  ---
Reproduced back to

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)

but not in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs