[Libreoffice-bugs] [Bug 132770] Underline words from HTML document do not appear

2020-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132770

--- Comment #2 from Konstantin Kharlamov  ---
Okay, so a couple of updates:

1. The gdb taking GBs of memory turned out to be a bug in gdb
https://sourceware.org/bugzilla/show_bug.cgi?id=25965
2. You can make it work with one of the following changes:
* replace `ins` with `u` tag
* add into html file (or to a separate CSS file) a style for `ins` tag as
follows:

  
ins {
text-decoration: underline;
}
  

What basically happens is that html parser queries known styles by executing
`pCFormat = m_pDoc->FindCharFormatByName( "ins" )`. It does not find one, and
creates one with default text property.

I'll try to see if there is any obvious solution, but I suspect solution should
be creating default "underlined" style for `ins` tag but using it *only* when
there's no override in a CSS. Since I don't know the code nor where to look at
examples, I might have a problem with implementing that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132770] Underline words from HTML document do not appear

2020-05-10 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132770

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2773

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132770] Underline words from HTML document do not appear

2020-05-07 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132770

--- Comment #1 from Konstantin Kharlamov  ---
I have debugged this for a bit, to give some update: it looks like LO Writer
has support for  tag. So what happens here seems to be an actual bug (I
mean, missing support for basic tag would be one too, but it could've been
fixed much easier).

At the moment I figured that the difference between when "italic" and
"underline" are parsed is the content of `pCFormat` being assigned as:

SwCharFormat* pCFormat = m_pCSS1Parser->GetChrFormat( nToken, aClass );

Its field pCFormat->m_aSet has 3 members in case of italic:

11 = {
  > = {
 = {
   = {
_vptr.SfxPoolItem = 0x7ff263673c70 ,
m_nRefCount = 2,
m_nWhich = 11,
m_nKind = SfxItemKind::NONE
  }, },
members of SfxEnumItem:
m_nValue = ITALIC_NORMAL
  }, },
…
25 = {
  > = {
 = {
   = {
_vptr.SfxPoolItem = 0x7ff263673c70 ,
m_nRefCount = 2,
m_nWhich = 25,
m_nKind = SfxItemKind::NONE
  }, },
members of SfxEnumItem:
m_nValue = ITALIC_NORMAL
  }, },
26 = 0x0,
…
29 = 0x0,
30 = {
  > = {
 = {
   = {
_vptr.SfxPoolItem = 0x7ff263673c70 ,
m_nRefCount = 2,
m_nWhich = 30,
m_nKind = SfxItemKind::NONE
  }, },
members of SfxEnumItem:
m_nValue = ITALIC_NORMAL
  }, },

But in case of underlined it is all zeroes. Not sure just yet what to make of
it.

Doesn't help though is that gdb is like trying to explode while loading the
office. It quickly grew to 2.2GB and hanged for 5 minutes on printing the
field, so I had to -SIGKILL it in the end. I am wondering if it can be cause by
pretty-printers of LibreOffice and whatnot. Does gdb load them by default?
Gotta check that out, I've never seen such behavior with gdb before.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs