[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEW |RESOLVED

--- Comment #11 from Heiko Tietze  ---
Thanks for the clarification, Mike.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #10 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #9)
> ... my model of PS > CS > DF

Heh, your model is wrong. In the simplified case of only considering two kinds
of formatting (paragraph vs character), the model is like "PS > paragraph-level
DF > CS > character-level DF".

Paragraph-level settings include all properties specific to paragraph (like
line spacing or indents), but *also* all character properties as some default
for the paragraph content. And if your DF applies to *characters* or to
*paragraph* depends on the selection at the moment of applying the DF. Of
course, when you select a couple of characters in the middle of a paragraph,
and modify left indent, that setting naturally goes to the paragraph level -
just because that setting can't be on character level. But when you define
underlining, *if you selected a couple characters in the middle*, it's a
character-level DF; and *if you selected the whole paragraph*, it's defined on
paragraph level. It's just a decision (I suppose, some UX-based), and it could
be defined differently (like always defining DF for character properties on
character level) - but I don't know what is broken by that.

However, that is irrelevant to this issue. Be the color and character style
defined on paragraph level, or on character level, would not change the
observed result of comment 0. Because what matters is that applying any style
only resets DF fro properties *defined in the style*, and the CS in question
("Example") defines only a single "font name" property, thus any other property
would not be modified (or overridden).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #9 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #8)
> You have some settings defined on *paragraph* level..

Could you please go in detail with "defining on paragraph level" vs. "defining
on character (or selection?) level"? 
It doesn't fit my model of PS > CS > DF. I assume some code, cleaning DF when
all PS is formatted similarly rather than putting the attribute on different
levels depending on... what?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #8 from Mike Kaganski  ---
There is no bug here.

You have some settings defined on *paragraph* level: text background,
strike-out, underline, character style. They define character look and feel,
but - again - are defined on the *paragraph* level.

Applying any style only clears DF *on its level*; and *only that formatting
that is defined in the style*.

Applying a paragraph style clears all DF *on paragraph level* - because PS
always defines *all* paragraph formatting.

Applying a character style clears the DF *for settings defined in the CF*; and
only that *defined on the character level*. (The visual result would be as if
paragraph-level setting is replaced - but not because paragraph-level DF was
cleared, but because it was overridden.)

Since CS *only* defined some settings, and not all, that relate to character
appearance and behaviour, it's normal to see that all settings not defined in
"Example" SC are still taken from paragraph level. Even if they were defined on
character level, they wouldn't be cleared either, because - well, as I said,
only properties defined in style are cleared from DF for the affected text run.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

Heiko Tietze  changed:

   What|Removed |Added

 CC||michael.st...@cib.de,
   ||mikekagan...@hotmail.com,
   ||qui...@gmail.com

--- Comment #7 from Heiko Tietze  ---
Insert formatted dummy text [1] and apply PS to the paragraph with DF. Nothing
changes. And applying CS to the DF-formatted text adds those attributes to the
DF.

My first thought was that "Default PS" means no style has been applied and
setting a PS forces an override. Workaround would be to set Text Body by
default (bug 47295). See also bug 89826.

But if you add a second word to your example and remove the formatting it works
as expected (CS and DF remains). Meaning PS changes the formatting only when
the whole paragraph has the same formatting. Hard to understand for users.

Michael S, any insights?

[1] https://extensions.libreoffice.org/extensions/formatted-dummy-text

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #6 from Telesto  ---
(In reply to BogdanB from comment #5)
> In fact I noticed this bug a year ago, but I thought this was so by design.

I report it as a bug, when I assume it's bug it could still be by design
:-).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #5 from BogdanB  ---
In fact I noticed this bug a year ago, but I thought this was so by design.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

BogdanB  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #4 from BogdanB  ---
I confirm it.
But I tested with other styles.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #3 from Telesto  ---
(In reply to BogdanB from comment #2)
> In this case default is Liberation Serif and Example is Liberation Mono. So,
> you can not see the difference. Try with another character style. It will
> work.

True.. but Paragraph style is removing all direct formatting: bold, underline
Italic, strike through, font color, highlighting... and character style doesn't

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

Telesto  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #2 from BogdanB  ---
In this case default is Liberation Serif and Example is Liberation Mono. So,
you can not see the difference. Try with another character style. It will work.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133134] Inconsistency between paragraph style/character style overwritting direct formatting when applying

2020-05-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133134

--- Comment #1 from Telesto  ---
Created attachment 160953
  --> https://bugs.documentfoundation.org/attachment.cgi?id=160953=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs