[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||3927 --- Comment #7 from Ming Hua --- (In reply to pb from comment #6) > I'd be curious to look at the code for that, although > I'm not in a position to learn enough to fix it. Can you point me to which > module it would be in? That's great! The UI part should all be in sc/uiconfig/scalc/ui/ (the files condformatmanager.ui, conditionalentry.ui, and conditionalformatdialog.ui): https://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/ui/ There is also this commit that should be the source of this regression (see the bisect log of bug 123927): https://git.libreoffice.org/core/+/5b8c22379e2eae74f7ed78326ab89483db5c6624%5E%21/ I'm not a developer either, so if you have further quesions I'd like to direct you to the dev mailing list: https://lists.freedesktop.org/mailman/listinfo/libreoffice I'm sure the developers there will be happy to anwser questions regarding the code. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 --- Comment #6 from pb --- Well, as long as you agree it's a bug, I'm happy. I've provided a lot of details, so if someone decides to work on it, hopefully it'll be clear at least what I think it should be doing. It seems that conditional formatting is a bit of a mess, based on the other bug reports I see. I'd be curious to look at the code for that, although I'm not in a position to learn enough to fix it. Can you point me to which module it would be in? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 Ming Hua changed: What|Removed |Added Status|NEEDINFO|NEW Blocks||87351 --- Comment #5 from Ming Hua --- Yes, I agree it's a bug. However it's more about "grouped CF can't be edited individually, and the UI showing individual cell's CF is confusing". Reproduced with 6.4.4 on Windows 10: Version: 6.4.4.2 (x64) Build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; Locale: zh-CN (zh_CN); UI-Language: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=87351 [Bug 87351] [META] Conditional formatting bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 --- Comment #4 from pb --- I'm now thinking that the main bug might really be in the intervening modal dialog when I click on the 'condition' tool. Doing so launches a yes/no dialog that asks: "The selected cell already contains conditional formatting. You can either edit the existing conditional format or you define a new overlapping conditional format. Do you want to edit the existing conditional format?" If I click 'yes' I get what I have been reporting, which in fact does NOT allow me to edit the existing format. If I click 'no', it just exits and does nothing. Maybe what is supposed to be happening is that if I click 'yes' it sends me to the dialog I expect, which would show the existing CF, and if I click 'no' it should send me to the dialog which shows only the "overlapping" creation option (which I would call 'shadowing'). However, even if that is the bug, what it really should do is avoid that intervening dialog altogether, and just send me to a dialog that shows all conditional formatting on the selected cell, and offers an 'add a condition' button, as well as a 'cancel' button. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 --- Comment #3 from pb --- The answer to your question is yes, the same dialog obtained by clicking the 'condition' conditional formatting icon. Checking Format > Conditional > Condition..., it does indeed show that both cells have the correct formatting information. However, what I report is still a bug. Because the 'condition' tool refers to the single cell which is selected (or at least that's what a reasonable user would expect), it should report what the formatting is *for that cell*. It does have what I consider to be the correct behavior in v5.0.1. In addition, If, again using the condition tool as in my original report, I create a format for a random cell, then use it again to create the same format for some other random cell, after that the condition tool *does* still show each cell's conditional format. There is no reason *from the user's perspective* why that should result in different behavior. (...even if it might make sense from the perspective of simplifying the code.) As for the 'manage' dialog, it is also inconsistent, because when the condition is copied, it shows the copies as a list, but when created independently, it shows them independently. What's more, it appears that using the condition tool (icon) ADDS a shadowing condition, rather than EDITING the existing condition as the intervening dialog asserts. Most of this is counterintuitive, i.e. bad UI/UX design. At the very least, the "condition" tool should be called "add a condition without showing you any previous conditions that might apply to this cell, and that will not change any of the previous conditions." The way I would expect this all to work would be that the 'condition' tool would show the user ALL conditions that apply to that cell, and allow the user to edit each of them. If a cell's property is copied, the state of the copied cell should not change when interrogated by that tool. As for the 'manage' dialog, it appears that if you have thousands of conditions, the manage dialog could become unmanageable. Maybe that's the motivation of the feature to group copied formats together. However, that should then also happen when the CF is created independently. I'm therefore not seeing any way to query the conditional formatting state of a single selected cell, without using the manage dialog that will show it for all cells. Am I missing that? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 Ming Hua changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||ming.v@qq.com --- Comment #2 from Ming Hua --- I think I know what you mean, but I need clarification: (In reply to pb from comment #0) > Steps to Reproduce: > New spreadsheet. > Create a condition in say cell e5 using condition tool, for example if =1, > make it yellow. > Condition works. > Re-opening conditional formatting dialog shows the expected condition and > result. What exactly do you mean by "Re-opening conditional formatting dialog"? If I choose menu Format > Conditional > Condition..., a dialog pops up asking me if I want to edit the existing conditional format. Clicking Yes gets me back to the same dialog used for creating the conditional format. On the other hand, there is the Format > Conditional > Manage... dialog, which is different. > Copy cell e5. > Paste special formats only into cell c5. > Reopen conditional formatting dialog for cell e5. It now shows no format. > Test whether e5 conditional formatting still works. It does. > Test whether c5 conditional formatting works. It does. > Open conditional formatting dialog for cell e5. It now shows no format. > Open conditional formatting dialog for cell c5. It shows no format. If your answer to my previous question is the same dialog after clicking yes, then you want to try reopening the dialog while both C5 and E5 are selected (hold Ctrl key while clicking them with mouse), this way the condition (equals to 5) is correctly displayed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133242] Calc conditional formatting condition dialog (ui) changes to no condition after copy: regression
https://bugs.documentfoundation.org/show_bug.cgi?id=133242 --- Comment #1 from pb --- This exact bug did not exist in v 5.0.1, not sure when it reappeared. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
