[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

b.  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |newbie...@gmx.de
   |desktop.org |

--- Comment #10 from b.  ---
i tried to submit it as a patch, 

https://gerrit.libreoffice.org/c/core/+/95095

i don't know how to proceed, it would be nice if one of the professionals could
put it on the right track (check, release, whatever ...) 

add. reference: 

Change-Id: I1dffdef15ac9add1ab4612f4dbc33ad207d9389b

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

b.  changed:

   What|Removed |Added

Version|4.1.6.2 release |3.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #9 from b.  ---
@all: 

could you please check if the following patch fixes this bug, it's 'only' a
change of the 'preset?' of bByRow from 'false' to 'true' in xmldrani.cxx,
sounds logic for me, bByRow 'false' while 'row' is default is somewhat odd, 

i did some tests, looks good, but please! check also affects to other things
like sort, horizontal sort, oriental table orientations etc.,  

and if the patch is ok tell me how to place it as a commit? thanks in advance, 

[LO-main-dir]/sc/source/filter/xml/xmldrani.cxx:

107c107,116
< bByRow(false),
---
> // bs-edit: the following is an attempt to solve the wrong applied filter 
> conditions on reload of files saved in *.ods format with active filters, 
> // bs-edit: see tdf #16, please recheck!!!, affects only some files 
> where the database range has asymmetric start (off from A1-B2-C3-D4-E5-F6 
> ...), 
> // bs-edit: there are oddities left, as without this patch the .field 
> values for the filterdescriptor have been wrong from the first reload on, 
> // bs-edit: they are now still for load of 'prior-patch' 'second and 
> subsequent' saves, i've not yet checked if old files are 'healed' on new 
> save, 
> // bs-edit: some affected files may be spotted by negative values for 
> .fields, some more by the tag 'table-orientation="column"', but that may be 
> correct for some of them, 
> // bs-edit: for the gui access it looks as if the tag 
> 'table-orientation="column"' and the wrong .field values cancel each other 
> out as well with or without the patch, 
> // bs-edit: the patch is intended to apply from ver. 7.0 on, backport to 
> old ver.?, if the patch holds these comments should be removed starting with 
> ver. 9.0, !!FIXME-9.0!!
> // bs-edit: original was: bByRow(false),
> // bs-edit: test: 
> bByRow(true),

sorry if any mistakes, it's new territory for me ... 

reference for checks in the code: if i'm right last correct version was
3.5.1.2, and bug started in 3.5.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #8 from b.  ---
@Regina: 

thanks for checking, 

yes, it's a bug in calc, not in ODF, 

no, a program shouldn't have bugs producing non conformant documents (this bug
is affecting functionality too), 

i suspect fixing it might raise some compatibility problems for existing
documents? 

would you agree that it's a good idea to fix it for the use of 1.3 format from
the beginning? i checked with recent 7.0 in 1.3 extended format, same behaviour
as with 1.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #7 from Regina Henschel  ---
Essential part of the description is "should not start at fields
A1-B2-C3-D4-E5-F6 ...,"

I think, it is nothing about ODF, but a simple bug in LibreOffice. Apache
OpenOffice does not show this error. In LibreOffice I see it already in
LibreOffice 3.5.4.2 
Build ID: 165a79a-7059095-e13bb37-fef39a4-9503d18



(In reply to Telesto from comment #6)
> Second attempt.. Adding Regina, the ODF standard specialist
Sometimes other things are more important than Bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

Telesto  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #6 from Telesto  ---
Second attempt.. Adding Regina, the ODF standard specialist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Telesto  ---
I'm seeing the "-1" error with https://odfvalidator.org. However, I really
don't know anything about this kind of issue...


Adding Regina, the ODF standard specialist

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #4 from Telesto  ---
Created attachment 161279
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161279&action=edit
Step 1 and 2 File

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #3 from b.  ---
may i ask senior members to raise severity because: 

- produced documents are not odf 1.2 (extended) compatible after second save, 

- there is a small time window to solve the problem with switching to odf 1.3
in LO 7.0 for future cases before! there are many documents in circulation that
could get compatibility problems, 

simple reproducer: 

B3:a, B4:1, B5:2
data - define range - name "b", range "B3:B5"
data - autofilter
click button, uncheck '1', 
file save, use odf 1.2 extended format (tools - options - load/save - general)
close file, load file, 
file save, new name, 

check both saved files with https://odfvalidator.org/, the first will pass, the
second will fail

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #2 from b.  ---
Created attachment 161215
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161215&action=edit
file 'second save' with wrong filter definitions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133336] calc: fileopen: filter: irregular reading and saving of filter definitions in ods format affecting all filters

2020-05-24 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=16

--- Comment #1 from b.  ---
Created attachment 161214
  --> https://bugs.documentfoundation.org/attachment.cgi?id=161214&action=edit
file 'first save' with correct filter definitions

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs