[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2021-04-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

andreas_k  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #8 from andreas_k  ---
Thanks, work well with PopupLabel

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2021-04-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

--- Comment #7 from Commit Notification 
 ---
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2d729251b7bf8f505acb65c620c58ba8bae9ff3d

tdf#134373 add PopupLabel to update commands for NB see c5 option 2

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2021-04-16 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2021-04-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

andreas_k  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2021-03-21 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Jean-François Fortin Tam  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1138

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-15 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicDesign

--- Comment #6 from Heiko Tietze  ---
Standard menu has:

* .uno:UpdateAll > "Update All" > toolbar button right-most on tabbed ui and in
the References menu
* .uno:Repaginate > "Page Formatting" > not in the tabbed ui
* .uno:UpdateFields > "Field" > in the References menu
* .uno:UpdateAllIndexes > "Indexes and Tables" > not in the tabbed ui
* .uno:UpdateCurIndex > "Current Index" > with popup label "Update Index" at
the NB
* .uno:UpdateAllLinks > "Links" > not in the tabbed ui
* .uno:UpdateCharts > "Charts" > not in the tabbed ui

So my take:

# remove "Update All" from the menu () - it's redundant
# .uno:InsertFieldCtrl and .uno:UpdateFields are (Insert) > Field > ... and
(Update) > Field, it makes no sense to rename; since (Insert) > Fields is on
the NB I suggest to remove this too from the menu ()

Source file is sw/uiconfig/swriter/ui/notebookbar.ui

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Maxim Monastirsky  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

--- Comment #5 from Maxim Monastirsky  ---
Am I correct that all the commands in question are menu item, not buttons? In
this case I see 4 possible solutions:

1) Move them into a sub menu, like they are in the main menu bar.

2) Menus attached to toolbar/notebookbar buttons use PopupLabel instead of
ContextLabel/Label. Given that these commands never appear in context menus, I
think we can use PopupLabel here for the NB needs.

3) Create aliases for these commands, as in Bug 115965 comment 16.

4) As a last resort, labels can be defined directly in the NB .ui files. ("last
resort" because the same menu can appear in several NB files, so it will add
more work for translators.)

(In reply to Heiko Tietze from comment #4)
> Maxim, what do you think about a dedicated NotebookbarLabel?
Adding a dedicated property for the toolbar/NB was one of the ideas in Bug
108458. The problem is that the current UI labels storage and its fallback
mechanism are too complex already. Adding more properties is possible if
needed, but ideally this should be done as part of an overall thinking on how
all that stuff should work altogether. (Also note that new properties become
part of the configuration schema, for which we prefer to not make incompatible
changes. So once a property is introduced, it might not be that easy to remove
it.)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Heiko Tietze  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #4 from Heiko Tietze  ---
Maxim, what do you think about a dedicated NotebookbarLabel? Would require
changes at vcl/source/helper/commandinfoprovider.cxx and somewhere at the NB
implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

--- Comment #3 from andreas_k  ---
the names come from the uno command. so the uno command name has to be changed,
which is no problem, but you have to have also a look to menubar where the
command will be used also.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||102062


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102062
[Bug 102062] [META] Notebookbar: bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||kain...@gmail.com

--- Comment #2 from Heiko Tietze  ---
Andreas, can you name the commands for NB mode differently? If not, any idea?
Perhaps place the commands differently.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-07-13 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134373] Tools > Update > (submenu items) are taken out of context in alternative toolbar modes such as grouped compact

2020-06-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134373

Jean-François Fortin Tam  changed:

   What|Removed |Added

Summary|Tools > Refresh > (submenu  |Tools > Update > (submenu
   |items) are taken out of |items) are taken out of
   |context in alternative  |context in alternative
   |toolbar modes such as   |toolbar modes such as
   |grouped compact |grouped compact

--- Comment #1 from Jean-François Fortin Tam  ---
Actually the term in the English version is "Update", not "Refresh"... so
mentally replace "Refresh" by "Update" in my comment/description above.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs