[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Michael Stahl (allotropia) changed: What|Removed |Added Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | Status|NEW |RESOLVED --- Comment #14 from Michael Stahl (allotropia) --- i think i managed to fix something here, but it's rather tricky to know for sure. the first problem was that when the redlines are moved for both Show and Hide, the existing paragraph properties at the target weren't cleared. the second problem was that when the redlines are moved for Show, the paragraph properties were applied only to the start paragraph, not to the end paragraph. of course these problems have always existed, it just wasn't obvious previously when you could edit the document in the "hidden" state. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #13 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/81273c65dd9cec5acd9464b9041f452a5481e10e tdf#134759 sw: do CopyToModify() for both start and end node It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Aron Budea changed: What|Removed |Added CC||aron.bu...@gmail.com Keywords|bibisectRequest |bibisectNotNeeded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #12 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/cdf48e57da6b8a6a5eb4131340fa2c14be135714 tdf#134759 sw: clear items in SwAttrSet::CopyToModify() It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Commit Notification changed: What|Removed |Added Whiteboard|target:7.5.0|target:7.5.0 ||target:7.4.0.0.beta2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #11 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3707c0b4ff683ac6f0942a176ebcb8d824b567ee tdf#134759 sw: clear items in SwAttrSet::CopyToModify() It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Gabor Kelemen (allotropia) changed: What|Removed |Added Regression By||Michael Stahl CC||kelem...@ubuntu.com -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759
--- Comment #10 from Michael Stahl (allotropia)
---
merged para is from node 93 to 254, 254 is pParaPropsNode - both before and
after save.
the difference is that before save node 254 had:
72 = {
= {
= {
= {
_vptr.SfxPoolItem = 0x7f7e7a6b3940 ,
m_nRefCount = 3,
m_nWhich = 72,
m_nKind = SfxItemKind::NONE
},
members of CntUnencodedStringItem:
m_aValue = ""
}, }, },
while after save:
72 = {
= {
= {
= {
_vptr.SfxPoolItem = 0x7f7e7a6b3940 ,
m_nRefCount = 92,
m_nWhich = 72,
m_nKind = SfxItemKind::NONE
},
members of CntUnencodedStringItem:
m_aValue = "Bullet "
}, }, },
79 = {
= {
= {
_vptr.SfxPoolItem = 0x7f7ec29d0680 ,
m_nRefCount = 80,
m_nWhich = 79,
m_nKind = SfxItemKind::NONE
},
members of CntUInt16Item:
m_nValue = 2
}, },
82 = {
= {
= {
_vptr.SfxPoolItem = 0x7f7ec29d2398 ,
m_nRefCount = 93,
m_nWhich = 82,
m_nKind = SfxItemKind::NONE
},
members of CntUnencodedStringItem:
m_aValue = "list2998949076"
}, },
83 = {
= {
_vptr.SfxPoolItem = 0x7f7ec29d0710 ,
m_nRefCount = 75,
m_nWhich = 83,
m_nKind = SfxItemKind::NONE
},
members of SfxInt16Item:
m_nValue = 1
},
92 = {
= {
_vptr.SfxPoolItem = 0x7f7ec4dac8d8 ,
m_nRefCount = 113,
m_nWhich = 92,
m_nKind = SfxItemKind::NONE
},
members of SvxULSpaceItem:
nUpper = 200,
nLower = 120,
bContext = false,
nPropUpper = 100,
nPropLower = 100
},
... apparently these items were on pFirstNode before saving, then moving the
redlines merged first and last paragraph, then moving redlines back didn't fix
it.
hmm not obvious what to do about this.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added Keywords|bibisected, bisected|bibisectRequest --- Comment #9 from Telesto --- (In reply to Buovjaga from comment #8) > Bibisected with linux-64-6.3 to > https://git.libreoffice.org/core/commit/ > 32902f66e7749b2d06d13f50416be5323a0c0ea9 > sw_redlinehide: make layout based Show/Hide mode the default > > Adding Cc: to Michael Stahl > > The commit is referenced in multiple regressions, please see query: > https://bugs.documentfoundation.org/buglist. > cgi?keywords=regression%2C%20_type=allwords_id=1249164 > =32902f66e7749b2d06d13f50416be5323a0c0ea9_type=allwordssubstr_ > format=advanced Needs another round of bibisecting with environment variable SW_REDLINEHIDE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||ilmari.lauhakangas@libreoff ||ice.org, ||michael.st...@allotropia.de Blocks||138327 Version|7.1.0.0.alpha0+ |6.3.0.4 release Keywords||bibisected, bisected, ||regression --- Comment #8 from Buovjaga --- Bibisected with linux-64-6.3 to https://git.libreoffice.org/core/commit/32902f66e7749b2d06d13f50416be5323a0c0ea9 sw_redlinehide: make layout based Show/Hide mode the default Adding Cc: to Michael Stahl The commit is referenced in multiple regressions, please see query: https://bugs.documentfoundation.org/buglist.cgi?keywords=regression%2C%20_type=allwords_id=1249164=32902f66e7749b2d06d13f50416be5323a0c0ea9_type=allwordssubstr_format=advanced Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138327 [Bug 138327] [META] sw_redlinehide regressions (track changes) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added Resolution|DUPLICATE |--- Status|RESOLVED|UNCONFIRMED --- Comment #7 from Telesto --- (In reply to Timur from comment #5) > Lowest priority because minor issue with strange file of unknown origin that > has bigger issues: crash on content delete, content remains after delete, > track not shown.. 1) Strange file .. What makes it a strange file? 2) Unknown origin (see comment 3) 3) Content remains after delete? They table? Or something else, be specific please 4) Crash on content delete (solved) See bug 134770 5) Track not shown.. What do you mean? And also don't add it as duplicate of bug 134773. This only suggests you're not understanding the issue or the difference between both. Or ending up making a mess with duplicates. Or you want to close it for other reason not explicitly stated, but even then don't use duplicate if it isn't -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Timur changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #6 from Timur --- *** This bug has been marked as a duplicate of bug 134773 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Timur changed: What|Removed |Added Severity|normal |trivial Priority|medium |lowest --- Comment #5 from Timur --- Lowest priority because minor issue with strange file of unknown origin that has bigger issues: crash on content delete, content remains after delete, track not shown.. This bug is not worth reporting nor confirming. Only the crash. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4773 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4746 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4752 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4770 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #4 from Telesto --- Also in Version: 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #3 from Telesto --- Source file: attachment 162927 [details] bug 134746 because older (6.2) versions of LibreOffice render the sample file differently -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #2 from Telesto --- Created attachment 162937 --> https://bugs.documentfoundation.org/attachment.cgi?id=162937=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134759] Tracking changes items appear while not being shown at all
https://bugs.documentfoundation.org/show_bug.cgi?id=134759 --- Comment #1 from Telesto --- Created attachment 162936 --> https://bugs.documentfoundation.org/attachment.cgi?id=162936=edit Example file -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
