[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2021-03-06 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||0826

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-10-12 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

Timur  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||7357

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

--- Comment #15 from Mike Kaganski  ---
(In reply to Radomir Terber from comment #12)
> However I guess the discussion here is relevant. The best solution would be
> to perform deep validation of format of all files against specifications and
> to show message if any file does not follow specification - with option to
> open document with potential data loosing. Also I see space here for
> independent tool that would may correct such documents (out of he scope of
> the LO itself).

This is not a valid approach. There's no way to perform such a "deep
validation" of format, because the format changes over time - current revision
of ECMA-376 is 5th edition. We actually do perform the appropriate validation
as we read the format; but apart from really invalid things like mismatching
tags or duplicating attributes (that make invalid XML) which we actually must
warn and reject or allow the risk of further processing, everything unexpected
from the OOXML PoV we must silently ignore, not stop and warn. So that if
anything is unexpected in the format, we accept that as possibly unknown
extension, and properly *ignore*. Doing otherwise is wrong conceptually. And
that's an obvious bug to not ignore that, but accept as a *different*
element/placement/syntax (I look at you Word :-D).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

--- Comment #14 from Radomir Terber  ---
This is a template engine crated by one of our suppliers. Even if I looked onto
generated files, it looked formally OK. I donť know OOXML (and have no time to
study it), so I supposed that if Word opens the document correctly, it could be
issue of LO. I had no idea that Word opens incorrect document without any
message, warning or so

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

--- Comment #13 from Timur  ---
(In reply to Radomir Terber from comment #12)
> I mentioned that this document is generated and of course we can fix it in
> the generator. 
Are you saying it's some internal software of your company, not of the shelf?

This looks like NotOurBug do far.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

--- Comment #12 from Radomir Terber  ---
Since I do not know OOXML specification, I posted this bug for curiosity that
the behavoiur of both tools is different. I didn't know which kind of
incompatibility is it. I only observed different behaviour of both - LO and
Word. 

I mentioned that this document is generated and of course we can fix it in the
generator. So from my perspective everything is OK when I know the cause :)

However I guess the discussion here is relevant. The best solution would be to
perform deep validation of format of all files against specifications and to
show message if any file does not follow specification - with option to open
document with potential data loosing. Also I see space here for independent
tool that would may correct such documents (out of he scope of the LO itself).

But I understand that the check are time consuming and a lot of work. So
probably current "solution" (to ignore it) is acceptable. Especially in case
when word itself can't create such kind of error.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

--- Comment #11 from Mike Kaganski  ---
(In reply to Telesto from comment #10)
> 1) Why is Word able to handle this? Show Microsoft decided to allow this to
> work? The had to implement this them-self for a reason (even if it's of spec)

Lol. If you see that some program does something when it's fed invalid data, it
doesn't necessarily mean it's intentional. In this case, I'm sure it's called a
bug. To have a bug in your software, you don't have to make any extra effort.
To the contrary. And then people start to generate your files without using its
documentation, and simply test if some weird output they generate happens to
render in your software as they expected. If your software is popular enough,
and many people do that, each your bug sooner or later gets its happy user.

I myself made lots of patches to be "bug-to-bug compatible" with MS Office. So
I know that it makes sense sometimes, but -

the *first* thing to do here is not to discuss if we need to support one of
these bugs. The first thing should be to tell "this file is generated by
software X. We contacted them, and filed the report. But they refused to fix
it, telling ... . The software is used widely, and its impact is large, so that
there are millions invalid documents generated all the time, without any hope
for a fix." ... and only then it's the time to discuss if we need to break our
software.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

Telesto  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #10 from Telesto  ---
(In reply to Mike Kaganski from comment #7)
> Every workaround like this makes our code more fragile, prone to bugs or
> exploits; for the sake of pleasing some lazy developer of invalid
> generators, we risk introducing bugs into normal file handling.

I understand the argument made here.. however out curiosity. 

1) Why is Word able to handle this? Show Microsoft decided to allow this to
work? The had to implement this them-self for a reason (even if it's of spec)

2) And what about file compatibility. Not sure how many of those files are
around. From technical point of view this might be correct answer. However from
user point of view.. If the intended use case is to replace MS Office with
LibreOffice, this might be a hurdle. And saying fix it by using MS Office,
might be saying lets use MS Office in general. 

Should this not better be assessed based what the competitors do? 
-> Google Docs handles this as LibreOffice (didn't check the rest)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 134860] Illegal table in generated DOCX not shown in writer, but shown in Word correctly

2020-07-17 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=134860

Timur  changed:

   What|Removed |Added

   Keywords||filter:docx
   Priority|medium  |low
Summary|Table in the document is|Illegal table in generated
   |not shown in writer, but it |DOCX not shown in writer,
   |is shown in Word correctly  |but  shown in Word
   ||correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs