[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2023-01-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

Miklos Vajna  changed:

   What|Removed |Added

   Keywords|regression  |implementationError

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2023-01-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

Miklos Vajna  changed:

   What|Removed |Added

   Keywords|bibisected, bisected|
  Regression By|Miklos Vajna|

--- Comment #12 from Miklos Vajna  ---
Oh wow, a 4.4 bug, that's really old. :-) Thanks for looking into this. The
commit is related because even if the bugdoc is an odt file, it contains shapes
where the shape type is set to "ooxml-rect".

I tried reverting the mentioned commit, bit I can still reproduce the bug, so
something else broke this in the meantime as well.

Otherwise it would not be a huge problem to just revert the above commit: VML
export is only relevant for MSO 2007 and earlier, which is EOL more than 5
years ago.

If somebody wants to do that, you could do a bisect (not bibisect) with the
above commit reverted to find the other commit(s) that breaks this scenario.

Oh, and for me inserting a random image didn't reproduce, I had to use the
toolbar button to insert a chart. Adjusting keywords accordingly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2022-12-26 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

--- Comment #11 from Buovjaga  ---
(In reply to raal from comment #9)
> This seems to have begun at the below commit.
> Adding Cc: to Miklos Vajna; Could you possibly take a look at this one?
> Thanks
> 
> @buovjaga - is it the same commit as yours?

Could have been, sorry for not sharing it in 2021.

Now I checked in 44max the commit you shared and the previous and I confirm.

I also see that the example document contains three drawing shapes.

There is also a difference between the two commits in how the elements on the
page are laid out upon opening.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2022-12-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

--- Comment #10 from raal  ---
Created attachment 184348
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184348=edit
empty lines after the commit 0d602133d627c1837eb64895855c2a7ed0144de6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2022-12-25 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

raal  changed:

   What|Removed |Added

  Regression By||Miklos Vajna
   Keywords|bibisectRequest |bibisected, bisected
 CC||r...@post.cz,
   ||vmik...@collabora.com

--- Comment #9 from raal  ---
This seems to have begun at the below commit.
Adding Cc: to Miklos Vajna; Could you possibly take a look at this one?
Thanks

@buovjaga - is it the same commit as yours?
@Miklos - I see, the commit looks unrelated, but I can repeat that one commit
before your commit it worked (git checkout
c8369a9a3c22dd47486a7ce36a108d52e5f2b96e -> bug is here; git checkout HEAD~1 ->
bug is not here). Maybe related to empty lines, which exist after your commit?


c8369a9a3c22dd47486a7ce36a108d52e5f2b96e is the first bad commit
commit c8369a9a3c22dd47486a7ce36a108d52e5f2b96e
Author: Matthew Francis 
Date:   Sat Mar 14 21:37:38 2015 +0800

source-hash-0d602133d627c1837eb64895855c2a7ed0144de6

commit 0d602133d627c1837eb64895855c2a7ed0144de6
Author: Miklos Vajna 
AuthorDate: Mon Jun 16 18:45:05 2014 +0200
Commit: Miklos Vajna 
CommitDate: Tue Jun 17 01:16:20 2014 +0200

svx: fix VML export of rectangles imported from drawingML

This wasn't a problem before, as EnhancedCustomShapeTypeNames wasn't
involved for the export of rectangles, as those were handled in sw
directly.

CppunitTest_sw_ooxmlsdrexport's testFdo69636 is a reproducer for this
problem, the VML fallback part was empty due to this.

Change-Id: Ib2622fe05ddaa66bb3231977e30a8a1ca8748001

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-08-14 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

Buovjaga  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #8 from Buovjaga  ---
Tried bibisecting with Linux 44max, but got a bogus result. Someone else could
try

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-07-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

BogdanB  changed:

   What|Removed |Added

 Blocks||143000


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143000
[Bug 143000] [META] Tracked Changes of images
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-06-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

--- Comment #7 from BogdanB  ---
Maybe depends of image size. If the image is taller, filing the page, on undo
will move on the next one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-06-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

--- Comment #6 from Buovjaga  ---
(In reply to BogdanB from comment #5)
> I confirm this bug. In the step 2 there are 2 steps: set the cursor plus
> insert a chart. The chart is on page 2 after the undo.

Ok, I repro with chart, but not with image.

Arch Linux 64-bit
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: c6595e781cf20ab2825e9a2bd8592688f26448e3
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 3 June 2021

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

BogdanB  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from BogdanB  ---
I confirm this bug. In the step 2 there are 2 steps: set the cursor plus insert
a chart. The chart is on page 2 after the undo.

Version: 7.1.3.2 / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

Telesto  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #4 from Telesto  ---
Still repro
related to step 2: -> Place cursor at the end/bottom of the document (toggle
formatting marks on to see where)

Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2021-06-03 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Buovjaga  ---
I don't repro.

Telesto: could you re-test?

Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 3b57ebb445df8a2bc3d916ea79f8af45e20e4e62
CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo

Arch Linux 64-bit
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: c6595e781cf20ab2825e9a2bd8592688f26448e3
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 3 June 2021

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2020-09-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2020-09-18 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #2 from BogdanB  ---
Working well in
Version: 7.1.0.0.alpha0+
Build ID: d57b14e3394b081adf0888ed8dcb7b86d66c246c
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

everything disappeared, except the chart which is on page 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2020-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135237] Image on wrong page after undo rejecting track changes

2020-07-28 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135237

--- Comment #1 from Telesto  ---
Created attachment 163698
  --> https://bugs.documentfoundation.org/attachment.cgi?id=163698=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs