[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2023-10-04 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Blocks||146076


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146076
[Bug 146076] [META] Find & Replace Regular Expressions
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #14 from Edier Guzman  ---
Hi, same behaviour here with version 7.2.2.2:

Version: 7.2.2.2
Build ID: 20(Build:2)
CPU threads: 4; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

After trying to find matches with regular expression '^' in order to put a
single quote at the beginning of each cell, Calc will say that there is no
match.

That is a wrong behaviour, as ^ is a valid regular expression for matching
beginnings of strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2021-11-23 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

LeroyG  changed:

   What|Removed |Added

 CC||edie...@hotmail.com

--- Comment #13 from LeroyG  ---
*** Bug 145856 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2021-11-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5774

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2021-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

 CC||salek.tala...@googlemail.co
   ||m

--- Comment #12 from Michael Warner  
---
*** Bug 145774 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2021-02-09 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Xisco FaulĂ­  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Status|ASSIGNED|NEW
   Assignee|michael.warner.ut+libreoffi |libreoffice-b...@lists.free
   |c...@gmail.com|desktop.org

--- Comment #11 from Xisco FaulĂ­  ---
Dear Michael Warner,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |michael.warner.ut+libreoffi
   |desktop.org |c...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-09-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #10 from Heiko Tietze  ---
Whatever the best example is, if someone volunteers, the label can be used
without deteriorating effect on usability to give feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #9 from ma...@yahoo.co.uk ---
(In reply to Michael Warner from comment #8)
> (In reply to masz0 from comment #7)
> > (In reply to Michael Warner from comment #5)
> > > (In reply to Heiko Tietze from comment #4)
> > > > IIUC, the original request was to find digits like ABC1EFG per "\d *". 
> > > > Works
> > > 
> > > If I am not mistaken, "\d *" has a minimum length of one (a single digit),
> > > so is not an example of this bug. Trying to match "\d*" instead would have
> > > zero length.
> > 
> > No, "\d *" tries to match for 1 digit, followed by 0+ spaces.
> 
> Which is what I was trying to say. At any rate, I don't think it is a valid
> test case for the bug you reported, please correct me if I am wrong.

Oh, sorry, I misunderstood.

Affirmative for "\d *" being an invalid test.

Since it requires and matches one digit, not having any in the input (ABC-EFG)
will make it fail (legitimately; not thru the artificial limitation).

If the input does have digits (ABC1EFG), the pattern will match each in turn.
The matches will be length 1 (or more where followed one or more spaces) -
therefore LO won't discard them.

My problem was specifically about zero-width assertions "(?<=..)", "(?___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #8 from Michael Warner  ---
(In reply to masz0 from comment #7)
> (In reply to Michael Warner from comment #5)
> > (In reply to Heiko Tietze from comment #4)
> > > IIUC, the original request was to find digits like ABC1EFG per "\d *". 
> > > Works
> > 
> > If I am not mistaken, "\d *" has a minimum length of one (a single digit),
> > so is not an example of this bug. Trying to match "\d*" instead would have
> > zero length.
> 
> No, "\d *" tries to match for 1 digit, followed by 0+ spaces.

Which is what I was trying to say. At any rate, I don't think it is a valid
test case for the bug you reported, please correct me if I am wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #7 from ma...@yahoo.co.uk ---
(In reply to Michael Warner from comment #5)
> (In reply to Heiko Tietze from comment #4)
> > IIUC, the original request was to find digits like ABC1EFG per "\d *". Works
> 
> If I am not mistaken, "\d *" has a minimum length of one (a single digit),
> so is not an example of this bug. Trying to match "\d*" instead would have
> zero length.

No, "\d *" tries to match for 1 digit, followed by 0+ spaces.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #6 from Michael Warner  ---
(In reply to Michael Warner from comment #5)
> (In reply to Heiko Tietze from comment #4)
> > IIUC, the original request was to find digits like ABC1EFG per "\d *". Works
> 
> If I am not mistaken, "\d *" has a minimum length of one (a single digit),
> so is not an example of this bug. Trying to match "\d*" instead would have
> zero length.

But searching for "\d*" would match everywhere is not actually that useful.
Where allowing zero-length matches would be useful is with anchors like in the
original request of this bug or the other ones linked in the see also section.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

--- Comment #5 from Michael Warner  ---
(In reply to Heiko Tietze from comment #4)
> IIUC, the original request was to find digits like ABC1EFG per "\d *". Works

If I am not mistaken, "\d *" has a minimum length of one (a single digit), so
is not an example of this bug. Trying to match "\d*" instead would have zero
length.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
   Severity|normal  |enhancement

--- Comment #4 from Heiko Tietze  ---
IIUC, the original request was to find digits like ABC1EFG per "\d *". Works
for me with and without the code around nStartOfs/nEndOfs returning "Search key
not found" for ABC-EFG.

Don't see much benefit from adding a note about zero-length matches to the UI;
although it's easy to implement and unobtrusively replacing the "Search key not
found" label. Point is that you get the zero result anyway. But no objection to
implement this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=38
   ||551

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=58
   ||744

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #3 from Michael Warner  ---
*** Bug 132870 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-31 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

 CC||jim.av...@gmail.com

--- Comment #2 from Michael Warner  ---
*** Bug 52504 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135538] Search-Replace: Regular Expression engine fails on zero length matches

2020-08-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Michael Warner  changed:

   What|Removed |Added

 Ever confirmed|0   |1
  Component|UI  |LibreOffice
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=118887
Version|7.0.0.3 release |3.3.0 release
   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW

--- Comment #1 from Michael Warner  ---
I am able to confirm this in:

Version: 6.0.7.3
Build ID: 1:6.0.7-0ubuntu0.18.04.10
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group


I didn't trace through it while executing, so I may be looking at the wrong
place for this particular test case, but
core/i18npool/source/search/textsearch.cxx lines 942-952 state explicitly that
they are there to ignore zero-length matches. The specific comment is this:
// #i118887# ignore zero-length matches e.g. "a*" in "bc"

It was a decision made in OpenOffice (I added the link to their bug in the See
Also field).

So this is intended behavior to avoid the matching-every-position case, not a
bug. 

Whether it should be intended behavior and how to address it is another
question. Personally, I tend to think that users searching for regular
expressions are knowledgeable about the regex pattern they are providing (or
should be) and therefore we should match the pattern as written.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs